[U-Boot] [PATCH v2] Fix build failure in examples/standalone

[U-Boot] [PATCH v2] Fix build failure in examples/standalone

[Sanjeev Premi]

Some versions of 'make' do not handle trailing white-spaces
properly. Trailing spaces in ELF causes a 'fake' source to
be added to the variable COBJS; leading to build failure
(listed below). The problem was found with GNU Make 3.80.

Using text-function 'strip' as a workaround for the problem.

make[1]: Entering directory `/home/sanjeev/u-boot/examples/standalone'
arm-none-linux-gnueabi-gcc -g  -Os   -fno-common -ffixed-r8 -msoft-float
-D__KERNEL__ -DTEXT_BASE=0x80e80000 -I/home/sanjeev/u-boot/include
-fno-builtin -ffreestanding -nostdinc -isystem /opt/codesourcery/2009q1-
203/bin/../lib/gcc/arm-none-linux-gnueabi/4.3.3/include -pipe  -DCONFIG_
ARM -D__ARM__ -marm  -mabi=aapcs-linux -mno-thumb-interwork -march=armv5
-Wall -Wstrict-prototypes -fno-stack-protector -g  -Os   -fno-common -ff
ixed-r8 -msoft-float   -D__KERNEL__ -DTEXT_BASE=0x80e80000 -I/home/sanje
ev/u-boot/include -fno-builtin -ffreestanding -nostdinc -isystem /opt/co
desourcery/2009q1-203/bin/../lib/gcc/arm-none-linux-gnueabi/4.3.3/includ
e -pipe  -DCONFIG_ARM -D__ARM__ -marm  -mabi=aapcs-linux -mno-thumb-inte
rwork -march=armv5 -I.. -Bstatic -T u-boot.lds  -Ttext 0x80e80000 -o .c
arm-none-linux-gnueabi-gcc: no input files
make[1]: *** [.c] Error 1
make[1]: Leaving directory `/home/sanjeev/u-boot/examples/standalone'
make: *** [examples/standalone] Error 2
premi #

Signed-off-by: Sanjeev Premi <premi@ti.com>
---
 examples/standalone/Makefile |    8 +++++++-
 1 files changed, 7 insertions(+), 1 deletions(-)

diff --git a/examples/standalone/Makefile b/examples/standalone/Makefile
index 5e2f2bc..c02ce43 100644
--- a/examples/standalone/Makefile
+++ b/examples/standalone/Makefile
@@ -38,7 +38,13 @@ ELF-mpc8260                      += mem_to_mem_idma2intr
 ELF-ppc                          += sched
 ELF-oxc                          += eepro100_eeprom
 
-ELF := $(ELF-y) $(ELF-$(ARCH)) $(ELF-$(BOARD)) $(ELF-$(CPU))
+#
+# Some versions of make do not handle trailing white spaces properly;
+# leading to build failures. The problem was found with GNU Make 3.80.
+# Using 'strip' as a workaround for the problem.
+#
+ElF := $(strip $(ELF-y) $(ELF-$(ARCH)) $(ELF-$(BOARD)) $(ELF-$(CPU)))
+
 SREC = $(addsuffix .srec,$(ELF))
 BIN  = $(addsuffix .bin,$(ELF))
 
-- 
1.6.2.2

[U-Boot] [PATCH v2] Fix build failure in examples/standalone

[Peter Tyser]

Hi Sanjeev,

<snip>

>  
> -ELF := $(ELF-y) $(ELF-$(ARCH)) $(ELF-$(BOARD)) $(ELF-$(CPU))
> +#
> +# Some versions of make do not handle trailing white spaces properly;
> +# leading to build failures. The problem was found with GNU Make 3.80.
> +# Using 'strip' as a workaround for the problem.
> +#
> +ElF := $(strip $(ELF-y) $(ELF-$(ARCH)) $(ELF-$(BOARD)) $(ELF-$(CPU)))
> +

I haven't been following the thread, but am assuming the the
capitalization of "ElF" above is a typo?

Best,
Peter

[U-Boot] [PATCH v2] Fix build failure in examples/standalone

[Premi, Sanjeev]

> -----Original Message-----
> From: Premi, Sanjeev 
> Sent: Monday, November 09, 2009 10:43 PM
> To: u-boot at lists.denx.de
> Cc: Premi, Sanjeev
> Subject: [PATCH v2] Fix build failure in examples/standalone
> 
> Some versions of 'make' do not handle trailing white-spaces
> properly. Trailing spaces in ELF causes a 'fake' source to
> be added to the variable COBJS; leading to build failure
> (listed below). The problem was found with GNU Make 3.80.
> 
> Using text-function 'strip' as a workaround for the problem.
> 
> make[1]: Entering directory `/home/sanjeev/u-boot/examples/standalone'
> arm-none-linux-gnueabi-gcc -g  -Os   -fno-common -ffixed-r8 
> -msoft-float
> -D__KERNEL__ -DTEXT_BASE=0x80e80000 -I/home/sanjeev/u-boot/include
> -fno-builtin -ffreestanding -nostdinc -isystem 
> /opt/codesourcery/2009q1-
> 203/bin/../lib/gcc/arm-none-linux-gnueabi/4.3.3/include -pipe 
>  -DCONFIG_
> ARM -D__ARM__ -marm  -mabi=aapcs-linux -mno-thumb-interwork 
> -march=armv5
> -Wall -Wstrict-prototypes -fno-stack-protector -g  -Os   
> -fno-common -ff
> ixed-r8 -msoft-float   -D__KERNEL__ -DTEXT_BASE=0x80e80000 
> -I/home/sanje
> ev/u-boot/include -fno-builtin -ffreestanding -nostdinc 
> -isystem /opt/co
> desourcery/2009q1-203/bin/../lib/gcc/arm-none-linux-gnueabi/4.
> 3.3/includ
> e -pipe  -DCONFIG_ARM -D__ARM__ -marm  -mabi=aapcs-linux 
> -mno-thumb-inte
> rwork -march=armv5 -I.. -Bstatic -T u-boot.lds  -Ttext 
> 0x80e80000 -o .c
> arm-none-linux-gnueabi-gcc: no input files
> make[1]: *** [.c] Error 1
> make[1]: Leaving directory `/home/sanjeev/u-boot/examples/standalone'
> make: *** [examples/standalone] Error 2
> premi #
> 
> Signed-off-by: Sanjeev Premi <premi@ti.com>
> ---
>  examples/standalone/Makefile |    8 +++++++-
>  1 files changed, 7 insertions(+), 1 deletions(-)
> 
> diff --git a/examples/standalone/Makefile 
> b/examples/standalone/Makefile
> index 5e2f2bc..c02ce43 100644
> --- a/examples/standalone/Makefile
> +++ b/examples/standalone/Makefile
> @@ -38,7 +38,13 @@ ELF-mpc8260                      += 
> mem_to_mem_idma2intr
>  ELF-ppc                          += sched
>  ELF-oxc                          += eepro100_eeprom
>  
> -ELF := $(ELF-y) $(ELF-$(ARCH)) $(ELF-$(BOARD)) $(ELF-$(CPU))
> +#
> +# Some versions of make do not handle trailing white spaces properly;
> +# leading to build failures. The problem was found with GNU 
> Make 3.80.
> +# Using 'strip' as a workaround for the problem.
> +#
> +ElF := $(strip $(ELF-y) $(ELF-$(ARCH)) $(ELF-$(BOARD)) $(ELF-$(CPU)))
> +
>  SREC = $(addsuffix .srec,$(ELF))
>  BIN  = $(addsuffix .bin,$(ELF))
>  
> -- 
> 1.6.2.2
> 
> 

Hi,

Just wanted to check if this update is okay?

Best regards,
Sanjeev

[U-Boot] [PATCH v2] Fix build failure in examples/standalone

[Paulraj, Sandeep]

> >
> > Some versions of 'make' do not handle trailing white-spaces
> > properly. Trailing spaces in ELF causes a 'fake' source to
> > be added to the variable COBJS; leading to build failure
> > (listed below). The problem was found with GNU Make 3.80.
> >
> > Using text-function 'strip' as a workaround for the problem.
> >
> > make[1]: Entering directory `/home/sanjeev/u-boot/examples/standalone'
> > arm-none-linux-gnueabi-gcc -g  -Os   -fno-common -ffixed-r8
> > -msoft-float
> > -D__KERNEL__ -DTEXT_BASE=0x80e80000 -I/home/sanjeev/u-boot/include
> > -fno-builtin -ffreestanding -nostdinc -isystem
> > /opt/codesourcery/2009q1-
> > 203/bin/../lib/gcc/arm-none-linux-gnueabi/4.3.3/include -pipe
> >  -DCONFIG_
> > ARM -D__ARM__ -marm  -mabi=aapcs-linux -mno-thumb-interwork
> > -march=armv5
> > -Wall -Wstrict-prototypes -fno-stack-protector -g  -Os
> > -fno-common -ff
> > ixed-r8 -msoft-float   -D__KERNEL__ -DTEXT_BASE=0x80e80000
> > -I/home/sanje
> > ev/u-boot/include -fno-builtin -ffreestanding -nostdinc
> > -isystem /opt/co
> > desourcery/2009q1-203/bin/../lib/gcc/arm-none-linux-gnueabi/4.
> > 3.3/includ
> > e -pipe  -DCONFIG_ARM -D__ARM__ -marm  -mabi=aapcs-linux
> > -mno-thumb-inte
> > rwork -march=armv5 -I.. -Bstatic -T u-boot.lds  -Ttext
> > 0x80e80000 -o .c
> > arm-none-linux-gnueabi-gcc: no input files
> > make[1]: *** [.c] Error 1
> > make[1]: Leaving directory `/home/sanjeev/u-boot/examples/standalone'
> > make: *** [examples/standalone] Error 2
> > premi #
> >
> > Signed-off-by: Sanjeev Premi <premi@ti.com>
> > ---
> >  examples/standalone/Makefile |    8 +++++++-
> >  1 files changed, 7 insertions(+), 1 deletions(-)
> >
> > diff --git a/examples/standalone/Makefile
> > b/examples/standalone/Makefile
> > index 5e2f2bc..c02ce43 100644
> > --- a/examples/standalone/Makefile
> > +++ b/examples/standalone/Makefile
> > @@ -38,7 +38,13 @@ ELF-mpc8260                      +=
> > mem_to_mem_idma2intr
> >  ELF-ppc                          += sched
> >  ELF-oxc                          += eepro100_eeprom
> >
> > -ELF := $(ELF-y) $(ELF-$(ARCH)) $(ELF-$(BOARD)) $(ELF-$(CPU))
> > +#
> > +# Some versions of make do not handle trailing white spaces properly;
> > +# leading to build failures. The problem was found with GNU
> > Make 3.80.
> > +# Using 'strip' as a workaround for the problem.
> > +#
> > +ElF := $(strip $(ELF-y) $(ELF-$(ARCH)) $(ELF-$(BOARD)) $(ELF-$(CPU)))
> > +
> >  SREC = $(addsuffix .srec,$(ELF))
> >  BIN  = $(addsuffix .bin,$(ELF))
> >
> > --
> > 1.6.2.2
> >
> >
> 
> Hi,
> 
> Just wanted to check if this update is okay?
> 
> Best regards,
> Sanjeev

If this is OK with everybody I'd like to push this to u-boot-ti.

Sandeep

[U-Boot] [PATCH v2] Fix build failure in examples/standalone

[Wolfgang Denk]

Dear "Paulraj, Sandeep",

In message <0554BEF07D437848AF01B9C9B5F0BC5D942DC9D9@dlee01.ent.ti.com> you wrote:
> 
> > > +ElF := $(strip $(ELF-y) $(ELF-$(ARCH)) $(ELF-$(BOARD)) $(ELF-$(CPU)))
------^^^^

> If this is OK with everybody I'd like to push this to u-boot-ti.

The patch is NOT ok, there is a typo in it ("ElF" != "ELF").

I intend to pull this (fixed) into the master branch ASAP, so you
don;t need to become active (actually you are not supposed to become
active as this is in no way any TI specific code).  Thanks.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
What is mind?  No matter.  What is matter?  Never mind.
                                      -- Thomas Hewitt Key, 1799-1875

[U-Boot] [PATCH v2] Fix build failure in examples/standalone

[Mike Frysinger]

On Monday 16 November 2009 11:04:30 Premi, Sanjeev wrote:
> From: Premi, Sanjeev
> > +ElF := $(strip $(ELF-y) $(ELF-$(ARCH)) $(ELF-$(BOARD)) $(ELF-$(CPU)))
> 
> Just wanted to check if this update is okay?

i'm guessing you missed peter's e-mail pointing out bugs in this change
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
Url : http://lists.denx.de/pipermail/u-boot/attachments/20091123/f0765530/attachment.pgp 

[U-Boot] [PATCH v2] Fix build failure in examples/standalone

[Wolfgang Denk]

Dear Sanjeev Premi,

In message <1257786780-9618-1-git-send-email-premi@ti.com> you wrote:
> Some versions of 'make' do not handle trailing white-spaces
> properly. Trailing spaces in ELF causes a 'fake' source to
> be added to the variable COBJS; leading to build failure
> (listed below). The problem was found with GNU Make 3.80.
> 
> Using text-function 'strip' as a workaround for the problem.
> 
> make[1]: Entering directory `/home/sanjeev/u-boot/examples/standalone'
> arm-none-linux-gnueabi-gcc -g  -Os   -fno-common -ffixed-r8 -msoft-float
> -D__KERNEL__ -DTEXT_BASE=0x80e80000 -I/home/sanjeev/u-boot/include
> -fno-builtin -ffreestanding -nostdinc -isystem /opt/codesourcery/2009q1-
> 203/bin/../lib/gcc/arm-none-linux-gnueabi/4.3.3/include -pipe  -DCONFIG_
> ARM -D__ARM__ -marm  -mabi=aapcs-linux -mno-thumb-interwork -march=armv5
> -Wall -Wstrict-prototypes -fno-stack-protector -g  -Os   -fno-common -ff
> ixed-r8 -msoft-float   -D__KERNEL__ -DTEXT_BASE=0x80e80000 -I/home/sanje
> ev/u-boot/include -fno-builtin -ffreestanding -nostdinc -isystem /opt/co
> desourcery/2009q1-203/bin/../lib/gcc/arm-none-linux-gnueabi/4.3.3/includ
> e -pipe  -DCONFIG_ARM -D__ARM__ -marm  -mabi=aapcs-linux -mno-thumb-inte
> rwork -march=armv5 -I.. -Bstatic -T u-boot.lds  -Ttext 0x80e80000 -o .c
> arm-none-linux-gnueabi-gcc: no input files
> make[1]: *** [.c] Error 1
> make[1]: Leaving directory `/home/sanjeev/u-boot/examples/standalone'
> make: *** [examples/standalone] Error 2
> premi #
> 
> Signed-off-by: Sanjeev Premi <premi@ti.com>
> ---
>  examples/standalone/Makefile |    8 +++++++-
>  1 files changed, 7 insertions(+), 1 deletions(-)

Applied...

> -ELF := $(ELF-y) $(ELF-$(ARCH)) $(ELF-$(BOARD)) $(ELF-$(CPU))
...
> +ElF := $(strip $(ELF-y) $(ELF-$(ARCH)) $(ELF-$(BOARD)) $(ELF-$(CPU)))

... after fixing the ELF => ElF typo.  Thanks.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
The only person who always got his work done by Friday
                                                 was Robinson Crusoe.

[U-Boot] [PATCH v2] Fix build failure in examples/standalone

[Premi, Sanjeev]

> -----Original Message-----
> From: Peter Tyser [mailto:ptyser at xes-inc.com] 
> Sent: Monday, November 09, 2009 10:58 PM
> To: Premi, Sanjeev
> Cc: u-boot at lists.denx.de
> Subject: Re: [U-Boot] [PATCH v2] Fix build failure in 
> examples/standalone
> 
> Hi Sanjeev,
> 
> <snip>
> 
> >  
> > -ELF := $(ELF-y) $(ELF-$(ARCH)) $(ELF-$(BOARD)) $(ELF-$(CPU))
> > +#
> > +# Some versions of make do not handle trailing white 
> spaces properly;
> > +# leading to build failures. The problem was found with 
> GNU Make 3.80.
> > +# Using 'strip' as a workaround for the problem.
> > +#
> > +ElF := $(strip $(ELF-y) $(ELF-$(ARCH)) $(ELF-$(BOARD)) 
> $(ELF-$(CPU)))
> > +
> 
> I haven't been following the thread, but am assuming the the
> capitalization of "ElF" above is a typo?

Sorry, Got back to regular activity much late than expected.
Yes. This is a typo; will fix it.

> 
> Best,
> Peter
> 
> 
> 

[U-Boot] [PATCH v2] Fix build failure in examples/standalone

[Premi, Sanjeev]

> -----Original Message-----
> From: u-boot-bounces at lists.denx.de 
> [mailto:u-boot-bounces at lists.denx.de] On Behalf Of Premi, Sanjeev
> Sent: Thursday, December 03, 2009 5:15 PM
> To: Peter Tyser
> Cc: u-boot at lists.denx.de
> Subject: Re: [U-Boot] [PATCH v2] Fix build failure in 
> examples/standalone
> 
> > -----Original Message-----
> > From: Peter Tyser [mailto:ptyser at xes-inc.com] 
> > Sent: Monday, November 09, 2009 10:58 PM
> > To: Premi, Sanjeev
> > Cc: u-boot at lists.denx.de
> > Subject: Re: [U-Boot] [PATCH v2] Fix build failure in 
> > examples/standalone
> > 
> > Hi Sanjeev,
> > 
> > <snip>
> > 
> > >  
> > > -ELF := $(ELF-y) $(ELF-$(ARCH)) $(ELF-$(BOARD)) $(ELF-$(CPU))
> > > +#
> > > +# Some versions of make do not handle trailing white 
> > spaces properly;
> > > +# leading to build failures. The problem was found with 
> > GNU Make 3.80.
> > > +# Using 'strip' as a workaround for the problem.
> > > +#
> > > +ElF := $(strip $(ELF-y) $(ELF-$(ARCH)) $(ELF-$(BOARD)) 
> > $(ELF-$(CPU)))
> > > +
> > 
> > I haven't been following the thread, but am assuming the the
> > capitalization of "ElF" above is a typo?
> 
> Sorry, Got back to regular activity much late than expected.
> Yes. This is a typo; will fix it.
> 

Just noticed that patch has already been committed with the fix.
Thanks Wolfgang.

Best regards,
Sanjeev

> > 
> > Best,
> > Peter
> > 
> > 
> > 
> _______________________________________________
> U-Boot mailing list
> U-Boot at lists.denx.de
> http://lists.denx.de/mailman/listinfo/u-boot
>