[PATCH] sparse: Add more ignored attributes

[PATCH] sparse: Add more ignored attributes

[Michael Buesch]

This adds more ignored gcc-style attributes.

externally_visible is a standard gcc attribute.
signal is an AVR8 attribute used to define interrupt service routines.

Ignore these attributes, as they are currently not useful for sparse checking.

Signed-off-by: Michael Buesch <mb@bu3sch.de>

---

Index: sparse/parse.c
===================================================================
--- sparse.orig/parse.c	2009-11-24 23:44:37.000000000 +0100
+++ sparse/parse.c	2009-11-25 14:21:39.000000000 +0100
@@ -541,6 +541,10 @@ static struct init_keyword {
 	{ "__warning__",	NS_KEYWORD,	.op = &ignore_attr_op },
 	{ "bounded",	NS_KEYWORD,	.op = &ignore_attr_op },
 	{ "__bounded__",	NS_KEYWORD,	.op = &ignore_attr_op },
+	{ "externally_visible",	NS_KEYWORD,	.op = &ignore_attr_op },
+	{ "__externally_visible__",	NS_KEYWORD,	.op = &ignore_attr_op },
+	{ "signal",	NS_KEYWORD,	.op = &ignore_attr_op },
+	{ "__signal__",	NS_KEYWORD,	.op = &ignore_attr_op },
 };
 
 void init_parser(int stream)

-- 
Greetings, Michael.

Re: [PATCH] sparse: Add more ignored attributes

[Christopher Li]

On Wed, Nov 25, 2009 at 5:29 AM, Michael Buesch <mb@bu3sch.de> wrote:
> +       { "externally_visible", NS_KEYWORD,     .op = &ignore_attr_op },
> +       { "__externally_visible__",     NS_KEYWORD,     .op = &ignore_attr_op },
> +       { "signal",     NS_KEYWORD,     .op = &ignore_attr_op },
> +       { "__signal__", NS_KEYWORD,     .op = &ignore_attr_op },

Can you update your patch base on the chrisl branch?
git://git.kernel.org/pub/scm/devel/sparse/chrisl/sparse.git

In the new code you just need to add the attribute name to ignored_attributes
array.

Thanks

Chris
--
To unsubscribe from this list: send the line "unsubscribe linux-sparse" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] sparse: Add more ignored attributes

[Christopher Li]

On Thu, Nov 26, 2009 at 3:03 AM, Michael Buesch <mb@bu3sch.de> wrote:
> This adds more ignored gcc-style attributes.
>
Applied with slightly modified title.

Thanks!

Chris

[PATCH] sparse: Add more ignored attributes

[Michael Buesch]

This adds more ignored gcc-style attributes.

externally_visible is a standard gcc attribute.
signal is an AVR8 attribute used to define interrupt service routines.

Ignore these attributes, as they are currently not useful for sparse checking.

Signed-off-by: Michael Buesch <mb@bu3sch.de>

---

Index: sparse-dev/parse.c
===================================================================
--- sparse-dev.orig/parse.c	2009-11-26 12:02:13.000000000 +0100
+++ sparse-dev/parse.c	2009-11-26 12:02:18.000000000 +0100
@@ -505,6 +505,8 @@ const char *ignored_attributes[] = {
 	"__dllexport__",
 	"dllimport",
 	"__dllimport__",
+	"externally_visible",
+	"__externally_visible__",
 	"fastcall",
 	"__fastcall__",
 	"format",
@@ -537,6 +539,8 @@ const char *ignored_attributes[] = {
 	"__section__",
 	"sentinel",
 	"__sentinel__",
+	"signal",
+	"__signal__",
 	"stdcall",
 	"__stdcall__",
 	"syscall_linkage",


-- 
Greetings, Michael.