All of lore.kernel.org
 help / color / mirror / Atom feed
From: Alessandro Zummo <a.zummo@towertech.it>
To: rtc-linux@googlegroups.com
Cc: specter118@gmail.com, Wan ZongShun <mcuos.com@gmail.com>,
	linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
	linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [rtc-linux] Re: [PATCH V3] ARM: NUC900: add RTC driver support for  nuc910 and nuc920
Date: Wed, 25 Nov 2009 14:36:34 +0100	[thread overview]
Message-ID: <20091125143634.1b8e0839@linux.lan.towertech.it> (raw)
In-Reply-To: <713d0d430911250451x51e0196bwdcbe5e8f087c3f8c@mail.gmail.com>

On Wed, 25 Nov 2009 20:51:24 +0800
Hu Ruihuan <specter118@gmail.com> wrote:

> I think you should lock irq before the serial read and write to the
> REG_RTC_RIER register.

 the lock seems not used anymore. the rtc framework has some locking
 of his own, driver authors are suggested to check if it's enough.

-- 

 Best regards,

 Alessandro Zummo,
  Tower Technologies - Torino, Italy

  http://www.towertech.it


WARNING: multiple messages have this Message-ID (diff)
From: a.zummo@towertech.it (Alessandro Zummo)
To: linux-arm-kernel@lists.infradead.org
Subject: [rtc-linux] Re: [PATCH V3] ARM: NUC900: add RTC driver support for  nuc910 and nuc920
Date: Wed, 25 Nov 2009 14:36:34 +0100	[thread overview]
Message-ID: <20091125143634.1b8e0839@linux.lan.towertech.it> (raw)
In-Reply-To: <713d0d430911250451x51e0196bwdcbe5e8f087c3f8c@mail.gmail.com>

On Wed, 25 Nov 2009 20:51:24 +0800
Hu Ruihuan <specter118@gmail.com> wrote:

> I think you should lock irq before the serial read and write to the
> REG_RTC_RIER register.

 the lock seems not used anymore. the rtc framework has some locking
 of his own, driver authors are suggested to check if it's enough.

-- 

 Best regards,

 Alessandro Zummo,
  Tower Technologies - Torino, Italy

  http://www.towertech.it

  reply	other threads:[~2009-11-25 13:36 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-11-25 12:15 [PATCH V3] ARM: NUC900: add RTC driver support for nuc910 and nuc920 Wan ZongShun
2009-11-25 12:15 ` Wan ZongShun
2009-11-25 12:51 ` Hu Ruihuan
2009-11-25 12:51   ` Hu Ruihuan
2009-11-25 13:36   ` Alessandro Zummo [this message]
2009-11-25 13:36     ` [rtc-linux] " Alessandro Zummo
2009-11-25 13:38 ` Alessandro Zummo
2009-11-25 13:38   ` Alessandro Zummo
2009-11-26  3:11   ` Wan ZongShun
2009-11-26  3:11     ` Wan ZongShun

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20091125143634.1b8e0839@linux.lan.towertech.it \
    --to=a.zummo@towertech.it \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mcuos.com@gmail.com \
    --cc=rtc-linux@googlegroups.com \
    --cc=specter118@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.