[patch] drop chan->wsem on error path

[patch] drop chan->wsem on error path

[Dan Carpenter]

The other paths all drop chan->wsem.  This was found by a static
checker (smatch).

Signed-off-by: Dan Carpenter <error27@gmail.com>

--- orig/drivers/net/wan/cosa.c	2009-11-29 16:38:42.000000000 +0200
+++ devel/drivers/net/wan/cosa.c	2009-11-29 16:43:39.000000000 +0200
@@ -907,6 +907,7 @@ static ssize_t cosa_write(struct file *f
 			current->state = TASK_RUNNING;
 			chan->tx_status = 1;
 			spin_unlock_irqrestore(&cosa->lock, flags);
+			up(&chan->wsem);
 			return -ERESTARTSYS;
 		}
 	}

Re: [patch] drop chan->wsem on error path

[Jan Kasprzak]

Dan Carpenter wrote:
: The other paths all drop chan->wsem.  This was found by a static
: checker (smatch).

	You are right, thanks!

: 
: Signed-off-by: Dan Carpenter <error27@gmail.com>

Acked-by: Jan "Yenya" Kasprzak <kas@fi.muni.cz>

: --- orig/drivers/net/wan/cosa.c	2009-11-29 16:38:42.000000000 +0200
: +++ devel/drivers/net/wan/cosa.c	2009-11-29 16:43:39.000000000 +0200
: @@ -907,6 +907,7 @@ static ssize_t cosa_write(struct file *f
:  			current->state = TASK_RUNNING;
:  			chan->tx_status = 1;
:  			spin_unlock_irqrestore(&cosa->lock, flags);
: +			up(&chan->wsem);
:  			return -ERESTARTSYS;
:  		}
:  	}

-- 
| Jan "Yenya" Kasprzak  <kas at {fi.muni.cz - work | yenya.net - private}> |
| GPG: ID 1024/D3498839      Fingerprint 0D99A7FB206605D7 8B35FCDE05B18A5E |
| http://www.fi.muni.cz/~kas/    Journal: http://www.fi.muni.cz/~kas/blog/ |
Please don't top post and in particular don't attach entire digests to your
mail or we'll all soon be using bittorrent to read the list.     --Alan Cox

Re: [patch] drop chan->wsem on error path

[David Miller]

From: Jan Kasprzak <kas@fi.muni.cz>
Date: Mon, 30 Nov 2009 08:44:18 +0100

> Dan Carpenter wrote:
> : The other paths all drop chan->wsem.  This was found by a static
> : checker (smatch).
> 
> 	You are right, thanks!
> 
> : 
> : Signed-off-by: Dan Carpenter <error27@gmail.com>
> 
> Acked-by: Jan "Yenya" Kasprzak <kas@fi.muni.cz>

Patch applied, thanks everyone.