linux-next: pxa tree build failure

linux-next: pxa tree build failure

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 507 bytes --]

Hi Eric,

Today's linux-next build (powerpc allyesconfig) failed like this:

drivers/video/backlight/da903x_bl.c: In function 'da903x_backlight_probe':
drivers/video/backlight/da903x_bl.c:134: error: 'dev' undeclared (first use in this function)

Caused by commit ed084c0f6b7e003194276d74ef9087b78c180409 ("da903x_bl:
control WLED output current in da9034") which I have reverted for today.
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 198 bytes --]

RE: linux-next: pxa tree build failure

[Haojian Zhuang]

[-- Attachment #1: Type: text/plain, Size: 894 bytes --]

Hi Stephen,

Great thanks on your test. Now I format the patch.

Eric,
Please help to review and merge it.

Thanks
Haojian

-----Original Message-----
From: Stephen Rothwell [mailto:sfr@canb.auug.org.au] 
Sent: 2009年11月30日 2:22 PM
To: Eric Miao
Cc: linux-next@vger.kernel.org; linux-kernel@vger.kernel.org; Haojian Zhuang
Subject: linux-next: pxa tree build failure

Hi Eric,

Today's linux-next build (powerpc allyesconfig) failed like this:

drivers/video/backlight/da903x_bl.c: In function 'da903x_backlight_probe':
drivers/video/backlight/da903x_bl.c:134: error: 'dev' undeclared (first use in this function)

Caused by commit ed084c0f6b7e003194276d74ef9087b78c180409 ("da903x_bl:
control WLED output current in da9034") which I have reverted for today.
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: 0001-backlight-fix-device-structure-in-da9034.patch --]
[-- Type: application/octet-stream, Size: 1109 bytes --]

From bf744dcc76a98cb7954b1bce23b4410615ff9272 Mon Sep 17 00:00:00 2001
From: Haojian Zhuang <haojian.zhuang@marvell.com>
Date: Mon, 30 Nov 2009 12:03:22 -0500
Subject: [PATCH] backlight: fix device structure in da9034

Original API is used in update_status, dev structure is used as parameter.
After the API is invoked in probe function, we should use correct structure
as parameter.

Signed-off-by: Haojian Zhuang <haojian.zhuang@marvell.com>
---
 drivers/video/backlight/da903x_bl.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/video/backlight/da903x_bl.c b/drivers/video/backlight/da903x_bl.c
index 9cbd01d..7fcb0eb 100644
--- a/drivers/video/backlight/da903x_bl.c
+++ b/drivers/video/backlight/da903x_bl.c
@@ -131,7 +131,7 @@ static int da903x_backlight_probe(struct platform_device *pdev)
 
 	/* adjust the WLED output current */
 	if (pdata)
-		da903x_write(dev, DA9034_WLED_CONTROL2,
+		da903x_write(data->da903x_dev, DA9034_WLED_CONTROL2,
 				DA9034_WLED_ISET(pdata->output_current));
 
 	bl = backlight_device_register(pdev->name, data->da903x_dev,
-- 
1.5.6.5

Re: linux-next: pxa tree build failure

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 506 bytes --]

Hi Eric,

On Thu, 28 May 2009 10:36:19 +0800 Eric Miao <eric.y.miao@gmail.com> wrote:
>
> Yeah, that depends on the mach-types being updated, and we are
> still discussing about that. I'll temporarily move that commit off the
> branch, and put it back once ready.

Thanks for that.  For today, I have used the pxa tree from next-20090526
instead.  I will pick up your new tree tomorrow.

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 197 bytes --]

Re: linux-next: pxa tree build failure

[Eric Miao]

On Thu, May 28, 2009 at 12:54 AM, Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> Hi Eric,
>
> Today's linux-next build (most of the arm configs) failed like this:
>
> arch/arm/mm/mmu.c:839: error: implicit declaration of function 'machine_is_treo680'
>
> Caused by commit c81fe1207795c71a6933f84d62ded0946a6af8a4 ("[ARM]
> pxa/treo680: initial support").
>

Yeah, that depends on the mach-types being updated, and we are
still discussing about that. I'll temporarily move that commit off the
branch, and put it back once ready.

linux-next: pxa tree build failure

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 380 bytes --]

Hi Eric,

Today's linux-next build (most of the arm configs) failed like this:

arch/arm/mm/mmu.c:839: error: implicit declaration of function 'machine_is_treo680'

Caused by commit c81fe1207795c71a6933f84d62ded0946a6af8a4 ("[ARM]
pxa/treo680: initial support").

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 197 bytes --]

linux-next: pxa tree build failure

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 792 bytes --]

Hi Eric,

Today's linux-next build (x86_64 allmodconfig) failed like this:

drivers/video/backlight/corgi_lcd.c:27:36: error: asm/mach/sharpsl_param.h: No such file or directory
drivers/video/backlight/corgi_lcd.c: In function 'lcdtg_set_phadadj':
drivers/video/backlight/corgi_lcd.c:197: error: 'sharpsl_param' undeclared (first use in this function)
drivers/video/backlight/corgi_lcd.c: In function 'corgi_lcd_power_on':
drivers/video/backlight/corgi_lcd.c:244: error: 'sharpsl_param' undeclared (first use in this function)

This driver is added in the pxa tree.  I suspect it needs to depend on
ARM or some such, but for now I have made it depend on BROKEN in Kconfig.
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 197 bytes --]