All of lore.kernel.org
 help / color / mirror / Atom feed
* [patch] memory leak dm-exception-store.c
@ 2009-11-28 10:31 Dan Carpenter
  2009-12-04  3:30 ` Alasdair G Kergon
  0 siblings, 1 reply; 2+ messages in thread
From: Dan Carpenter @ 2009-11-28 10:31 UTC (permalink / raw)
  To: dm-devel


Without this change we would leak tmp_store.

Signed-off-by: Dan Carpenter <error27@gmail.com>

--- orig/drivers/md/dm-exception-store.c	2009-11-28 07:17:35.000000000 +0200
+++ devel/drivers/md/dm-exception-store.c	2009-11-28 07:23:04.000000000 +0200
@@ -216,7 +216,8 @@ int dm_exception_store_create(struct dm_
 		type = get_type("N");
 	else {
 		ti->error = "Persistent flag is not P or N";
-		return -EINVAL;
+		r = -EINVAL;
+		goto bad_type;
 	}
 
 	if (!type) {

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [patch] memory leak dm-exception-store.c
  2009-11-28 10:31 [patch] memory leak dm-exception-store.c Dan Carpenter
@ 2009-12-04  3:30 ` Alasdair G Kergon
  0 siblings, 0 replies; 2+ messages in thread
From: Alasdair G Kergon @ 2009-12-04  3:30 UTC (permalink / raw)
  To: Dan Carpenter; +Cc: dm-devel

On Sat, Nov 28, 2009 at 12:31:13PM +0200, Dan Carpenter wrote:
> Without this change we would leak tmp_store.

Already fixed in linux-next.
  http://patchwork.kernel.org/patch/38657/

Alasdair

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2009-12-04  3:30 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2009-11-28 10:31 [patch] memory leak dm-exception-store.c Dan Carpenter
2009-12-04  3:30 ` Alasdair G Kergon

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.