All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] FS-Cache: Avoid maybe-used-uninitialised warning on variable
@ 2009-12-06 12:58 David Howells
  0 siblings, 0 replies; only message in thread
From: David Howells @ 2009-12-06 12:58 UTC (permalink / raw)
  To: akpm; +Cc: dhowells, linux-cachefs, linux-kernel

Andrew Morton's compiler sees the following warning in FS-Cache:

fs/fscache/object-list.c: In function 'fscache_objlist_lookup':
fs/fscache/object-list.c:94: warning: 'obj' may be used uninitialized in this function

which my compiler doesn't.  This is a false positive as obj can only be used
in the comparison against minobj if minobj has been set to something other
than NULL, but for that to happen, obj has to be first set to something.

Deal with this by preclearing obj too.

Reported-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: David Howells <dhowells@redhat.com>
---

 fs/fscache/object-list.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/fs/fscache/object-list.c b/fs/fscache/object-list.c
index e590242..3221a0c 100644
--- a/fs/fscache/object-list.c
+++ b/fs/fscache/object-list.c
@@ -91,7 +91,7 @@ EXPORT_SYMBOL(fscache_object_destroy);
  */
 static struct fscache_object *fscache_objlist_lookup(loff_t *_pos)
 {
-	struct fscache_object *pobj, *obj, *minobj = NULL;
+	struct fscache_object *pobj, *obj = NULL, *minobj = NULL;
 	struct rb_node *p;
 	unsigned long pos;
 


^ permalink raw reply related	[flat|nested] only message in thread

only message in thread, other threads:[~2009-12-06 12:58 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2009-12-06 12:58 [PATCH] FS-Cache: Avoid maybe-used-uninitialised warning on variable David Howells

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.