* [PATCH] OMAP3: PM: Enable wake-up from McBSP2, 3 and 4 modules
@ 2009-11-26 13:18 Peter Ujfalusi
2009-12-07 13:38 ` Peter Ujfalusi
2009-12-09 23:38 ` Kevin Hilman
0 siblings, 2 replies; 7+ messages in thread
From: Peter Ujfalusi @ 2009-11-26 13:18 UTC (permalink / raw)
To: linux-omap; +Cc: khilman, tony
Wake-up from McBSP ports are needed, especially when the THRESHOLD
dma mode is in use for audio playback.
Signed-off-by: Peter Ujfalusi <peter.ujfalusi@nokia.com>
---
arch/arm/mach-omap2/pm34xx.c | 8 ++++++--
1 files changed, 6 insertions(+), 2 deletions(-)
diff --git a/arch/arm/mach-omap2/pm34xx.c b/arch/arm/mach-omap2/pm34xx.c
index 81ed252..6b17647 100644
--- a/arch/arm/mach-omap2/pm34xx.c
+++ b/arch/arm/mach-omap2/pm34xx.c
@@ -878,12 +878,16 @@ static void __init prcm_setup_regs(void)
/* Enable wakeups in PER */
prm_write_mod_reg(OMAP3430_EN_GPIO2 | OMAP3430_EN_GPIO3 |
OMAP3430_EN_GPIO4 | OMAP3430_EN_GPIO5 |
- OMAP3430_EN_GPIO6 | OMAP3430_EN_UART3,
+ OMAP3430_EN_GPIO6 | OMAP3430_EN_UART3 |
+ OMAP3430_EN_MCBSP2 | OMAP3430_EN_MCBSP3 |
+ OMAP3430_EN_MCBSP4,
OMAP3430_PER_MOD, PM_WKEN);
/* and allow them to wake up MPU */
prm_write_mod_reg(OMAP3430_GRPSEL_GPIO2 | OMAP3430_EN_GPIO3 |
OMAP3430_GRPSEL_GPIO4 | OMAP3430_EN_GPIO5 |
- OMAP3430_GRPSEL_GPIO6 | OMAP3430_EN_UART3,
+ OMAP3430_GRPSEL_GPIO6 | OMAP3430_EN_UART3 |
+ OMAP3430_EN_MCBSP2 | OMAP3430_EN_MCBSP3 |
+ OMAP3430_EN_MCBSP4,
OMAP3430_PER_MOD, OMAP3430_PM_MPUGRPSEL);
/* Don't attach IVA interrupts */
--
1.6.5.3
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH] OMAP3: PM: Enable wake-up from McBSP2, 3 and 4 modules
2009-11-26 13:18 [PATCH] OMAP3: PM: Enable wake-up from McBSP2, 3 and 4 modules Peter Ujfalusi
@ 2009-12-07 13:38 ` Peter Ujfalusi
2009-12-07 21:34 ` Tony Lindgren
2009-12-09 23:38 ` Kevin Hilman
1 sibling, 1 reply; 7+ messages in thread
From: Peter Ujfalusi @ 2009-12-07 13:38 UTC (permalink / raw)
To: linux-omap; +Cc: khilman, tony
Hello Tony, Kevin,
On Thursday 26 November 2009 15:18:50 Ujfalusi Peter (Nokia-D/Tampere) wrote:
> Wake-up from McBSP ports are needed, especially when the THRESHOLD
> dma mode is in use for audio playback.
>
> Signed-off-by: Peter Ujfalusi <peter.ujfalusi@nokia.com>
> ---
> arch/arm/mach-omap2/pm34xx.c | 8 ++++++--
> 1 files changed, 6 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/mach-omap2/pm34xx.c b/arch/arm/mach-omap2/pm34xx.c
> index 81ed252..6b17647 100644
> --- a/arch/arm/mach-omap2/pm34xx.c
> +++ b/arch/arm/mach-omap2/pm34xx.c
> @@ -878,12 +878,16 @@ static void __init prcm_setup_regs(void)
> /* Enable wakeups in PER */
> prm_write_mod_reg(OMAP3430_EN_GPIO2 | OMAP3430_EN_GPIO3 |
> OMAP3430_EN_GPIO4 | OMAP3430_EN_GPIO5 |
> - OMAP3430_EN_GPIO6 | OMAP3430_EN_UART3,
> + OMAP3430_EN_GPIO6 | OMAP3430_EN_UART3 |
> + OMAP3430_EN_MCBSP2 | OMAP3430_EN_MCBSP3 |
> + OMAP3430_EN_MCBSP4,
> OMAP3430_PER_MOD, PM_WKEN);
> /* and allow them to wake up MPU */
> prm_write_mod_reg(OMAP3430_GRPSEL_GPIO2 | OMAP3430_EN_GPIO3 |
> OMAP3430_GRPSEL_GPIO4 | OMAP3430_EN_GPIO5 |
> - OMAP3430_GRPSEL_GPIO6 | OMAP3430_EN_UART3,
> + OMAP3430_GRPSEL_GPIO6 | OMAP3430_EN_UART3 |
> + OMAP3430_EN_MCBSP2 | OMAP3430_EN_MCBSP3 |
> + OMAP3430_EN_MCBSP4,
> OMAP3430_PER_MOD, OMAP3430_PM_MPUGRPSEL);
>
> /* Don't attach IVA interrupts */
>
Have you had time to take a look at this patch?
--
Péter
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] OMAP3: PM: Enable wake-up from McBSP2, 3 and 4 modules
2009-12-07 13:38 ` Peter Ujfalusi
@ 2009-12-07 21:34 ` Tony Lindgren
0 siblings, 0 replies; 7+ messages in thread
From: Tony Lindgren @ 2009-12-07 21:34 UTC (permalink / raw)
To: Peter Ujfalusi; +Cc: linux-omap, khilman
* Peter Ujfalusi <peter.ujfalusi@nokia.com> [091207 05:37]:
> Hello Tony, Kevin,
>
> On Thursday 26 November 2009 15:18:50 Ujfalusi Peter (Nokia-D/Tampere) wrote:
> > Wake-up from McBSP ports are needed, especially when the THRESHOLD
> > dma mode is in use for audio playback.
> >
> > Signed-off-by: Peter Ujfalusi <peter.ujfalusi@nokia.com>
> > ---
> > arch/arm/mach-omap2/pm34xx.c | 8 ++++++--
> > 1 files changed, 6 insertions(+), 2 deletions(-)
> >
> > diff --git a/arch/arm/mach-omap2/pm34xx.c b/arch/arm/mach-omap2/pm34xx.c
> > index 81ed252..6b17647 100644
> > --- a/arch/arm/mach-omap2/pm34xx.c
> > +++ b/arch/arm/mach-omap2/pm34xx.c
> > @@ -878,12 +878,16 @@ static void __init prcm_setup_regs(void)
> > /* Enable wakeups in PER */
> > prm_write_mod_reg(OMAP3430_EN_GPIO2 | OMAP3430_EN_GPIO3 |
> > OMAP3430_EN_GPIO4 | OMAP3430_EN_GPIO5 |
> > - OMAP3430_EN_GPIO6 | OMAP3430_EN_UART3,
> > + OMAP3430_EN_GPIO6 | OMAP3430_EN_UART3 |
> > + OMAP3430_EN_MCBSP2 | OMAP3430_EN_MCBSP3 |
> > + OMAP3430_EN_MCBSP4,
> > OMAP3430_PER_MOD, PM_WKEN);
> > /* and allow them to wake up MPU */
> > prm_write_mod_reg(OMAP3430_GRPSEL_GPIO2 | OMAP3430_EN_GPIO3 |
> > OMAP3430_GRPSEL_GPIO4 | OMAP3430_EN_GPIO5 |
> > - OMAP3430_GRPSEL_GPIO6 | OMAP3430_EN_UART3,
> > + OMAP3430_GRPSEL_GPIO6 | OMAP3430_EN_UART3 |
> > + OMAP3430_EN_MCBSP2 | OMAP3430_EN_MCBSP3 |
> > + OMAP3430_EN_MCBSP4,
> > OMAP3430_PER_MOD, OMAP3430_PM_MPUGRPSEL);
> >
> > /* Don't attach IVA interrupts */
> >
>
> Have you had time to take a look at this patch?
Makes sense to me, let's let Kevin queue it up.
Tony
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] OMAP3: PM: Enable wake-up from McBSP2, 3 and 4 modules
2009-11-26 13:18 [PATCH] OMAP3: PM: Enable wake-up from McBSP2, 3 and 4 modules Peter Ujfalusi
2009-12-07 13:38 ` Peter Ujfalusi
@ 2009-12-09 23:38 ` Kevin Hilman
1 sibling, 0 replies; 7+ messages in thread
From: Kevin Hilman @ 2009-12-09 23:38 UTC (permalink / raw)
To: Peter Ujfalusi; +Cc: linux-omap, tony
Peter Ujfalusi <peter.ujfalusi@nokia.com> writes:
> Wake-up from McBSP ports are needed, especially when the THRESHOLD
> dma mode is in use for audio playback.
>
> Signed-off-by: Peter Ujfalusi <peter.ujfalusi@nokia.com>
Looks good, adding to PM branch and will queue in pm-fxies for
2.6.33-rc series.
Kevin
> ---
> arch/arm/mach-omap2/pm34xx.c | 8 ++++++--
> 1 files changed, 6 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/mach-omap2/pm34xx.c b/arch/arm/mach-omap2/pm34xx.c
> index 81ed252..6b17647 100644
> --- a/arch/arm/mach-omap2/pm34xx.c
> +++ b/arch/arm/mach-omap2/pm34xx.c
> @@ -878,12 +878,16 @@ static void __init prcm_setup_regs(void)
> /* Enable wakeups in PER */
> prm_write_mod_reg(OMAP3430_EN_GPIO2 | OMAP3430_EN_GPIO3 |
> OMAP3430_EN_GPIO4 | OMAP3430_EN_GPIO5 |
> - OMAP3430_EN_GPIO6 | OMAP3430_EN_UART3,
> + OMAP3430_EN_GPIO6 | OMAP3430_EN_UART3 |
> + OMAP3430_EN_MCBSP2 | OMAP3430_EN_MCBSP3 |
> + OMAP3430_EN_MCBSP4,
> OMAP3430_PER_MOD, PM_WKEN);
> /* and allow them to wake up MPU */
> prm_write_mod_reg(OMAP3430_GRPSEL_GPIO2 | OMAP3430_EN_GPIO3 |
> OMAP3430_GRPSEL_GPIO4 | OMAP3430_EN_GPIO5 |
> - OMAP3430_GRPSEL_GPIO6 | OMAP3430_EN_UART3,
> + OMAP3430_GRPSEL_GPIO6 | OMAP3430_EN_UART3 |
> + OMAP3430_EN_MCBSP2 | OMAP3430_EN_MCBSP3 |
> + OMAP3430_EN_MCBSP4,
> OMAP3430_PER_MOD, OMAP3430_PM_MPUGRPSEL);
>
> /* Don't attach IVA interrupts */
> --
> 1.6.5.3
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] OMAP3: PM: Enable wake-up from McBSP2, 3 and 4 modules
2010-03-03 13:08 ` [PATCH] OMAP3: PM: Enable wake-up from McBSP2, 3 and 4 modules Peter Ujfalusi
2010-03-03 14:08 ` Peter Ujfalusi
@ 2010-03-03 14:46 ` Jarkko Nikula
1 sibling, 0 replies; 7+ messages in thread
From: Jarkko Nikula @ 2010-03-03 14:46 UTC (permalink / raw)
To: Peter Ujfalusi
Cc: alsa-devel, tony, broonie, ext-eero.nurkkala, linux-omap, lrg
On Wed, 3 Mar 2010 15:08:05 +0200
Peter Ujfalusi <peter.ujfalusi@nokia.com> wrote:
> Wake-up from McBSP ports are needed, especially when the THRESHOLD
> dma mode is in use for audio playback.
>
> Signed-off-by: Peter Ujfalusi <peter.ujfalusi@nokia.com>
> ---
> arch/arm/mach-omap2/pm34xx.c | 8 ++++++--
> 1 files changed, 6 insertions(+), 2 deletions(-)
>
How about the commit e3d9329640e4b291cdd2c6d178774c28bba47d59 in
mainline?
--
Jarkko
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] OMAP3: PM: Enable wake-up from McBSP2, 3 and 4 modules
2010-03-03 13:08 ` [PATCH] OMAP3: PM: Enable wake-up from McBSP2, 3 and 4 modules Peter Ujfalusi
@ 2010-03-03 14:08 ` Peter Ujfalusi
2010-03-03 14:46 ` Jarkko Nikula
1 sibling, 0 replies; 7+ messages in thread
From: Peter Ujfalusi @ 2010-03-03 14:08 UTC (permalink / raw)
To: broonie
Cc: alsa-devel, tony, Nurkkala Eero.An (EXT-Offcode/Oulu), linux-omap, lrg
On Wednesday 03 March 2010 15:08:05 Ujfalusi Peter (Nokia-D/Tampere) wrote:
> Wake-up from McBSP ports are needed, especially when the THRESHOLD
> dma mode is in use for audio playback.
>
> Signed-off-by: Peter Ujfalusi <peter.ujfalusi@nokia.com>
Hmmm, please disregard this patch, I have forgot to clean up the directory.
This has been already taken for 2.6.33 kernel.
Only the [PATCHv2] prefix is valid for this series.
Sorry for the noise.
--
Péter
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH] OMAP3: PM: Enable wake-up from McBSP2, 3 and 4 modules
2010-03-03 13:08 [PATCHv2 0/5] FIFO caused playback delay (latency) handling in soc/omap Peter Ujfalusi
@ 2010-03-03 13:08 ` Peter Ujfalusi
2010-03-03 14:08 ` Peter Ujfalusi
2010-03-03 14:46 ` Jarkko Nikula
0 siblings, 2 replies; 7+ messages in thread
From: Peter Ujfalusi @ 2010-03-03 13:08 UTC (permalink / raw)
To: broonie, tony; +Cc: alsa-devel, linux-omap, lrg, jhnikula, ext-eero.nurkkala
Wake-up from McBSP ports are needed, especially when the THRESHOLD
dma mode is in use for audio playback.
Signed-off-by: Peter Ujfalusi <peter.ujfalusi@nokia.com>
---
arch/arm/mach-omap2/pm34xx.c | 8 ++++++--
1 files changed, 6 insertions(+), 2 deletions(-)
diff --git a/arch/arm/mach-omap2/pm34xx.c b/arch/arm/mach-omap2/pm34xx.c
index 81ed252..6b17647 100644
--- a/arch/arm/mach-omap2/pm34xx.c
+++ b/arch/arm/mach-omap2/pm34xx.c
@@ -878,12 +878,16 @@ static void __init prcm_setup_regs(void)
/* Enable wakeups in PER */
prm_write_mod_reg(OMAP3430_EN_GPIO2 | OMAP3430_EN_GPIO3 |
OMAP3430_EN_GPIO4 | OMAP3430_EN_GPIO5 |
- OMAP3430_EN_GPIO6 | OMAP3430_EN_UART3,
+ OMAP3430_EN_GPIO6 | OMAP3430_EN_UART3 |
+ OMAP3430_EN_MCBSP2 | OMAP3430_EN_MCBSP3 |
+ OMAP3430_EN_MCBSP4,
OMAP3430_PER_MOD, PM_WKEN);
/* and allow them to wake up MPU */
prm_write_mod_reg(OMAP3430_GRPSEL_GPIO2 | OMAP3430_EN_GPIO3 |
OMAP3430_GRPSEL_GPIO4 | OMAP3430_EN_GPIO5 |
- OMAP3430_GRPSEL_GPIO6 | OMAP3430_EN_UART3,
+ OMAP3430_GRPSEL_GPIO6 | OMAP3430_EN_UART3 |
+ OMAP3430_EN_MCBSP2 | OMAP3430_EN_MCBSP3 |
+ OMAP3430_EN_MCBSP4,
OMAP3430_PER_MOD, OMAP3430_PM_MPUGRPSEL);
/* Don't attach IVA interrupts */
--
1.6.5.3
^ permalink raw reply related [flat|nested] 7+ messages in thread
end of thread, other threads:[~2010-03-03 14:46 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2009-11-26 13:18 [PATCH] OMAP3: PM: Enable wake-up from McBSP2, 3 and 4 modules Peter Ujfalusi
2009-12-07 13:38 ` Peter Ujfalusi
2009-12-07 21:34 ` Tony Lindgren
2009-12-09 23:38 ` Kevin Hilman
2010-03-03 13:08 [PATCHv2 0/5] FIFO caused playback delay (latency) handling in soc/omap Peter Ujfalusi
2010-03-03 13:08 ` [PATCH] OMAP3: PM: Enable wake-up from McBSP2, 3 and 4 modules Peter Ujfalusi
2010-03-03 14:08 ` Peter Ujfalusi
2010-03-03 14:46 ` Jarkko Nikula
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.