All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] dt-bindings: mtd: jedec,spi-nor: remove unneeded properties
@ 2022-04-07 14:20 ` Krzysztof Kozlowski
  0 siblings, 0 replies; 8+ messages in thread
From: Krzysztof Kozlowski @ 2022-04-07 14:20 UTC (permalink / raw)
  To: Tudor Ambarus, Pratyush Yadav, Michael Walle, Miquel Raynal,
	Richard Weinberger, Vignesh Raghavendra, Rob Herring,
	Krzysztof Kozlowski, linux-mtd, devicetree, linux-kernel
  Cc: Krzysztof Kozlowski

After conversion the jedec,spi-nor DT schema to reference other schemas
(SPI and MTD) and use unevaluatedProperties, several properties are
redundant.

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
 .../devicetree/bindings/mtd/jedec,spi-nor.yaml        | 11 -----------
 1 file changed, 11 deletions(-)

diff --git a/Documentation/devicetree/bindings/mtd/jedec,spi-nor.yaml b/Documentation/devicetree/bindings/mtd/jedec,spi-nor.yaml
index 4abfb4cfc157..708e7f88fd92 100644
--- a/Documentation/devicetree/bindings/mtd/jedec,spi-nor.yaml
+++ b/Documentation/devicetree/bindings/mtd/jedec,spi-nor.yaml
@@ -50,10 +50,6 @@ properties:
     minItems: 1
     maxItems: 2
 
-  spi-max-frequency: true
-  spi-rx-bus-width: true
-  spi-tx-bus-width: true
-
   m25p,fast-read:
     type: boolean
     description:
@@ -74,14 +70,9 @@ properties:
       be used on such systems, to denote the absence of a reliable reset
       mechanism.
 
-  label: true
-
   partitions:
     type: object
 
-  '#address-cells': true
-  '#size-cells': true
-
 patternProperties:
   # Note: use 'partitions' node for new users
   '^partition@':
@@ -99,8 +90,6 @@ examples:
         #size-cells = <0>;
 
         flash@0 {
-            #address-cells = <1>;
-            #size-cells = <1>;
             compatible = "spansion,m25p80", "jedec,spi-nor";
             reg = <0>;
             spi-max-frequency = <40000000>;
-- 
2.32.0


^ permalink raw reply related	[flat|nested] 8+ messages in thread
* [PATCH] dt-bindings: mtd: jedec,spi-nor: remove unneeded properties
@ 2022-04-07 14:20 ` Krzysztof Kozlowski
  0 siblings, 0 replies; 8+ messages in thread
From: Krzysztof Kozlowski @ 2022-04-07 14:20 UTC (permalink / raw)
  To: Tudor Ambarus, Pratyush Yadav, Michael Walle, Miquel Raynal,
	Richard Weinberger, Vignesh Raghavendra, Rob Herring,
	Krzysztof Kozlowski, linux-mtd, devicetree, linux-kernel
  Cc: Krzysztof Kozlowski

After conversion the jedec,spi-nor DT schema to reference other schemas
(SPI and MTD) and use unevaluatedProperties, several properties are
redundant.

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
 .../devicetree/bindings/mtd/jedec,spi-nor.yaml        | 11 -----------
 1 file changed, 11 deletions(-)

diff --git a/Documentation/devicetree/bindings/mtd/jedec,spi-nor.yaml b/Documentation/devicetree/bindings/mtd/jedec,spi-nor.yaml
index 4abfb4cfc157..708e7f88fd92 100644
--- a/Documentation/devicetree/bindings/mtd/jedec,spi-nor.yaml
+++ b/Documentation/devicetree/bindings/mtd/jedec,spi-nor.yaml
@@ -50,10 +50,6 @@ properties:
     minItems: 1
     maxItems: 2
 
-  spi-max-frequency: true
-  spi-rx-bus-width: true
-  spi-tx-bus-width: true
-
   m25p,fast-read:
     type: boolean
     description:
@@ -74,14 +70,9 @@ properties:
       be used on such systems, to denote the absence of a reliable reset
       mechanism.
 
-  label: true
-
   partitions:
     type: object
 
-  '#address-cells': true
-  '#size-cells': true
-
 patternProperties:
   # Note: use 'partitions' node for new users
   '^partition@':
@@ -99,8 +90,6 @@ examples:
         #size-cells = <0>;
 
         flash@0 {
-            #address-cells = <1>;
-            #size-cells = <1>;
             compatible = "spansion,m25p80", "jedec,spi-nor";
             reg = <0>;
             spi-max-frequency = <40000000>;
-- 
2.32.0


______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/

^ permalink raw reply related	[flat|nested] 8+ messages in thread
* Re: [PATCH] dt-bindings: mtd: jedec,spi-nor: remove unneeded properties
  2022-04-07 14:20 ` Krzysztof Kozlowski
@ 2022-04-07 18:09   ` Pratyush Yadav
  -1 siblings, 0 replies; 8+ messages in thread
From: Pratyush Yadav @ 2022-04-07 18:09 UTC (permalink / raw)
  To: Krzysztof Kozlowski
  Cc: Tudor Ambarus, Michael Walle, Miquel Raynal, Richard Weinberger,
	Vignesh Raghavendra, Rob Herring, Krzysztof Kozlowski, linux-mtd,
	devicetree, linux-kernel

On 07/04/22 04:20PM, Krzysztof Kozlowski wrote:
> After conversion the jedec,spi-nor DT schema to reference other schemas
> (SPI and MTD) and use unevaluatedProperties, several properties are
> redundant.
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Reviewed-by: Pratyush Yadav <p.yadav@ti.com>

-- 
Regards,
Pratyush Yadav
Texas Instruments Inc.

^ permalink raw reply	[flat|nested] 8+ messages in thread
* Re: [PATCH] dt-bindings: mtd: jedec,spi-nor: remove unneeded properties
@ 2022-04-07 18:09   ` Pratyush Yadav
  0 siblings, 0 replies; 8+ messages in thread
From: Pratyush Yadav @ 2022-04-07 18:09 UTC (permalink / raw)
  To: Krzysztof Kozlowski
  Cc: Tudor Ambarus, Michael Walle, Miquel Raynal, Richard Weinberger,
	Vignesh Raghavendra, Rob Herring, Krzysztof Kozlowski, linux-mtd,
	devicetree, linux-kernel

On 07/04/22 04:20PM, Krzysztof Kozlowski wrote:
> After conversion the jedec,spi-nor DT schema to reference other schemas
> (SPI and MTD) and use unevaluatedProperties, several properties are
> redundant.
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Reviewed-by: Pratyush Yadav <p.yadav@ti.com>

-- 
Regards,
Pratyush Yadav
Texas Instruments Inc.

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/

^ permalink raw reply	[flat|nested] 8+ messages in thread
* Re: [PATCH] dt-bindings: mtd: jedec,spi-nor: remove unneeded properties
  2022-04-07 14:20 ` Krzysztof Kozlowski
@ 2022-04-07 18:21   ` Rob Herring
  -1 siblings, 0 replies; 8+ messages in thread
From: Rob Herring @ 2022-04-07 18:21 UTC (permalink / raw)
  To: Krzysztof Kozlowski
  Cc: Tudor Ambarus, Pratyush Yadav, Michael Walle, Miquel Raynal,
	Richard Weinberger, Vignesh Raghavendra, Krzysztof Kozlowski,
	linux-mtd, devicetree, linux-kernel

On Thu, Apr 07, 2022 at 04:20:04PM +0200, Krzysztof Kozlowski wrote:
> After conversion the jedec,spi-nor DT schema to reference other schemas
> (SPI and MTD) and use unevaluatedProperties, several properties are
> redundant.
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
>  .../devicetree/bindings/mtd/jedec,spi-nor.yaml        | 11 -----------
>  1 file changed, 11 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/mtd/jedec,spi-nor.yaml b/Documentation/devicetree/bindings/mtd/jedec,spi-nor.yaml
> index 4abfb4cfc157..708e7f88fd92 100644
> --- a/Documentation/devicetree/bindings/mtd/jedec,spi-nor.yaml
> +++ b/Documentation/devicetree/bindings/mtd/jedec,spi-nor.yaml
> @@ -50,10 +50,6 @@ properties:
>      minItems: 1
>      maxItems: 2
>  
> -  spi-max-frequency: true
> -  spi-rx-bus-width: true
> -  spi-tx-bus-width: true
> -
>    m25p,fast-read:
>      type: boolean
>      description:
> @@ -74,14 +70,9 @@ properties:
>        be used on such systems, to denote the absence of a reliable reset
>        mechanism.
>  
> -  label: true
> -
>    partitions:
>      type: object
>  
> -  '#address-cells': true
> -  '#size-cells': true

These are needed for 'partition' nodes.

> -
>  patternProperties:
>    # Note: use 'partitions' node for new users
>    '^partition@':
> @@ -99,8 +90,6 @@ examples:
>          #size-cells = <0>;
>  
>          flash@0 {
> -            #address-cells = <1>;
> -            #size-cells = <1>;
>              compatible = "spansion,m25p80", "jedec,spi-nor";
>              reg = <0>;
>              spi-max-frequency = <40000000>;
> -- 
> 2.32.0
> 
> 

^ permalink raw reply	[flat|nested] 8+ messages in thread
* Re: [PATCH] dt-bindings: mtd: jedec,spi-nor: remove unneeded properties
@ 2022-04-07 18:21   ` Rob Herring
  0 siblings, 0 replies; 8+ messages in thread
From: Rob Herring @ 2022-04-07 18:21 UTC (permalink / raw)
  To: Krzysztof Kozlowski
  Cc: Tudor Ambarus, Pratyush Yadav, Michael Walle, Miquel Raynal,
	Richard Weinberger, Vignesh Raghavendra, Krzysztof Kozlowski,
	linux-mtd, devicetree, linux-kernel

On Thu, Apr 07, 2022 at 04:20:04PM +0200, Krzysztof Kozlowski wrote:
> After conversion the jedec,spi-nor DT schema to reference other schemas
> (SPI and MTD) and use unevaluatedProperties, several properties are
> redundant.
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
>  .../devicetree/bindings/mtd/jedec,spi-nor.yaml        | 11 -----------
>  1 file changed, 11 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/mtd/jedec,spi-nor.yaml b/Documentation/devicetree/bindings/mtd/jedec,spi-nor.yaml
> index 4abfb4cfc157..708e7f88fd92 100644
> --- a/Documentation/devicetree/bindings/mtd/jedec,spi-nor.yaml
> +++ b/Documentation/devicetree/bindings/mtd/jedec,spi-nor.yaml
> @@ -50,10 +50,6 @@ properties:
>      minItems: 1
>      maxItems: 2
>  
> -  spi-max-frequency: true
> -  spi-rx-bus-width: true
> -  spi-tx-bus-width: true
> -
>    m25p,fast-read:
>      type: boolean
>      description:
> @@ -74,14 +70,9 @@ properties:
>        be used on such systems, to denote the absence of a reliable reset
>        mechanism.
>  
> -  label: true
> -
>    partitions:
>      type: object
>  
> -  '#address-cells': true
> -  '#size-cells': true

These are needed for 'partition' nodes.

> -
>  patternProperties:
>    # Note: use 'partitions' node for new users
>    '^partition@':
> @@ -99,8 +90,6 @@ examples:
>          #size-cells = <0>;
>  
>          flash@0 {
> -            #address-cells = <1>;
> -            #size-cells = <1>;
>              compatible = "spansion,m25p80", "jedec,spi-nor";
>              reg = <0>;
>              spi-max-frequency = <40000000>;
> -- 
> 2.32.0
> 
> 

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/

^ permalink raw reply	[flat|nested] 8+ messages in thread
* Re: [PATCH] dt-bindings: mtd: jedec,spi-nor: remove unneeded properties
  2022-04-07 18:21   ` Rob Herring
@ 2022-04-07 21:06     ` Krzysztof Kozlowski
  -1 siblings, 0 replies; 8+ messages in thread
From: Krzysztof Kozlowski @ 2022-04-07 21:06 UTC (permalink / raw)
  To: Rob Herring
  Cc: Tudor Ambarus, Pratyush Yadav, Michael Walle, Miquel Raynal,
	Richard Weinberger, Vignesh Raghavendra, Krzysztof Kozlowski,
	linux-mtd, devicetree, linux-kernel

On 07/04/2022 20:21, Rob Herring wrote:
> On Thu, Apr 07, 2022 at 04:20:04PM +0200, Krzysztof Kozlowski wrote:
>> After conversion the jedec,spi-nor DT schema to reference other schemas
>> (SPI and MTD) and use unevaluatedProperties, several properties are
>> redundant.
>>
>> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>> ---
>>  .../devicetree/bindings/mtd/jedec,spi-nor.yaml        | 11 -----------
>>  1 file changed, 11 deletions(-)
>>
>> diff --git a/Documentation/devicetree/bindings/mtd/jedec,spi-nor.yaml b/Documentation/devicetree/bindings/mtd/jedec,spi-nor.yaml
>> index 4abfb4cfc157..708e7f88fd92 100644
>> --- a/Documentation/devicetree/bindings/mtd/jedec,spi-nor.yaml
>> +++ b/Documentation/devicetree/bindings/mtd/jedec,spi-nor.yaml
>> @@ -50,10 +50,6 @@ properties:
>>      minItems: 1
>>      maxItems: 2
>>  
>> -  spi-max-frequency: true
>> -  spi-rx-bus-width: true
>> -  spi-tx-bus-width: true
>> -
>>    m25p,fast-read:
>>      type: boolean
>>      description:
>> @@ -74,14 +70,9 @@ properties:
>>        be used on such systems, to denote the absence of a reliable reset
>>        mechanism.
>>  
>> -  label: true
>> -
>>    partitions:
>>      type: object
>>  
>> -  '#address-cells': true
>> -  '#size-cells': true
> 
> These are needed for 'partition' nodes.
> 

I am sure I saw them in one of referenced schemas, that's why I removed
them. But now I cannot find it so probably I looked at wrong schema.

Thanks for pointing this out, I'll fix the patch.

Best regards,
Krzysztof

^ permalink raw reply	[flat|nested] 8+ messages in thread
* Re: [PATCH] dt-bindings: mtd: jedec,spi-nor: remove unneeded properties
@ 2022-04-07 21:06     ` Krzysztof Kozlowski
  0 siblings, 0 replies; 8+ messages in thread
From: Krzysztof Kozlowski @ 2022-04-07 21:06 UTC (permalink / raw)
  To: Rob Herring
  Cc: Tudor Ambarus, Pratyush Yadav, Michael Walle, Miquel Raynal,
	Richard Weinberger, Vignesh Raghavendra, Krzysztof Kozlowski,
	linux-mtd, devicetree, linux-kernel

On 07/04/2022 20:21, Rob Herring wrote:
> On Thu, Apr 07, 2022 at 04:20:04PM +0200, Krzysztof Kozlowski wrote:
>> After conversion the jedec,spi-nor DT schema to reference other schemas
>> (SPI and MTD) and use unevaluatedProperties, several properties are
>> redundant.
>>
>> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>> ---
>>  .../devicetree/bindings/mtd/jedec,spi-nor.yaml        | 11 -----------
>>  1 file changed, 11 deletions(-)
>>
>> diff --git a/Documentation/devicetree/bindings/mtd/jedec,spi-nor.yaml b/Documentation/devicetree/bindings/mtd/jedec,spi-nor.yaml
>> index 4abfb4cfc157..708e7f88fd92 100644
>> --- a/Documentation/devicetree/bindings/mtd/jedec,spi-nor.yaml
>> +++ b/Documentation/devicetree/bindings/mtd/jedec,spi-nor.yaml
>> @@ -50,10 +50,6 @@ properties:
>>      minItems: 1
>>      maxItems: 2
>>  
>> -  spi-max-frequency: true
>> -  spi-rx-bus-width: true
>> -  spi-tx-bus-width: true
>> -
>>    m25p,fast-read:
>>      type: boolean
>>      description:
>> @@ -74,14 +70,9 @@ properties:
>>        be used on such systems, to denote the absence of a reliable reset
>>        mechanism.
>>  
>> -  label: true
>> -
>>    partitions:
>>      type: object
>>  
>> -  '#address-cells': true
>> -  '#size-cells': true
> 
> These are needed for 'partition' nodes.
> 

I am sure I saw them in one of referenced schemas, that's why I removed
them. But now I cannot find it so probably I looked at wrong schema.

Thanks for pointing this out, I'll fix the patch.

Best regards,
Krzysztof

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/

^ permalink raw reply	[flat|nested] 8+ messages in thread
end of thread, other threads:[~2022-04-07 21:07 UTC | newest]

Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-04-07 14:20 [PATCH] dt-bindings: mtd: jedec,spi-nor: remove unneeded properties Krzysztof Kozlowski
2022-04-07 14:20 ` Krzysztof Kozlowski
2022-04-07 18:09 ` Pratyush Yadav
2022-04-07 18:09   ` Pratyush Yadav
2022-04-07 18:21 ` Rob Herring
2022-04-07 18:21   ` Rob Herring
2022-04-07 21:06   ` Krzysztof Kozlowski
2022-04-07 21:06     ` Krzysztof Kozlowski

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.