* [PATCH]: net: Unexport napi_gro_flush().
@ 2010-01-19 22:12 David Miller
2010-01-20 6:56 ` Blaschka
0 siblings, 1 reply; 2+ messages in thread
From: David Miller @ 2010-01-19 22:12 UTC (permalink / raw)
To: netdev
Nothing outside of net/core/dev.c uses it.
Signed-off-by: David S. Miller <davem@davemloft.net>
---
include/linux/netdevice.h | 1 -
net/core/dev.c | 3 +--
2 files changed, 1 insertions(+), 3 deletions(-)
diff --git a/include/linux/netdevice.h b/include/linux/netdevice.h
index a3fccc8..468a11d 100644
--- a/include/linux/netdevice.h
+++ b/include/linux/netdevice.h
@@ -1527,7 +1527,6 @@ extern int netif_rx(struct sk_buff *skb);
extern int netif_rx_ni(struct sk_buff *skb);
#define HAVE_NETIF_RECEIVE_SKB 1
extern int netif_receive_skb(struct sk_buff *skb);
-extern void napi_gro_flush(struct napi_struct *napi);
extern gro_result_t dev_gro_receive(struct napi_struct *napi,
struct sk_buff *skb);
extern gro_result_t napi_skb_finish(gro_result_t ret, struct sk_buff *skb);
diff --git a/net/core/dev.c b/net/core/dev.c
index a008f69..5747b9e 100644
--- a/net/core/dev.c
+++ b/net/core/dev.c
@@ -2582,7 +2582,7 @@ out:
return netif_receive_skb(skb);
}
-void napi_gro_flush(struct napi_struct *napi)
+static void napi_gro_flush(struct napi_struct *napi)
{
struct sk_buff *skb, *next;
@@ -2595,7 +2595,6 @@ void napi_gro_flush(struct napi_struct *napi)
napi->gro_count = 0;
napi->gro_list = NULL;
}
-EXPORT_SYMBOL(napi_gro_flush);
enum gro_result dev_gro_receive(struct napi_struct *napi, struct sk_buff *skb)
{
--
1.6.5
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH]: net: Unexport napi_gro_flush().
2010-01-19 22:12 [PATCH]: net: Unexport napi_gro_flush() David Miller
@ 2010-01-20 6:56 ` Blaschka
0 siblings, 0 replies; 2+ messages in thread
From: Blaschka @ 2010-01-20 6:56 UTC (permalink / raw)
To: David Miller; +Cc: netdev, linux-s390
On Tue, Jan 19, 2010 at 02:12:55PM -0800, David Miller wrote:
>
> Nothing outside of net/core/dev.c uses it.
>
> Signed-off-by: David S. Miller <davem@davemloft.net>
> ---
> include/linux/netdevice.h | 1 -
> net/core/dev.c | 3 +--
> 2 files changed, 1 insertions(+), 3 deletions(-)
>
Hi Dave,
I have a qeth patch which uses napi_gro_flush (not posted yet).
There is following idea:
The inbound processing of the qeth driver is already in bottomhalf
(qdio input tasklet) so we can switch from netif_rx to
netif_receive_skb. This allows us to exploit gro code for the
layer 3 driver. I would introduce a dummy napi_struct and call
napi_gro_flush when the inbound tasklet ends.
Should I post the patch for review?
Thanks,
Frank
> diff --git a/include/linux/netdevice.h b/include/linux/netdevice.h
> index a3fccc8..468a11d 100644
> --- a/include/linux/netdevice.h
> +++ b/include/linux/netdevice.h
> @@ -1527,7 +1527,6 @@ extern int netif_rx(struct sk_buff *skb);
> extern int netif_rx_ni(struct sk_buff *skb);
> #define HAVE_NETIF_RECEIVE_SKB 1
> extern int netif_receive_skb(struct sk_buff *skb);
> -extern void napi_gro_flush(struct napi_struct *napi);
> extern gro_result_t dev_gro_receive(struct napi_struct *napi,
> struct sk_buff *skb);
> extern gro_result_t napi_skb_finish(gro_result_t ret, struct sk_buff *skb);
> diff --git a/net/core/dev.c b/net/core/dev.c
> index a008f69..5747b9e 100644
> --- a/net/core/dev.c
> +++ b/net/core/dev.c
> @@ -2582,7 +2582,7 @@ out:
> return netif_receive_skb(skb);
> }
>
> -void napi_gro_flush(struct napi_struct *napi)
> +static void napi_gro_flush(struct napi_struct *napi)
> {
> struct sk_buff *skb, *next;
>
> @@ -2595,7 +2595,6 @@ void napi_gro_flush(struct napi_struct *napi)
> napi->gro_count = 0;
> napi->gro_list = NULL;
> }
> -EXPORT_SYMBOL(napi_gro_flush);
>
> enum gro_result dev_gro_receive(struct napi_struct *napi, struct sk_buff *skb)
> {
> --
> 1.6.5
>
> --
> To unsubscribe from this list: send the line "unsubscribe netdev" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-01-20 6:56 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2010-01-19 22:12 [PATCH]: net: Unexport napi_gro_flush() David Miller
2010-01-20 6:56 ` Blaschka
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.