From: Wolfram Sang <w.sang@pengutronix.de> To: Anatolij Gustschin <agust@denx.de> Cc: linuxppc-dev@ozlabs.org, linux-mtd@lists.infradead.org, wd@denx.de, dzu@denx.de, Piotr Ziecik <kosmo@semihalf.com> Subject: Re: [PATCH 06/11] mtd: Add MPC5121 NAND Flash Controller driver Date: Wed, 20 Jan 2010 11:49:15 +0100 [thread overview] Message-ID: <20100120104915.GB5041@pengutronix.de> (raw) In-Reply-To: <1263932653-3634-7-git-send-email-agust@denx.de> [-- Attachment #1: Type: text/plain, Size: 1576 bytes --] On Tue, Jan 19, 2010 at 09:24:08PM +0100, Anatolij Gustschin wrote: > From: Piotr Ziecik <kosmo@semihalf.com> > > Adds NAND Flash Controller driver for MPC5121 Revision 2. > All device features, except hardware ECC and power management, > are supported. > > Signed-off-by: Piotr Ziecik <kosmo@semihalf.com> > Signed-off-by: Wolfgang Denk <wd@denx.de> > Signed-off-by: Anatolij Gustschin <agust@denx.de> > Cc: <linux-mtd@lists.infradead.org> > Cc: Grant Likely <grant.likely@secretlab.ca> > Cc: John Rigby <jcrigby@gmail.com> > --- Please include a logfile with changes since the last version. This really helps. > +static int __init mpc5121_nfc_probe(struct of_device *op, > + const struct of_device_id *match) [...] > +{ > + /* Support external chip-select logic on ADS5121 board */ > + rootnode = of_find_node_by_path("/"); > + if (of_device_is_compatible(rootnode, "fsl,mpc5121ads")) { > + retval = ads5121_chipselect_init(mtd); > + if (retval) { > + dev_err(dev, "Chipselect init error!\n"); > + of_node_put(rootnode); > + return retval; > + } > + > + chip->select_chip = ads5121_select_chip; > + } > + of_node_put(rootnode); If we have to live with the platform-stuff being in the driver, maybe a table having the compatible-string and an init-function pointer per entry will make it scale better with the number of boards? Regards, Wolfram -- Pengutronix e.K. | Wolfram Sang | Industrial Linux Solutions | http://www.pengutronix.de/ | [-- Attachment #2: Digital signature --] [-- Type: application/pgp-signature, Size: 197 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Wolfram Sang <w.sang@pengutronix.de> To: Anatolij Gustschin <agust@denx.de> Cc: linuxppc-dev@ozlabs.org, linux-mtd@lists.infradead.org, dzu@denx.de, Piotr Ziecik <kosmo@semihalf.com> Subject: Re: [PATCH 06/11] mtd: Add MPC5121 NAND Flash Controller driver Date: Wed, 20 Jan 2010 11:49:15 +0100 [thread overview] Message-ID: <20100120104915.GB5041@pengutronix.de> (raw) In-Reply-To: <1263932653-3634-7-git-send-email-agust@denx.de> [-- Attachment #1: Type: text/plain, Size: 1576 bytes --] On Tue, Jan 19, 2010 at 09:24:08PM +0100, Anatolij Gustschin wrote: > From: Piotr Ziecik <kosmo@semihalf.com> > > Adds NAND Flash Controller driver for MPC5121 Revision 2. > All device features, except hardware ECC and power management, > are supported. > > Signed-off-by: Piotr Ziecik <kosmo@semihalf.com> > Signed-off-by: Wolfgang Denk <wd@denx.de> > Signed-off-by: Anatolij Gustschin <agust@denx.de> > Cc: <linux-mtd@lists.infradead.org> > Cc: Grant Likely <grant.likely@secretlab.ca> > Cc: John Rigby <jcrigby@gmail.com> > --- Please include a logfile with changes since the last version. This really helps. > +static int __init mpc5121_nfc_probe(struct of_device *op, > + const struct of_device_id *match) [...] > +{ > + /* Support external chip-select logic on ADS5121 board */ > + rootnode = of_find_node_by_path("/"); > + if (of_device_is_compatible(rootnode, "fsl,mpc5121ads")) { > + retval = ads5121_chipselect_init(mtd); > + if (retval) { > + dev_err(dev, "Chipselect init error!\n"); > + of_node_put(rootnode); > + return retval; > + } > + > + chip->select_chip = ads5121_select_chip; > + } > + of_node_put(rootnode); If we have to live with the platform-stuff being in the driver, maybe a table having the compatible-string and an init-function pointer per entry will make it scale better with the number of boards? Regards, Wolfram -- Pengutronix e.K. | Wolfram Sang | Industrial Linux Solutions | http://www.pengutronix.de/ | [-- Attachment #2: Digital signature --] [-- Type: application/pgp-signature, Size: 197 bytes --]
next prev parent reply other threads:[~2010-01-20 10:49 UTC|newest] Thread overview: 62+ messages / expand[flat|nested] mbox.gz Atom feed top 2010-01-19 20:24 [PATCH 0/11] Update support for MPC512x Anatolij Gustschin 2010-01-19 20:24 ` Anatolij Gustschin 2010-01-19 20:24 ` Anatolij Gustschin 2010-01-19 20:24 ` Anatolij Gustschin 2010-01-19 20:24 ` [PATCH 01/11] fs_enet: Add support for MPC512x to fs_enet driver Anatolij Gustschin 2010-01-19 20:24 ` Anatolij Gustschin 2010-01-19 20:48 ` Scott Wood 2010-01-20 11:20 ` Anatolij Gustschin 2010-01-20 11:20 ` Anatolij Gustschin 2010-01-20 17:02 ` Scott Wood 2010-01-20 17:02 ` Scott Wood 2010-01-19 20:24 ` [PATCH 02/11] fs_enet: Add FEC TX Alignment workaround for MPC5121 Anatolij Gustschin 2010-01-19 20:24 ` Anatolij Gustschin 2010-01-19 20:37 ` David Miller 2010-01-19 20:37 ` David Miller 2010-01-19 23:42 ` Stephen Rothwell 2010-01-19 23:42 ` Stephen Rothwell 2010-01-20 4:04 ` David Miller 2010-01-20 4:04 ` David Miller 2010-01-20 10:22 ` Wolfram Sang 2010-01-20 10:22 ` Wolfram Sang 2010-01-19 20:24 ` [PATCH 03/11] powerpc/mpc5121: Add machine restart support Anatolij Gustschin 2010-01-20 11:28 ` Wolfram Sang 2010-01-26 7:53 ` Anatolij Gustschin [not found] ` <1263932653-3634-1-git-send-email-agust-ynQEQJNshbs@public.gmane.org> 2010-01-19 20:24 ` [PATCH 04/11] i2c-mpc: Add MPC5121 I2C bus support Anatolij Gustschin 2010-01-19 20:24 ` Anatolij Gustschin [not found] ` <1263932653-3634-5-git-send-email-agust-ynQEQJNshbs@public.gmane.org> 2010-01-21 17:12 ` Grant Likely 2010-01-21 17:12 ` Grant Likely [not found] ` <fa686aa41001210912r5fd2a5a4g8a072e0c41ee4107-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org> 2010-01-22 12:15 ` Wolfgang Grandegger 2010-01-22 12:15 ` Wolfgang Grandegger 2010-01-20 11:22 ` [PATCH 0/11] Update support for MPC512x Wolfram Sang 2010-01-20 11:22 ` Wolfram Sang 2010-01-20 11:22 ` Wolfram Sang [not found] ` <20100120112232.GD5041-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org> 2010-01-26 8:06 ` Anatolij Gustschin 2010-01-26 8:06 ` Anatolij Gustschin 2010-01-26 8:06 ` Anatolij Gustschin 2010-01-26 12:16 ` Wolfram Sang 2010-01-26 12:16 ` Wolfram Sang 2010-01-26 12:16 ` Wolfram Sang 2010-01-19 20:24 ` [PATCH 05/11] rtc: Add MPC5121 Real time clock driver Anatolij Gustschin 2010-01-20 11:01 ` Wolfram Sang 2010-01-20 22:19 ` [rtc-linux] " Alessandro Zummo 2010-01-19 20:24 ` [PATCH 06/11] mtd: Add MPC5121 NAND Flash Controller driver Anatolij Gustschin 2010-01-19 20:24 ` Anatolij Gustschin 2010-01-20 10:49 ` Wolfram Sang [this message] 2010-01-20 10:49 ` Wolfram Sang 2010-01-25 15:56 ` Anatolij Gustschin 2010-01-25 15:56 ` Anatolij Gustschin 2010-01-19 20:24 ` [PATCH 07/11] dma: Add MPC512x DMA driver Anatolij Gustschin 2010-01-21 17:22 ` Grant Likely 2010-01-26 8:03 ` Anatolij Gustschin 2010-01-19 20:24 ` [PATCH 08/11] powerpc/mpc5121: add USB host support Anatolij Gustschin [not found] ` <1263932653-3634-9-git-send-email-agust-ynQEQJNshbs@public.gmane.org> 2010-01-21 17:43 ` Grant Likely 2010-01-21 17:43 ` Grant Likely [not found] ` <fa686aa41001210943i3739f693uecf0c05ef0a81c1-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org> 2010-01-25 17:00 ` Anatolij Gustschin 2010-01-25 17:00 ` Anatolij Gustschin 2010-01-27 16:52 ` Grant Likely 2010-01-27 16:52 ` Grant Likely 2010-01-19 20:24 ` [PATCH 09/11] powerpc/mpc512x: shared DIU framebuffer support Anatolij Gustschin 2010-01-19 20:24 ` [PATCH 10/11] powerpc/mpc5121: update mpc5121ads DTS Anatolij Gustschin 2010-01-19 20:24 ` [PATCH 11/11] powerpc/mpc5121: Add default config for MPC5121ADS Anatolij Gustschin 2010-01-21 17:47 ` Grant Likely
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20100120104915.GB5041@pengutronix.de \ --to=w.sang@pengutronix.de \ --cc=agust@denx.de \ --cc=dzu@denx.de \ --cc=kosmo@semihalf.com \ --cc=linux-mtd@lists.infradead.org \ --cc=linuxppc-dev@ozlabs.org \ --cc=wd@denx.de \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.