From: Samuel Ortiz <sameo@linux.intel.com>
To: Dmitry Artamonow <mad_soft@inbox.ru>
Cc: linux-kernel@vger.kernel.org, Magnus Damm <damm@opensource.se>,
Ian Molton <ian@mnementh.co.uk>,
Philipp Zabel <philipp.zabel@gmail.com>
Subject: Re: [PATCH] mfd: fix asic3 build
Date: Tue, 26 Jan 2010 09:49:40 +0100 [thread overview]
Message-ID: <20100126084939.GA28172@sortiz.org> (raw)
In-Reply-To: <1264281620-24378-1-git-send-email-mad_soft@inbox.ru>
Hi Dmitry,
On Sun, Jan 24, 2010 at 12:20:20AM +0300, Dmitry Artamonow wrote:
> Commit 64e8867ba8 (mfd: tmio_mmc hardware abstraction for CNF area)
> missed to update Makefile rule for asic3, which leads to following
> error during linking:
> LD .tmp_vmlinux1
> drivers/built-in.o: In function `asic3_mmc_clk_div':
> ledtrig-backlight.c:(.text+0x3de28): undefined reference to `tmio_core_mmc_clk_div'
> drivers/built-in.o: In function `asic3_mmc_pwr':
> ledtrig-backlight.c:(.text+0x3de50): undefined reference to `tmio_core_mmc_pwr'
> drivers/built-in.o: In function `asic3_mmc_enable':
> ledtrig-backlight.c:(.text+0x3e154): undefined reference to `tmio_core_mmc_enable'
> make: *** [.tmp_vmlinux1] Error 1
Thanks a lot, patch applied. I will ask Linus to pull it in a couple days or
so.
Cheers,
Samuel.
> Signed-off-by: Dmitry Artamonow <mad_soft@inbox.ru>
> ---
> This is a patch for regression introduced in -rc5 (-rc4 was ok)
> Error above is from building kernel 2.6.33-rc5 with magician_defconfig.
> Sorry if this already been reported/fixed.
>
> drivers/mfd/Makefile | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/mfd/Makefile b/drivers/mfd/Makefile
> index 8f0d184..97134c5 100644
> --- a/drivers/mfd/Makefile
> +++ b/drivers/mfd/Makefile
> @@ -3,7 +3,7 @@
> #
>
> obj-$(CONFIG_MFD_SM501) += sm501.o
> -obj-$(CONFIG_MFD_ASIC3) += asic3.o
> +obj-$(CONFIG_MFD_ASIC3) += asic3.o tmio_core.o
> obj-$(CONFIG_MFD_SH_MOBILE_SDHI) += sh_mobile_sdhi.o
>
> obj-$(CONFIG_HTC_EGPIO) += htc-egpio.o
> --
> 1.6.6
>
--
Intel Open Source Technology Centre
http://oss.intel.com/
prev parent reply other threads:[~2010-01-26 8:48 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-23 21:20 [PATCH] mfd: fix asic3 build Dmitry Artamonow
2010-01-26 8:49 ` Samuel Ortiz [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100126084939.GA28172@sortiz.org \
--to=sameo@linux.intel.com \
--cc=damm@opensource.se \
--cc=ian@mnementh.co.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=mad_soft@inbox.ru \
--cc=philipp.zabel@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.