[PATCH] mfd: fix asic3 build

[PATCH] mfd: fix asic3 build

[Dmitry Artamonow]

Commit 64e8867ba8 (mfd: tmio_mmc hardware abstraction for CNF area)
missed to update Makefile rule for asic3, which leads to following
error during linking:
  LD      .tmp_vmlinux1
drivers/built-in.o: In function `asic3_mmc_clk_div':
ledtrig-backlight.c:(.text+0x3de28): undefined reference to `tmio_core_mmc_clk_div'
drivers/built-in.o: In function `asic3_mmc_pwr':
ledtrig-backlight.c:(.text+0x3de50): undefined reference to `tmio_core_mmc_pwr'
drivers/built-in.o: In function `asic3_mmc_enable':
ledtrig-backlight.c:(.text+0x3e154): undefined reference to `tmio_core_mmc_enable'
make: *** [.tmp_vmlinux1] Error 1

Signed-off-by: Dmitry Artamonow <mad_soft@inbox.ru>
---
This is a patch for regression introduced in -rc5 (-rc4 was ok)
Error above is from building kernel 2.6.33-rc5 with magician_defconfig.
Sorry if this already been reported/fixed.

 drivers/mfd/Makefile |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/mfd/Makefile b/drivers/mfd/Makefile
index 8f0d184..97134c5 100644
--- a/drivers/mfd/Makefile
+++ b/drivers/mfd/Makefile
@@ -3,7 +3,7 @@
 #
 
 obj-$(CONFIG_MFD_SM501)		+= sm501.o
-obj-$(CONFIG_MFD_ASIC3)		+= asic3.o
+obj-$(CONFIG_MFD_ASIC3)		+= asic3.o tmio_core.o
 obj-$(CONFIG_MFD_SH_MOBILE_SDHI)		+= sh_mobile_sdhi.o
 
 obj-$(CONFIG_HTC_EGPIO)		+= htc-egpio.o
-- 
1.6.6

Re: [PATCH] mfd: fix asic3 build

[Samuel Ortiz]

Hi Dmitry,

On Sun, Jan 24, 2010 at 12:20:20AM +0300, Dmitry Artamonow wrote:
> Commit 64e8867ba8 (mfd: tmio_mmc hardware abstraction for CNF area)
> missed to update Makefile rule for asic3, which leads to following
> error during linking:
>   LD      .tmp_vmlinux1
> drivers/built-in.o: In function `asic3_mmc_clk_div':
> ledtrig-backlight.c:(.text+0x3de28): undefined reference to `tmio_core_mmc_clk_div'
> drivers/built-in.o: In function `asic3_mmc_pwr':
> ledtrig-backlight.c:(.text+0x3de50): undefined reference to `tmio_core_mmc_pwr'
> drivers/built-in.o: In function `asic3_mmc_enable':
> ledtrig-backlight.c:(.text+0x3e154): undefined reference to `tmio_core_mmc_enable'
> make: *** [.tmp_vmlinux1] Error 1
Thanks a lot, patch applied. I will ask Linus to pull it in a couple days or
so.

Cheers,
Samuel.


> Signed-off-by: Dmitry Artamonow <mad_soft@inbox.ru>
> ---
> This is a patch for regression introduced in -rc5 (-rc4 was ok)
> Error above is from building kernel 2.6.33-rc5 with magician_defconfig.
> Sorry if this already been reported/fixed.
> 
>  drivers/mfd/Makefile |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/mfd/Makefile b/drivers/mfd/Makefile
> index 8f0d184..97134c5 100644
> --- a/drivers/mfd/Makefile
> +++ b/drivers/mfd/Makefile
> @@ -3,7 +3,7 @@
>  #
>  
>  obj-$(CONFIG_MFD_SM501)		+= sm501.o
> -obj-$(CONFIG_MFD_ASIC3)		+= asic3.o
> +obj-$(CONFIG_MFD_ASIC3)		+= asic3.o tmio_core.o
>  obj-$(CONFIG_MFD_SH_MOBILE_SDHI)		+= sh_mobile_sdhi.o
>  
>  obj-$(CONFIG_HTC_EGPIO)		+= htc-egpio.o
> -- 
> 1.6.6
> 

-- 
Intel Open Source Technology Centre
http://oss.intel.com/