* [PATCH] ocfs2: Fix contiguousness check in ocfs2_try_to_merge_extent_map()
@ 2010-02-05 9:26 ` Roel Kluin
0 siblings, 0 replies; 4+ messages in thread
From: Roel Kluin @ 2010-02-05 9:26 UTC (permalink / raw)
To: Mark Fasheh, Joel Becker, tao.ma, ocfs2-devel, Andrew Morton, LKML
The wrong member was compared in the continguousness check.
Acked-by: Tao Ma <tao.ma@oracle.com>
Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
---
>> } else if ((ins->ei_phys + ins->ei_clusters) == emi->ei_phys &&
>> (ins->ei_cpos + ins->ei_clusters) == emi->ei_phys &&
>> should that 2nd emi->ei_phys be emi->ei_cpos?
> oh, yes, you are right. Do you want to provide a patch?
Here, I added your ack.
diff --git a/fs/ocfs2/extent_map.c b/fs/ocfs2/extent_map.c
index d35a27f..5328529 100644
--- a/fs/ocfs2/extent_map.c
+++ b/fs/ocfs2/extent_map.c
@@ -192,7 +192,7 @@ static int ocfs2_try_to_merge_extent_map(struct ocfs2_extent_map_item *emi,
emi->ei_clusters += ins->ei_clusters;
return 1;
} else if ((ins->ei_phys + ins->ei_clusters) == emi->ei_phys &&
- (ins->ei_cpos + ins->ei_clusters) == emi->ei_phys &&
+ (ins->ei_cpos + ins->ei_clusters) == emi->ei_cpos &&
ins->ei_flags == emi->ei_flags) {
emi->ei_phys = ins->ei_phys;
emi->ei_cpos = ins->ei_cpos;
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [Ocfs2-devel] [PATCH] ocfs2: Fix contiguousness check in ocfs2_try_to_merge_extent_map()
@ 2010-02-05 9:26 ` Roel Kluin
0 siblings, 0 replies; 4+ messages in thread
From: Roel Kluin @ 2010-02-05 9:26 UTC (permalink / raw)
To: Mark Fasheh, Joel Becker, tao.ma, ocfs2-devel, Andrew Morton, LKML
The wrong member was compared in the continguousness check.
Acked-by: Tao Ma <tao.ma@oracle.com>
Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
---
>> } else if ((ins->ei_phys + ins->ei_clusters) == emi->ei_phys &&
>> (ins->ei_cpos + ins->ei_clusters) == emi->ei_phys &&
>> should that 2nd emi->ei_phys be emi->ei_cpos?
> oh, yes, you are right. Do you want to provide a patch?
Here, I added your ack.
diff --git a/fs/ocfs2/extent_map.c b/fs/ocfs2/extent_map.c
index d35a27f..5328529 100644
--- a/fs/ocfs2/extent_map.c
+++ b/fs/ocfs2/extent_map.c
@@ -192,7 +192,7 @@ static int ocfs2_try_to_merge_extent_map(struct ocfs2_extent_map_item *emi,
emi->ei_clusters += ins->ei_clusters;
return 1;
} else if ((ins->ei_phys + ins->ei_clusters) == emi->ei_phys &&
- (ins->ei_cpos + ins->ei_clusters) == emi->ei_phys &&
+ (ins->ei_cpos + ins->ei_clusters) == emi->ei_cpos &&
ins->ei_flags == emi->ei_flags) {
emi->ei_phys = ins->ei_phys;
emi->ei_cpos = ins->ei_cpos;
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] ocfs2: Fix contiguousness check in ocfs2_try_to_merge_extent_map()
2010-02-05 9:26 ` [Ocfs2-devel] " Roel Kluin
@ 2010-02-05 23:24 ` Joel Becker
-1 siblings, 0 replies; 4+ messages in thread
From: Joel Becker @ 2010-02-05 23:24 UTC (permalink / raw)
To: Roel Kluin; +Cc: Mark Fasheh, tao.ma, ocfs2-devel, Andrew Morton, LKML
On Fri, Feb 05, 2010 at 10:26:27AM +0100, Roel Kluin wrote:
> The wrong member was compared in the continguousness check.
>
> Acked-by: Tao Ma <tao.ma@oracle.com>
> Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
This patch is now in the fixes branch of ocfs2.git.
Joel
--
"Sometimes when reading Goethe I have the paralyzing suspicion
that he is trying to be funny."
- Guy Davenport
Joel Becker
Principal Software Developer
Oracle
E-mail: joel.becker@oracle.com
Phone: (650) 506-8127
^ permalink raw reply [flat|nested] 4+ messages in thread
* [Ocfs2-devel] [PATCH] ocfs2: Fix contiguousness check in ocfs2_try_to_merge_extent_map()
@ 2010-02-05 23:24 ` Joel Becker
0 siblings, 0 replies; 4+ messages in thread
From: Joel Becker @ 2010-02-05 23:24 UTC (permalink / raw)
To: Roel Kluin; +Cc: Mark Fasheh, tao.ma, ocfs2-devel, Andrew Morton, LKML
On Fri, Feb 05, 2010 at 10:26:27AM +0100, Roel Kluin wrote:
> The wrong member was compared in the continguousness check.
>
> Acked-by: Tao Ma <tao.ma@oracle.com>
> Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
This patch is now in the fixes branch of ocfs2.git.
Joel
--
"Sometimes when reading Goethe I have the paralyzing suspicion
that he is trying to be funny."
- Guy Davenport
Joel Becker
Principal Software Developer
Oracle
E-mail: joel.becker at oracle.com
Phone: (650) 506-8127
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2010-02-05 23:25 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2010-02-05 9:26 [PATCH] ocfs2: Fix contiguousness check in ocfs2_try_to_merge_extent_map() Roel Kluin
2010-02-05 9:26 ` [Ocfs2-devel] " Roel Kluin
2010-02-05 23:24 ` Joel Becker
2010-02-05 23:24 ` [Ocfs2-devel] " Joel Becker
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.