All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Renninger <trenn@suse.de>
To: Julia Lawall <julia@diku.dk>
Cc: Darren Jenkins <darrenrjenkins@gmail.com>,
	Len Brown <lenb@kernel.org>, Zhang Rui <rui.zhang@intel.com>,
	H Hartley Sweeten <hsweeten@visionengravers.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	linux ACPI <linux-acpi@vger.kernel.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Kernel Janitors <kernel-janitors@vger.kernel.org>
Subject: Re: [PATCH] drivers/acpi/processor_thermal.c
Date: Thu, 11 Feb 2010 12:04:50 +0100	[thread overview]
Message-ID: <201002111204.50843.trenn@suse.de> (raw)
In-Reply-To: <Pine.LNX.4.64.1002111150510.2412@ask.diku.dk>

On Thursday 11 February 2010 11:52:20 Julia Lawall wrote:
> On Thu, 11 Feb 2010, Thomas Renninger wrote:
> 
> > Eh, 
> > 
> > what is this for?:
> > static inline void *acpi_driver_data(struct acpi_device *d)
> > {
> >         return d->driver_data;
> > }
...
> 
> A potential patch that gets rid of the uses is below.  I don't have time 
> to look at this in more detail at the moment, but perhaps someone else 
> would like to do so.  The semantic patch (http://coccinelle.lip6.fr) 
> involved is:
> 
> @@
> struct acpi_device *d;
> @@
> 
> - acpi_driver_data(d)
> + d->driver_data
Len, do you mind adding this to your test branch, please.
I can grep over it afterwards (somewhen...) and void out
acpi_driver_data(..)
declaration in acpi_bus.h.

I expect also Darren has to rebase his fixes on top of this
one then.

Thanks,

     Thomas

WARNING: multiple messages have this Message-ID (diff)
From: Thomas Renninger <trenn@suse.de>
To: Julia Lawall <julia@diku.dk>
Cc: Darren Jenkins <darrenrjenkins@gmail.com>,
	Len Brown <lenb@kernel.org>, Zhang Rui <rui.zhang@intel.com>,
	H Hartley Sweeten <hsweeten@visionengravers.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	linux ACPI <linux-acpi@vger.kernel.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Kernel Janitors <kernel-janitors@vger.kernel.org>
Subject: Re: [PATCH] drivers/acpi/processor_thermal.c
Date: Thu, 11 Feb 2010 11:04:50 +0000	[thread overview]
Message-ID: <201002111204.50843.trenn@suse.de> (raw)
In-Reply-To: <Pine.LNX.4.64.1002111150510.2412@ask.diku.dk>

On Thursday 11 February 2010 11:52:20 Julia Lawall wrote:
> On Thu, 11 Feb 2010, Thomas Renninger wrote:
> 
> > Eh, 
> > 
> > what is this for?:
> > static inline void *acpi_driver_data(struct acpi_device *d)
> > {
> >         return d->driver_data;
> > }
...
> 
> A potential patch that gets rid of the uses is below.  I don't have time 
> to look at this in more detail at the moment, but perhaps someone else 
> would like to do so.  The semantic patch (http://coccinelle.lip6.fr) 
> involved is:
> 
> @@
> struct acpi_device *d;
> @@
> 
> - acpi_driver_data(d)
> + d->driver_data
Len, do you mind adding this to your test branch, please.
I can grep over it afterwards (somewhen...) and void out
acpi_driver_data(..)
declaration in acpi_bus.h.

I expect also Darren has to rebase his fixes on top of this
one then.

Thanks,

     Thomas

  reply	other threads:[~2010-02-11 11:04 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-02-11  9:56 [PATCH] drivers/acpi/processor_thermal.c Darren Jenkins
2010-02-11  9:56 ` Darren Jenkins
2010-02-11 10:24 ` Thomas Renninger
2010-02-11 10:24   ` Thomas Renninger
2010-02-11 10:52   ` Julia Lawall
2010-02-11 10:52     ` Julia Lawall
2010-02-11 11:04     ` Thomas Renninger [this message]
2010-02-11 11:04       ` Thomas Renninger
2010-02-11 13:03 Darren Jenkins
2010-02-11 13:03 ` Darren Jenkins

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201002111204.50843.trenn@suse.de \
    --to=trenn@suse.de \
    --cc=akpm@linux-foundation.org \
    --cc=darrenrjenkins@gmail.com \
    --cc=hsweeten@visionengravers.com \
    --cc=julia@diku.dk \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=lenb@kernel.org \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rui.zhang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.