* devres/irq: Fix cross-referencing comments
@ 2010-02-11 14:04 Jean Delvare
2010-02-11 14:55 ` Jiri Kosina
0 siblings, 1 reply; 2+ messages in thread
From: Jean Delvare @ 2010-02-11 14:04 UTC (permalink / raw)
To: Jiri Kosina; +Cc: LKML, Arjan van de Ven
Fix the reference (in comment) from devm_request_irq to devm_free_irq
and back.
Signed-off-by: Jean Delvare <khali@linux-fr.org>
---
kernel/irq/devres.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
--- linux-2.6.33-rc7.orig/kernel/irq/devres.c 2009-06-10 05:05:27.000000000 +0200
+++ linux-2.6.33-rc7/kernel/irq/devres.c 2010-02-11 14:53:35.000000000 +0100
@@ -42,7 +42,7 @@ static int devm_irq_match(struct device
* automatically freed on driver detach.
*
* If an IRQ allocated with this function needs to be freed
- * separately, dev_free_irq() must be used.
+ * separately, devm_free_irq() must be used.
*/
int devm_request_threaded_irq(struct device *dev, unsigned int irq,
irq_handler_t handler, irq_handler_t thread_fn,
@@ -81,7 +81,7 @@ EXPORT_SYMBOL(devm_request_threaded_irq)
* Except for the extra @dev argument, this function takes the
* same arguments and performs the same function as free_irq().
* This function instead of free_irq() should be used to manually
- * free IRQs allocated with dev_request_irq().
+ * free IRQs allocated with devm_request_irq().
*/
void devm_free_irq(struct device *dev, unsigned int irq, void *dev_id)
{
--
Jean Delvare
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: devres/irq: Fix cross-referencing comments
2010-02-11 14:04 devres/irq: Fix cross-referencing comments Jean Delvare
@ 2010-02-11 14:55 ` Jiri Kosina
0 siblings, 0 replies; 2+ messages in thread
From: Jiri Kosina @ 2010-02-11 14:55 UTC (permalink / raw)
To: Jean Delvare; +Cc: LKML, Arjan van de Ven
On Thu, 11 Feb 2010, Jean Delvare wrote:
> Fix the reference (in comment) from devm_request_irq to devm_free_irq
> and back.
>
> Signed-off-by: Jean Delvare <khali@linux-fr.org>
> ---
> kernel/irq/devres.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> --- linux-2.6.33-rc7.orig/kernel/irq/devres.c 2009-06-10 05:05:27.000000000 +0200
> +++ linux-2.6.33-rc7/kernel/irq/devres.c 2010-02-11 14:53:35.000000000 +0100
> @@ -42,7 +42,7 @@ static int devm_irq_match(struct device
> * automatically freed on driver detach.
> *
> * If an IRQ allocated with this function needs to be freed
> - * separately, dev_free_irq() must be used.
> + * separately, devm_free_irq() must be used.
> */
> int devm_request_threaded_irq(struct device *dev, unsigned int irq,
> irq_handler_t handler, irq_handler_t thread_fn,
> @@ -81,7 +81,7 @@ EXPORT_SYMBOL(devm_request_threaded_irq)
> * Except for the extra @dev argument, this function takes the
> * same arguments and performs the same function as free_irq().
> * This function instead of free_irq() should be used to manually
> - * free IRQs allocated with dev_request_irq().
> + * free IRQs allocated with devm_request_irq().
> */
> void devm_free_irq(struct device *dev, unsigned int irq, void *dev_id)
> {
Hi Jean,
the latter has already been fixed in my tree. Applied the former hunk.
Thanks,
--
Jiri Kosina
SUSE Labs, Novell Inc.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-02-11 14:55 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2010-02-11 14:04 devres/irq: Fix cross-referencing comments Jean Delvare
2010-02-11 14:55 ` Jiri Kosina
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.