From: Grant Likely <grant.likely@secretlab.ca>
To: monstr@monstr.eu, sfr@canb.auug.org.au, benh@kernel.crashing.org,
jeremy.kerr@canonical.com, davem@davemloft.net,
microblaze-uclinux@itee.uq.edu.au, linuxppc-dev@ozlabs.org,
sparclinux@vger.kernel.org, devicetree-discuss@lists.ozlabs.org,
linux-kernel@vger.kernel.org
Subject: [PATCH 2/9] proc_devtree: fix THIS_MODULE without module.h
Date: Sat, 13 Feb 2010 09:02:37 -0700 [thread overview]
Message-ID: <20100213160236.4767.48310.stgit@angua> (raw)
In-Reply-To: <20100213154838.4767.83881.stgit@angua>
From: Jeremy Kerr <jeremy.kerr@canonical.com>
Commit e22f628395432b967f2f505858c64450f7835365 introduced a build
breakage for ARM devtree work: the THIS_MODULE macro was added, but we
don't have module.h
This change adds the necessary #include to get THIS_MODULE defined.
While we could just replace it with NULL (PROC_FS is a bool, not a
tristate), using THIS_MODULE will prevent unexpected breakage if we
ever do compile this as a module.
Signed-off-by: Jeremy Kerr <jeremy.kerr@canonical.com>
Signed-off-by: Grant Likely <grant.likely@secretlab.ca>
---
fs/proc/proc_devtree.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/fs/proc/proc_devtree.c b/fs/proc/proc_devtree.c
index 0ec4511..f8650dc 100644
--- a/fs/proc/proc_devtree.c
+++ b/fs/proc/proc_devtree.c
@@ -11,6 +11,7 @@
#include <linux/stat.h>
#include <linux/string.h>
#include <linux/of.h>
+#include <linux/module.h>
#include <asm/prom.h>
#include <asm/uaccess.h>
#include "internal.h"
WARNING: multiple messages have this Message-ID (diff)
From: Grant Likely <grant.likely@secretlab.ca>
To: monstr@monstr.eu, sfr@canb.auug.org.au, benh@kernel.crashing.org,
jeremy.kerr@canonical.com, davem@davemloft.net,
microblaze-uclinux@itee.uq.edu.au, linuxppc-dev@ozlabs.org,
sparclinux@vger.kernel.org, devicetree-discuss@lists.ozlabs.org,
linux-kernel@vger.kernel.org
Subject: [PATCH 2/9] proc_devtree: fix THIS_MODULE without module.h
Date: Sat, 13 Feb 2010 16:02:37 +0000 [thread overview]
Message-ID: <20100213160236.4767.48310.stgit@angua> (raw)
In-Reply-To: <20100213154838.4767.83881.stgit@angua>
From: Jeremy Kerr <jeremy.kerr@canonical.com>
Commit e22f628395432b967f2f505858c64450f7835365 introduced a build
breakage for ARM devtree work: the THIS_MODULE macro was added, but we
don't have module.h
This change adds the necessary #include to get THIS_MODULE defined.
While we could just replace it with NULL (PROC_FS is a bool, not a
tristate), using THIS_MODULE will prevent unexpected breakage if we
ever do compile this as a module.
Signed-off-by: Jeremy Kerr <jeremy.kerr@canonical.com>
Signed-off-by: Grant Likely <grant.likely@secretlab.ca>
---
fs/proc/proc_devtree.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/fs/proc/proc_devtree.c b/fs/proc/proc_devtree.c
index 0ec4511..f8650dc 100644
--- a/fs/proc/proc_devtree.c
+++ b/fs/proc/proc_devtree.c
@@ -11,6 +11,7 @@
#include <linux/stat.h>
#include <linux/string.h>
#include <linux/of.h>
+#include <linux/module.h>
#include <asm/prom.h>
#include <asm/uaccess.h>
#include "internal.h"
next prev parent reply other threads:[~2010-02-13 16:02 UTC|newest]
Thread overview: 77+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-13 16:02 [PATCH 0/9] Random OF cleanups and merges Grant Likely
2010-02-13 16:02 ` Grant Likely
2010-02-13 16:02 ` [PATCH 1/9] of: Remove old and misplaced function declarations Grant Likely
2010-02-13 16:02 ` Grant Likely
2010-02-13 16:02 ` Grant Likely
2010-02-14 6:09 ` Benjamin Herrenschmidt
2010-02-14 6:09 ` Benjamin Herrenschmidt
2010-02-14 6:09 ` Benjamin Herrenschmidt
2010-02-14 6:09 ` Benjamin Herrenschmidt
2010-02-13 16:02 ` Grant Likely [this message]
2010-02-13 16:02 ` [PATCH 2/9] proc_devtree: fix THIS_MODULE without module.h Grant Likely
2010-02-14 6:09 ` Benjamin Herrenschmidt
2010-02-14 6:09 ` Benjamin Herrenschmidt
2010-02-14 6:09 ` Benjamin Herrenschmidt
2010-02-13 16:02 ` Grant Likely
2010-02-13 16:02 ` [PATCH 3/9] of: protect linux/of.h with CONFIG_OF Grant Likely
2010-02-13 16:02 ` Grant Likely
2010-02-14 6:10 ` Benjamin Herrenschmidt
2010-02-14 6:10 ` Benjamin Herrenschmidt
2010-02-14 6:10 ` Benjamin Herrenschmidt
2010-02-14 7:13 ` WALID
2010-02-14 14:06 ` Grant Likely
2010-02-14 14:06 ` Grant Likely
2010-02-14 14:06 ` Grant Likely
2010-02-13 16:02 ` Grant Likely
2010-02-13 16:02 ` [PATCH 4/9] of/flattree: Don't assume HAVE_LMB Grant Likely
2010-02-13 16:02 ` Grant Likely
2010-02-13 16:02 ` Grant Likely
2010-02-14 6:11 ` Benjamin Herrenschmidt
2010-02-14 6:11 ` Benjamin Herrenschmidt
2010-02-14 6:11 ` Benjamin Herrenschmidt
2010-02-14 6:11 ` Benjamin Herrenschmidt
2010-02-14 14:00 ` Michal Simek
2010-02-14 14:00 ` Michal Simek
2010-02-14 14:00 ` Michal Simek
2010-02-14 14:08 ` Grant Likely
2010-02-14 14:08 ` Grant Likely
2010-02-14 14:08 ` Grant Likely
2010-02-14 14:08 ` Grant Likely
2010-02-13 16:02 ` [PATCH 5/9] of: put default string compare and #a/s-cell values into common header Grant Likely
2010-02-13 16:02 ` Grant Likely
2010-02-13 16:02 ` [PATCH 5/9] of: put default string compare and #a/s-cell values into Grant Likely
2010-02-14 6:11 ` [PATCH 5/9] of: put default string compare and #a/s-cell values into common header Benjamin Herrenschmidt
2010-02-14 6:11 ` Benjamin Herrenschmidt
2010-02-14 6:11 ` [PATCH 5/9] of: put default string compare and #a/s-cell Benjamin Herrenschmidt
2010-02-13 16:02 ` [PATCH 6/9] of: remove unused extern reference to devtree_lock Grant Likely
2010-02-13 16:02 ` Grant Likely
2010-02-14 6:12 ` Benjamin Herrenschmidt
2010-02-14 6:12 ` Benjamin Herrenschmidt
2010-02-14 6:12 ` Benjamin Herrenschmidt
2010-02-13 16:02 ` Grant Likely
2010-02-13 16:03 ` [PATCH 7/9] of: move definition of of_chosen into common code Grant Likely
2010-02-13 16:03 ` Grant Likely
2010-02-13 16:03 ` Grant Likely
2010-02-14 6:12 ` Benjamin Herrenschmidt
2010-02-14 6:12 ` Benjamin Herrenschmidt
2010-02-14 6:12 ` Benjamin Herrenschmidt
2010-02-14 6:12 ` Benjamin Herrenschmidt
2010-02-13 16:03 ` [PATCH 8/9] of/sparc: Remove sparc-local declaration of allnodes and devtree_lock Grant Likely
2010-02-13 16:03 ` Grant Likely
2010-02-13 16:03 ` [PATCH 8/9] of/sparc: Remove sparc-local declaration of allnodes and Grant Likely
2010-02-14 6:13 ` [PATCH 8/9] of/sparc: Remove sparc-local declaration of allnodes and devtree_lock Benjamin Herrenschmidt
2010-02-14 6:13 ` Benjamin Herrenschmidt
2010-02-14 6:13 ` [PATCH 8/9] of/sparc: Remove sparc-local declaration of Benjamin Herrenschmidt
2010-02-14 19:50 ` [PATCH 8/9] of/sparc: Remove sparc-local declaration of allnodes and devtree_lock David Miller
2010-02-14 19:50 ` David Miller
2010-02-14 19:50 ` [PATCH 8/9] of/sparc: Remove sparc-local declaration of David Miller
2010-02-13 16:03 ` [PATCH 9/9] of: remove undefined request_OF_resource & release_OF_resource Grant Likely
2010-02-13 16:03 ` [PATCH 9/9] of: remove undefined request_OF_resource & Grant Likely
2010-02-14 6:14 ` [PATCH 9/9] of: remove undefined request_OF_resource & release_OF_resource Benjamin Herrenschmidt
2010-02-14 6:14 ` Benjamin Herrenschmidt
2010-02-14 6:14 ` [PATCH 9/9] of: remove undefined request_OF_resource & Benjamin Herrenschmidt
2010-02-14 6:14 ` [PATCH 9/9] of: remove undefined request_OF_resource & release_OF_resource Benjamin Herrenschmidt
2010-02-13 16:03 ` Grant Likely
2010-02-14 14:06 ` [PATCH 0/9] Random OF cleanups and merges Michal Simek
2010-02-14 14:06 ` Michal Simek
2010-02-14 14:06 ` Michal Simek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100213160236.4767.48310.stgit@angua \
--to=grant.likely@secretlab.ca \
--cc=benh@kernel.crashing.org \
--cc=davem@davemloft.net \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=jeremy.kerr@canonical.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=microblaze-uclinux@itee.uq.edu.au \
--cc=monstr@monstr.eu \
--cc=sfr@canb.auug.org.au \
--cc=sparclinux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.