All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jean Delvare <khali@linux-fr.org>
To: "Pan, Jacob jun" <jacob.jun.pan@intel.com>
Cc: Samuel Ortiz <sameo@linux.intel.com>,
	Denis Turischev <denis@compulab.co.il>,
	LKML <linux-kernel@vger.kernel.org>,
	David Brownell <dbrownell@users.sourceforge.net>,
	"linux-i2c@vger.kernel.org" <linux-i2c@vger.kernel.org>
Subject: Re: [PATCH 1/3] MFD: introduce lpc_sch for Intel SCH LPC bridge
Date: Tue, 16 Feb 2010 16:45:23 +0100	[thread overview]
Message-ID: <20100216164523.5a3e13a5@hyperion.delvare> (raw)
In-Reply-To: <43F901BD926A4E43B106BF17856F0755A2D58DB5@orsmsx508.amr.corp.intel.com>

On Tue, 16 Feb 2010 05:59:34 -0800, Pan, Jacob jun wrote:
> 
> >
> >On Thu, Feb 11, 2010 at 12:26:19PM +0200, Denis Turischev wrote:
> >> Intel Poulsbo (SCH) chipset LPC bridge controller contains several
> >> functions. Creating and MFD driver for the LPC bridge controller allows
> >> simultaneous use of SMBus and GPIO interfaces on the SCH.
> >That looks like an nice patch to me. Before merging it, I'd like to get
> >Jacob's view on it though. Jacob, does moving the SCH SMBus driver to a
> >platform one look fine to you ?
> >
> [[JPAN]] i agree with merging gpio and smbus into lpc driver. the only question
> i had was whether impact to the user space tools has been considered. iirc,
> there are sensors detect tools probe pci bus for smbus controllers, not sure it
> does that for platform bus.

That shouldn't be a problem. The PCI device is still present, so
sensors-detect will see it. Then it will load the required driver, and
that driver will instantiate i2c adapters. The script then probes all
i2c adapters regardless of who created them, so the exact driver
implementation doesn't matter.

-- 
Jean Delvare

  reply	other threads:[~2010-02-16 15:45 UTC|newest]

Thread overview: 73+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-02-11 10:24 [PATCH 0/3] Add Intel SCH GPIO driver Denis Turischev
2010-02-11 10:26 ` [PATCH 1/3] MFD: introduce lpc_sch for Intel SCH LPC bridge Denis Turischev
2010-02-11 10:26   ` Denis Turischev
2010-02-16 10:08   ` Samuel Ortiz
2010-02-16 10:08     ` Samuel Ortiz
2010-02-16 13:59     ` Pan, Jacob jun
2010-02-16 13:59       ` Pan, Jacob jun
2010-02-16 15:45       ` Jean Delvare [this message]
2010-02-16 17:19         ` Pan, Jacob jun
2010-02-16 17:19           ` Pan, Jacob jun
2010-02-16 17:29           ` Jean Delvare
2010-02-16 17:29             ` Jean Delvare
2010-02-16 19:57   ` David Brownell
2010-02-16 19:57     ` David Brownell
2010-02-16 21:49     ` Jean Delvare
2010-02-16 21:49       ` Jean Delvare
2010-02-17 10:03       ` Denis Turischev
2010-02-17 10:03         ` Denis Turischev
2010-02-17 10:44         ` Jean Delvare
2010-02-17 10:44           ` Jean Delvare
2010-02-17 12:35           ` Mike Rapoport
2010-02-17 12:35             ` Mike Rapoport
2010-02-17 14:37             ` Samuel Ortiz
2010-02-17 14:37               ` Samuel Ortiz
2010-02-18 17:42   ` [PATCH v2 " Denis Turischev
2010-02-18 17:42     ` Denis Turischev
2010-02-18 17:45     ` Randy Dunlap
2010-02-18 17:45       ` Randy Dunlap
2010-02-18 18:01       ` [PATCH v3 " Denis Turischev
2010-02-18 18:01         ` Denis Turischev
2010-02-18 18:08         ` Randy Dunlap
2010-02-18 18:08           ` Randy Dunlap
2010-02-19 10:30         ` Samuel Ortiz
2010-02-19 10:30           ` Samuel Ortiz
2010-02-23  8:26         ` Jean Delvare
2010-02-23  8:26           ` Jean Delvare
2010-02-23  9:25           ` Denis Turischev
2010-02-23  9:25             ` Denis Turischev
2010-02-23  9:41             ` Samuel Ortiz
2010-02-23  9:41               ` Samuel Ortiz
2010-02-11 10:28 ` [PATCH 2/3] i2c: convert i2c-isch to platform_device Denis Turischev
2010-02-11 10:28   ` Denis Turischev
2010-02-17 15:42   ` [PATCH v2 " Denis Turischev
2010-02-19 10:33     ` Samuel Ortiz
2010-02-19 10:33       ` Samuel Ortiz
2010-02-21 12:46     ` [PATCH v3 " Denis Turischev
2010-02-21 12:46       ` Denis Turischev
2010-02-23  7:00       ` Mike Rapoport
2010-02-23  7:00         ` Mike Rapoport
2010-02-23  8:12         ` Jean Delvare
2010-02-23  8:12           ` Jean Delvare
2010-02-23  8:20           ` Samuel Ortiz
2010-02-23  8:20             ` Samuel Ortiz
2010-02-23  8:24             ` Jean Delvare
2010-02-23  8:24               ` Jean Delvare
2010-02-28 19:00       ` Samuel Ortiz
2010-03-01 16:59         ` [PATCH v4 " Denis Turischev
2010-03-01 16:59           ` Denis Turischev
2010-03-02 10:06           ` Samuel Ortiz
2010-03-02 10:06             ` Samuel Ortiz
2010-02-11 10:28 ` [PATCH 3/3] gpio: add Intel SCH GPIO controller driver Denis Turischev
2010-02-11 10:28   ` Denis Turischev
2010-02-17 15:39   ` [PATCH v2 " Denis Turischev
2010-02-21 12:50     ` [PATCH v3 " Denis Turischev
2010-02-21 19:12       ` David Brownell
2010-02-24  6:49         ` Mike Rapoport
2010-03-01 18:09           ` Len Brown
2010-03-01 19:50             ` Alan Cox
2010-03-02  6:42             ` Mike Rapoport
2010-03-02  9:29               ` Denis Turischev
2010-02-28 19:01       ` Samuel Ortiz
2010-03-01 17:02         ` [PATCH v4 " Denis Turischev
2010-03-02 10:09           ` Samuel Ortiz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100216164523.5a3e13a5@hyperion.delvare \
    --to=khali@linux-fr.org \
    --cc=dbrownell@users.sourceforge.net \
    --cc=denis@compulab.co.il \
    --cc=jacob.jun.pan@intel.com \
    --cc=linux-i2c@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sameo@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.