From: Samuel Ortiz <sameo@linux.intel.com>
To: Denis Turischev <denis@compulab.co.il>
Cc: Jean Delvare <khali@linux-fr.org>,
LKML <linux-kernel@vger.kernel.org>,
Randy Dunlap <randy.dunlap@oracle.com>,
David Brownell <dbrownell@users.sourceforge.net>,
linux-i2c@vger.kernel.org
Subject: Re: [PATCH v3 1/3] MFD: introduce lpc_sch for Intel SCH LPC bridge
Date: Tue, 23 Feb 2010 10:41:42 +0100 [thread overview]
Message-ID: <20100223094141.GC3550@sortiz.org> (raw)
In-Reply-To: <4B839F27.2040003@compulab.co.il>
Hi Denis,
On Tue, Feb 23, 2010 at 11:25:59AM +0200, Denis Turischev wrote:
> Hi Samuel,
> Regarding renaming of sch* to isch* do you want incremental patch, or fresh version?
>
I'll fix that myself, no worries.
Cheers,
Samuel.
> Denis
>
> Jean Delvare wrote:
> >>+static struct mfd_cell lpc_sch_cells[] = {
> >>+ {
> >>+ .name = "isch_smbus",
> >>+ .num_resources = 1,
> >>+ .resources = &smbus_sch_resource,
> >>+ },
> >>+ {
> >>+ .name = "sch_gpio",
> >>+ .num_resources = 1,
> >>+ .resources = &gpio_sch_resource,
> >>+ },
> >>+};
> >
> >These names are nicely inconsistent. What about "isch_gpio"?
> >
>
> >>+obj-$(CONFIG_LPC_SCH) += lpc_sch.o
> >
> >I don't like this name either. There is another vendor (SMSC) shipping
> >LPC devices with "SCH" in their names, so there is room for confusion.
> >"isch" makes it clearer that we are talking about the Intel ones.
> >
>
--
Intel Open Source Technology Centre
http://oss.intel.com/
WARNING: multiple messages have this Message-ID (diff)
From: Samuel Ortiz <sameo-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
To: Denis Turischev <denis-UTxiZqZC01RS1MOuV/RT9w@public.gmane.org>
Cc: Jean Delvare <khali-PUYAD+kWke1g9hUCZPvPmw@public.gmane.org>,
LKML <linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
Randy Dunlap
<randy.dunlap-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>,
David Brownell
<dbrownell-Rn4VEauK+AKRv+LV9MX5uipxlwaOVQ5f@public.gmane.org>,
linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH v3 1/3] MFD: introduce lpc_sch for Intel SCH LPC bridge
Date: Tue, 23 Feb 2010 10:41:42 +0100 [thread overview]
Message-ID: <20100223094141.GC3550@sortiz.org> (raw)
In-Reply-To: <4B839F27.2040003-UTxiZqZC01RS1MOuV/RT9w@public.gmane.org>
Hi Denis,
On Tue, Feb 23, 2010 at 11:25:59AM +0200, Denis Turischev wrote:
> Hi Samuel,
> Regarding renaming of sch* to isch* do you want incremental patch, or fresh version?
>
I'll fix that myself, no worries.
Cheers,
Samuel.
> Denis
>
> Jean Delvare wrote:
> >>+static struct mfd_cell lpc_sch_cells[] = {
> >>+ {
> >>+ .name = "isch_smbus",
> >>+ .num_resources = 1,
> >>+ .resources = &smbus_sch_resource,
> >>+ },
> >>+ {
> >>+ .name = "sch_gpio",
> >>+ .num_resources = 1,
> >>+ .resources = &gpio_sch_resource,
> >>+ },
> >>+};
> >
> >These names are nicely inconsistent. What about "isch_gpio"?
> >
>
> >>+obj-$(CONFIG_LPC_SCH) += lpc_sch.o
> >
> >I don't like this name either. There is another vendor (SMSC) shipping
> >LPC devices with "SCH" in their names, so there is room for confusion.
> >"isch" makes it clearer that we are talking about the Intel ones.
> >
>
--
Intel Open Source Technology Centre
http://oss.intel.com/
next prev parent reply other threads:[~2010-02-23 9:40 UTC|newest]
Thread overview: 73+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-11 10:24 [PATCH 0/3] Add Intel SCH GPIO driver Denis Turischev
2010-02-11 10:26 ` [PATCH 1/3] MFD: introduce lpc_sch for Intel SCH LPC bridge Denis Turischev
2010-02-11 10:26 ` Denis Turischev
2010-02-16 10:08 ` Samuel Ortiz
2010-02-16 10:08 ` Samuel Ortiz
2010-02-16 13:59 ` Pan, Jacob jun
2010-02-16 13:59 ` Pan, Jacob jun
2010-02-16 15:45 ` Jean Delvare
2010-02-16 17:19 ` Pan, Jacob jun
2010-02-16 17:19 ` Pan, Jacob jun
2010-02-16 17:29 ` Jean Delvare
2010-02-16 17:29 ` Jean Delvare
2010-02-16 19:57 ` David Brownell
2010-02-16 19:57 ` David Brownell
2010-02-16 21:49 ` Jean Delvare
2010-02-16 21:49 ` Jean Delvare
2010-02-17 10:03 ` Denis Turischev
2010-02-17 10:03 ` Denis Turischev
2010-02-17 10:44 ` Jean Delvare
2010-02-17 10:44 ` Jean Delvare
2010-02-17 12:35 ` Mike Rapoport
2010-02-17 12:35 ` Mike Rapoport
2010-02-17 14:37 ` Samuel Ortiz
2010-02-17 14:37 ` Samuel Ortiz
2010-02-18 17:42 ` [PATCH v2 " Denis Turischev
2010-02-18 17:42 ` Denis Turischev
2010-02-18 17:45 ` Randy Dunlap
2010-02-18 17:45 ` Randy Dunlap
2010-02-18 18:01 ` [PATCH v3 " Denis Turischev
2010-02-18 18:01 ` Denis Turischev
2010-02-18 18:08 ` Randy Dunlap
2010-02-18 18:08 ` Randy Dunlap
2010-02-19 10:30 ` Samuel Ortiz
2010-02-19 10:30 ` Samuel Ortiz
2010-02-23 8:26 ` Jean Delvare
2010-02-23 8:26 ` Jean Delvare
2010-02-23 9:25 ` Denis Turischev
2010-02-23 9:25 ` Denis Turischev
2010-02-23 9:41 ` Samuel Ortiz [this message]
2010-02-23 9:41 ` Samuel Ortiz
2010-02-11 10:28 ` [PATCH 2/3] i2c: convert i2c-isch to platform_device Denis Turischev
2010-02-11 10:28 ` Denis Turischev
2010-02-17 15:42 ` [PATCH v2 " Denis Turischev
2010-02-19 10:33 ` Samuel Ortiz
2010-02-19 10:33 ` Samuel Ortiz
2010-02-21 12:46 ` [PATCH v3 " Denis Turischev
2010-02-21 12:46 ` Denis Turischev
2010-02-23 7:00 ` Mike Rapoport
2010-02-23 7:00 ` Mike Rapoport
2010-02-23 8:12 ` Jean Delvare
2010-02-23 8:12 ` Jean Delvare
2010-02-23 8:20 ` Samuel Ortiz
2010-02-23 8:20 ` Samuel Ortiz
2010-02-23 8:24 ` Jean Delvare
2010-02-23 8:24 ` Jean Delvare
2010-02-28 19:00 ` Samuel Ortiz
2010-03-01 16:59 ` [PATCH v4 " Denis Turischev
2010-03-01 16:59 ` Denis Turischev
2010-03-02 10:06 ` Samuel Ortiz
2010-03-02 10:06 ` Samuel Ortiz
2010-02-11 10:28 ` [PATCH 3/3] gpio: add Intel SCH GPIO controller driver Denis Turischev
2010-02-11 10:28 ` Denis Turischev
2010-02-17 15:39 ` [PATCH v2 " Denis Turischev
2010-02-21 12:50 ` [PATCH v3 " Denis Turischev
2010-02-21 19:12 ` David Brownell
2010-02-24 6:49 ` Mike Rapoport
2010-03-01 18:09 ` Len Brown
2010-03-01 19:50 ` Alan Cox
2010-03-02 6:42 ` Mike Rapoport
2010-03-02 9:29 ` Denis Turischev
2010-02-28 19:01 ` Samuel Ortiz
2010-03-01 17:02 ` [PATCH v4 " Denis Turischev
2010-03-02 10:09 ` Samuel Ortiz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100223094141.GC3550@sortiz.org \
--to=sameo@linux.intel.com \
--cc=dbrownell@users.sourceforge.net \
--cc=denis@compulab.co.il \
--cc=khali@linux-fr.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=randy.dunlap@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.