* + vfs-clarify-that-nonseekable_open-will-never-fail.patch added to -mm tree
@ 2010-02-22 20:55 akpm
0 siblings, 0 replies; only message in thread
From: akpm @ 2010-02-22 20:55 UTC (permalink / raw)
To: mm-commits; +Cc: dmitry.torokhov, arnd, dtor, jkacur, viro
The patch titled
vfs: clarify that nonseekable_open() will never fail
has been added to the -mm tree. Its filename is
vfs-clarify-that-nonseekable_open-will-never-fail.patch
Before you just go and hit "reply", please:
a) Consider who else should be cc'ed
b) Prefer to cc a suitable mailing list as well
c) Ideally: find the original patch on the mailing list and do a
reply-to-all to that, adding suitable additional cc's
*** Remember to use Documentation/SubmitChecklist when testing your code ***
See http://userweb.kernel.org/~akpm/stuff/added-to-mm.txt to find
out what to do about this
The current -mm tree may be found at http://userweb.kernel.org/~akpm/mmotm/
------------------------------------------------------
Subject: vfs: clarify that nonseekable_open() will never fail
From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Signed-off-by: Dmitry Torokhov <dtor@mail.ru>
Acked-by: Arnd Bergmann <arnd@arndb.de>
Acked-by: John Kacur <jkacur@redhat.com>
Cc: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---
fs/open.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff -puN fs/open.c~vfs-clarify-that-nonseekable_open-will-never-fail fs/open.c
--- a/fs/open.c~vfs-clarify-that-nonseekable_open-will-never-fail
+++ a/fs/open.c
@@ -1201,7 +1201,9 @@ EXPORT_SYMBOL(generic_file_open);
/*
* This is used by subsystems that don't want seekable
- * file descriptors
+ * file descriptors. The function is not supposed to ever fail, the only
+ * reason it returns an 'int' and not 'void' is so that it can be plugged
+ * directly into file_operations structure.
*/
int nonseekable_open(struct inode *inode, struct file *filp)
{
_
Patches currently in -mm which might be from dmitry.torokhov@gmail.com are
linux-next.patch
revert-input-wistron_btns-switch-to-using-sparse-keymap-library.patch
vfs-clarify-that-nonseekable_open-will-never-fail.patch
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2010-02-22 20:56 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2010-02-22 20:55 + vfs-clarify-that-nonseekable_open-will-never-fail.patch added to -mm tree akpm
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.