* [PATCH] netdev: use list_first_entry macro
@ 2010-02-25 0:01 Stephen Hemminger
2010-02-26 12:20 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Stephen Hemminger @ 2010-02-25 0:01 UTC (permalink / raw)
To: David Miller; +Cc: netdev
Use list_first_entry macro; no longer any need to use
'next' directly in list to find first entry.
Signed-off-by: Stephen Hemminger <shemminger@vyatta.com>
--- a/net/core/dev.c 2010-02-24 15:14:47.502112037 -0800
+++ b/net/core/dev.c 2010-02-24 15:15:45.201861020 -0800
@@ -3018,7 +3018,7 @@ static void net_rx_action(struct softirq
* entries to the tail of this list, and only ->poll()
* calls can remove this head entry from the list.
*/
- n = list_entry(list->next, struct napi_struct, poll_list);
+ n = list_first_entry(list, struct napi_struct, poll_list);
have = netpoll_poll_lock(n);
@@ -4882,7 +4882,7 @@ static void rollback_registered_many(str
}
/* Process any work delayed until the end of the batch */
- dev = list_entry(head->next, struct net_device, unreg_list);
+ dev = list_first_entry(head, struct net_device, unreg_list);
call_netdevice_notifiers(NETDEV_UNREGISTER_BATCH, dev);
synchronize_net();
@@ -5268,7 +5268,7 @@ void netdev_run_todo(void)
while (!list_empty(&list)) {
struct net_device *dev
- = list_entry(list.next, struct net_device, todo_list);
+ = list_first_entry(&list, struct net_device, todo_list);
list_del(&dev->todo_list);
if (unlikely(dev->reg_state != NETREG_UNREGISTERING)) {
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] netdev: use list_first_entry macro
2010-02-25 0:01 [PATCH] netdev: use list_first_entry macro Stephen Hemminger
@ 2010-02-26 12:20 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2010-02-26 12:20 UTC (permalink / raw)
To: shemminger; +Cc: netdev
From: Stephen Hemminger <shemminger@vyatta.com>
Date: Wed, 24 Feb 2010 16:01:38 -0800
> Use list_first_entry macro; no longer any need to use
> 'next' directly in list to find first entry.
>
> Signed-off-by: Stephen Hemminger <shemminger@vyatta.com>
Applied.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-02-26 12:19 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2010-02-25 0:01 [PATCH] netdev: use list_first_entry macro Stephen Hemminger
2010-02-26 12:20 ` David Miller
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.