All of lore.kernel.org
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: roel.kluin@gmail.com
Cc: herbert@gondor.apana.org.au, mikpe@it.uu.se,
	linux-crypto@vger.kernel.org, akpm@linux-foundation.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] sha: prevent removal of memset as dead store in sha1_update()
Date: Thu, 25 Feb 2010 07:17:59 -0800 (PST)	[thread overview]
Message-ID: <20100225.071759.98314060.davem@davemloft.net> (raw)
In-Reply-To: <4B8692E3.9030509@gmail.com>

From: Roel Kluin <roel.kluin@gmail.com>
Date: Thu, 25 Feb 2010 16:10:27 +0100

> Due to optimization A call to memset() may be removed as a dead store when
> the buffer is not used after its value is overwritten.
> 
> Signed-off-by: Roel Kluin <roel.kluin@gmail.com>

Solution is wrong and overkill in my mind.

It's overkill because the whole reason it's using a stack buffer is to
avoid the overhead of a kmalloc() call.

And it's wrong because the reason the memset() is there seems to be
to clear out key information that might exist kernel stack so that
it's more difficult for rogue code to get at things.



  reply	other threads:[~2010-02-25 15:17 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-02-25 15:10 [PATCH] sha: prevent removal of memset as dead store in sha1_update() Roel Kluin
2010-02-25 15:10 ` Roel Kluin
2010-02-25 15:17 ` David Miller [this message]
2010-02-25 15:31   ` roel kluin
2010-02-25 15:31     ` roel kluin
2010-02-25 15:37     ` David Miller
2010-02-26 11:55     ` Andi Kleen
2010-02-26 14:20       ` Mikael Pettersson
2010-02-26 15:46         ` Mikael Pettersson
2010-02-26 15:55           ` Andi Kleen
2010-02-25 15:56 ` Mikael Pettersson
2010-02-25 16:16   ` Pekka Enberg
2010-02-25 16:16     ` Pekka Enberg
2010-02-25 16:29     ` Mikael Pettersson
2010-02-25 16:29       ` Mikael Pettersson
2010-02-25 16:33     ` roel kluin
2010-02-25 16:33       ` roel kluin
2010-02-25 17:06       ` roel kluin
2010-02-25 17:06         ` roel kluin
2010-02-25 16:33   ` Brian Gerst
2010-02-25 16:33     ` Brian Gerst
2010-02-25 17:09     ` Mikael Pettersson
2010-02-25 17:09       ` Mikael Pettersson
2010-02-25 17:32       ` Brian Gerst
2010-02-25 17:32         ` Brian Gerst
2010-02-25 19:47         ` Roel Kluin
2010-02-25 20:43           ` Roel Kluin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100225.071759.98314060.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=akpm@linux-foundation.org \
    --cc=herbert@gondor.apana.org.au \
    --cc=linux-crypto@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mikpe@it.uu.se \
    --cc=roel.kluin@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.