From: Simon Kagstrom <simon.kagstrom@netinsight.net>
To: "Pádraig Brady" <P@draigBrady.com>
Cc: Wim Van Sebroeck <wim@iguana.be>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] iTCO_wdt: Don't double the requested timeout
Date: Thu, 25 Feb 2010 08:45:35 +0100 [thread overview]
Message-ID: <20100225084535.4658cbf9@marrow.netinsight.se> (raw)
In-Reply-To: <4B854F58.4050907@draigBrady.com>
(taking back lkml on CC. The discussion is about stopping watchdogs
before rebooting).
On Wed, 24 Feb 2010 16:10:00 +0000
Pádraig Brady <P@draigBrady.com> wrote:
> > Returning to the initial issue (my patch to avoid stopping the watchdog
> > before reboot): What is the preferred behavior? I've looked in other
> > drivers, and see multiple ways being used. Some do as in my patch, some
> > leave it on unconditionally and some stop it unconditionally.
> >
> Well nowayout to me means userspace should have no way out,
> but when rebooting the system the watchdog should be reset.
> But in saying that I'm not sure what to do. At least there
> should be some way to select the operation you want above,
> so as to protect the reboot process itself.
Well, from the drives I saw that had this behavior (not that I checked
all of them), they did look at nowayout to determine whether to stop it
or not.
> In general, I wonder could an order be specified so that
> the watchdog is disabled as the very last thing by the kernel,
> right before it does the reboot?
Many other drivers use reboot notifiers, but unfortunately it seems
that these are called before device shutdown (kernel/sys.c), so it
wouldn't help here.
I guess it would be good to have defined and uniform behavior across
different watchdogs, and at least an option to specify
nowayout-also-when-rebooting.
// Simon
next prev parent reply other threads:[~2010-02-25 7:45 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-23 15:40 [PATCH] iTCO_wdt: Don't stop on shutdown with nowayout Simon Kagstrom
2010-02-23 16:24 ` Pádraig Brady
2010-02-23 17:09 ` [PATCH] iTCO_wdt: Don't double the requested timeout Pádraig Brady
2010-02-24 9:16 ` Simon Kagstrom
2010-02-24 16:18 ` Pádraig Brady
2010-04-07 16:20 ` Pádraig Brady
[not found] ` <4B84FD15.9020803@draigBrady.com>
[not found] ` <20100224124730.6958b2c0@marrow.netinsight.se>
[not found] ` <4B8545D1.8000302@draigBrady.com>
[not found] ` <20100224165526.61cdd169@marrow.netinsight.se>
[not found] ` <4B854F58.4050907@draigBrady.com>
2010-02-25 7:45 ` Simon Kagstrom [this message]
2010-02-24 6:25 ` [PATCH] iTCO_wdt: Don't stop on shutdown with nowayout Simon Kagstrom
2010-03-07 15:16 ` Wim Van Sebroeck
2010-03-08 7:51 ` Simon Kagstrom
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100225084535.4658cbf9@marrow.netinsight.se \
--to=simon.kagstrom@netinsight.net \
--cc=P@draigBrady.com \
--cc=linux-kernel@vger.kernel.org \
--cc=wim@iguana.be \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.