All of lore.kernel.org
 help / color / mirror / Atom feed
From: Wim Van Sebroeck <wim@iguana.be>
To: Simon Kagstrom <simon.kagstrom@netinsight.net>
Cc: linux-kernel@vger.kernel.org, seth.heasley@intel.com
Subject: Re: [PATCH] iTCO_wdt: Don't stop on shutdown with nowayout
Date: Sun, 7 Mar 2010 16:16:56 +0100	[thread overview]
Message-ID: <20100307151656.GX7459@infomag.iguana.be> (raw)
In-Reply-To: <20100223164019.60a6de1a@marrow.netinsight.se>

Hi,

> Currently, the watchdog is turned off when the system shuts down or the
> module is unloaded. If nowayout has been selected, this makes no sense
> and fails to restart the system if it hangs during reboot, so make it
> conditional.

the nowayout option is there to make sure that the watchdog keeps running
as long as the system is running. If you however do a system shutdown (which
means that you are going to reboot your server in a controlled fasion and thus
not as result of a crash or hang-situation), then either the shutdown function
of your platform_driver or the reboot_notifier call will be executed.
In the case of a watchdog device idriver we will then stop the watchdog to
prevent reboot's during the fsck that might happen after reboot.
If you run into a reboot operation during an fsck then chances a very big that
after the reboot your system will again be rebooted during the next fsck.
To prevent this fsck-reboot-loop issue we turn of the watchdog when rebooting.

Because of this, I'm not going to apply this patch.

> We have a system which has such a hang, and therefore want the watchdog
> to be on until the bitter end.

Hmm, the correct question here should be: why do we have a hang in a clean boot.
Do you have more info on what exactly happens? This might be an initialization problem.

If we better understand what happens, then we might consider having an option to keep
the watchdog on after a reboot (which has nothing to do with the nowayout functionality imho).
or even power-on.

Kind regards,
Wim.


  parent reply	other threads:[~2010-03-07 15:17 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-02-23 15:40 [PATCH] iTCO_wdt: Don't stop on shutdown with nowayout Simon Kagstrom
2010-02-23 16:24 ` Pádraig Brady
2010-02-23 17:09   ` [PATCH] iTCO_wdt: Don't double the requested timeout Pádraig Brady
2010-02-24  9:16     ` Simon Kagstrom
2010-02-24 16:18       ` Pádraig Brady
2010-04-07 16:20         ` Pádraig Brady
     [not found]       ` <4B84FD15.9020803@draigBrady.com>
     [not found]         ` <20100224124730.6958b2c0@marrow.netinsight.se>
     [not found]           ` <4B8545D1.8000302@draigBrady.com>
     [not found]             ` <20100224165526.61cdd169@marrow.netinsight.se>
     [not found]               ` <4B854F58.4050907@draigBrady.com>
2010-02-25  7:45                 ` Simon Kagstrom
2010-02-24  6:25   ` [PATCH] iTCO_wdt: Don't stop on shutdown with nowayout Simon Kagstrom
2010-03-07 15:16 ` Wim Van Sebroeck [this message]
2010-03-08  7:51   ` Simon Kagstrom

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100307151656.GX7459@infomag.iguana.be \
    --to=wim@iguana.be \
    --cc=linux-kernel@vger.kernel.org \
    --cc=seth.heasley@intel.com \
    --cc=simon.kagstrom@netinsight.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.