Re: [PATCH] Route kbd leds through the generic leds layer (3rd version)

From: Samuel Thibault <samuel.thibault@ens-lyon.org>
To: Richard Purdie <rpurdie@rpsys.net>
Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>,
	"H. Peter Anvin" <hpa@zytor.com>, Pavel Machek <pavel@ucw.cz>,
	Alexey Dobriyan <adobriyan@gmail.com>,
	akpm@linux-foundation.org, linux-kernel@vger.kernel.org,
	alan@lxorguk.ukuu.org.uk, mgarski@post.pl,
	linux-input@vger.kernel.org, Vojtech Pavlik <vojtech@suse.cz>
Subject: Re: [PATCH] Route kbd leds through the generic leds layer (3rd version)
Date: Thu, 25 Feb 2010 22:47:59 +0100	[thread overview]
Message-ID: <20100225214759.GC9378@const.homenet.telecomitalia.it> (raw)
In-Reply-To: <1267100600.4243.13.camel@rex>

Richard Purdie, le Thu 25 Feb 2010 12:23:20 +0000, a écrit :
> The first would be the triggers themselves which are independent in
> their own right and shouldn't be too controversial.

One issue is that keyboard.c has to know whether to send input events
itself as it does now (e.g. because triggers are not compiled), or to
rely on triggers to do it for him.

> The second part would be the input LEDs themselves. My input susbsystem
> memory is fuzzy, I assume this sets a set of LEDs per input device and
> attaches the appropriate default triggers?

I would rather say that it sets a set of input devices per LED and
attaches them the appropriate default trigger.

> Is there a set of states we can detect (like raw mode) when we could
> just know to disconnect the default triggers?

What for?

Samuel