All of lore.kernel.org
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: yegor_sub1@visionsystems.de
Cc: linux-arm-kernel@lists.infradead.org, avictor.za@gmail.com,
	netdev@vger.kernel.org
Subject: Re: [PATCH][KS8695] Mark network interface as running on ifconfig up
Date: Fri, 26 Feb 2010 01:20:57 -0800 (PST)	[thread overview]
Message-ID: <20100226.012057.51272829.davem@davemloft.net> (raw)
In-Reply-To: <4B82A72E.50508@visionsystems.de>

From: Yegor Yefremov <yegor_sub1@visionsystems.de>
Date: Mon, 22 Feb 2010 16:47:58 +0100

> [KS8695] Don't call netif_carrier_off() from ndo_stop()
> 
> netif_carrier_on() and netif_carrier_off() should be called from
> link status interrupt handler
> 
> Signed-off-by: Yegor Yefremov <yegorslists@googlemail.com>

Looks good, applied.

Please do not put text you want to make it into the
commit message header line in brackets "[]", those
get removed by automated tools that apply patches
because patches are usually posted as:

Subject: [PATCH N/M] xxxx

and the GIT tools kill all the text inside of the brackets
so that the commit header properly reads "xxx"

Thanks.

WARNING: multiple messages have this Message-ID (diff)
From: davem@davemloft.net (David Miller)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH][KS8695] Mark network interface as running on ifconfig up
Date: Fri, 26 Feb 2010 01:20:57 -0800 (PST)	[thread overview]
Message-ID: <20100226.012057.51272829.davem@davemloft.net> (raw)
In-Reply-To: <4B82A72E.50508@visionsystems.de>

From: Yegor Yefremov <yegor_sub1@visionsystems.de>
Date: Mon, 22 Feb 2010 16:47:58 +0100

> [KS8695] Don't call netif_carrier_off() from ndo_stop()
> 
> netif_carrier_on() and netif_carrier_off() should be called from
> link status interrupt handler
> 
> Signed-off-by: Yegor Yefremov <yegorslists@googlemail.com>

Looks good, applied.

Please do not put text you want to make it into the
commit message header line in brackets "[]", those
get removed by automated tools that apply patches
because patches are usually posted as:

Subject: [PATCH N/M] xxxx

and the GIT tools kill all the text inside of the brackets
so that the commit header properly reads "xxx"

Thanks.

  reply	other threads:[~2010-02-26  9:20 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-02-11 11:12 [PATCH][KS8695] Mark network interface as running on ifconfig up Yegor Yefremov
2010-02-11 11:12 ` Yegor Yefremov
2010-02-17  0:06 ` David Miller
2010-02-17  0:06   ` David Miller
2010-02-22 15:47   ` Yegor Yefremov
2010-02-22 15:47     ` Yegor Yefremov
2010-02-26  9:20     ` David Miller [this message]
2010-02-26  9:20       ` David Miller
  -- strict thread matches above, loose matches on Subject: below --
2010-02-11  9:05 Yegor Yefremov
2010-02-11 10:56 ` Uwe Kleine-König

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100226.012057.51272829.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=avictor.za@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=netdev@vger.kernel.org \
    --cc=yegor_sub1@visionsystems.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.