From: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
To: Sheng Yang <sheng@linux.intel.com>
Cc: Keir Fraser <keir.fraser@eu.citrix.com>,
Jeremy Fitzhardinge <jeremy.fitzhardinge@citrix.com>,
Ian Pratt <Ian.Pratt@eu.citrix.com>,
Ian Campbell <Ian.Campbell@citrix.com>,
Stefano Stabellini <stefano.stabellini@eu.citrix.com>,
xen-devel <xen-devel@lists.xensource.com>,
linux-kernel@vger.kernel.org
Subject: Re: [LKML] [PATCH 7/7] xen: Enable grant table and xenbus for PV extension of HVM
Date: Tue, 2 Mar 2010 08:41:27 -0500 [thread overview]
Message-ID: <20100302134127.GA25893@phenom.dumpdata.com> (raw)
In-Reply-To: <201003020921.43398.sheng@linux.intel.com>
On Tue, Mar 02, 2010 at 09:21:43AM +0800, Sheng Yang wrote:
> On Tuesday 02 March 2010 01:38:58 Konrad Rzeszutek Wilk wrote:
> > > +/* The region reserved by QEmu for Xen platform device */
> > > +#define GNTTAB_START 0xf2000000ul
> > > +#define GNTTAB_SIZE 0x20000ul
> >
> > I thought that in the earlier review you said:
> >
> > "> > +#define GNTTAB_START 0xfbfe0000ul
> >
> > > > +#define GNTTAB_SIZE 0x20000ul
> > >
> > > Is it possible that there would be a PCI device that would be
> > > passed in the guest that would conflict with the above mentioned
> > > E820 region?
> >
> > I would change them to a dedicated PCI MMIO address in the next version.
> > Thanks.
> >
> > "
> > ?
>
> And yes, this is the dedicated PCI MMIO address I mentioned.. I would update
> the comments to get it more clear.
>
> I don't think it's very clear solution, because the real good way to do this
> is probe pci device and find out with one is the platform pci device then use
> it. But the grant table initialization is quite earlier compared to the
> possible probing now... I hardcode the position now, and hunting for a better
Would it be possible to move the grant table initialization to later
phase? Past the PCI loading/initialization?
> idea.
>
> Comments?
>
> --
> regards
> Yang, Sheng
>
next prev parent reply other threads:[~2010-03-02 14:05 UTC|newest]
Thread overview: 53+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-01 9:38 [PATCH 0/7][v4] PV extension of HVM (Hybrid) for Xen Sheng Yang
2010-03-01 9:38 ` [PATCH 1/7] xen: add support for hvm_op Sheng Yang
2010-03-01 9:38 ` Sheng Yang
2010-03-01 9:38 ` [PATCH 2/7] xen: Import cpuid.h from Xen Sheng Yang
2010-03-01 9:38 ` [PATCH 3/7] xen/hvm: Xen PV extension of HVM initialization Sheng Yang
2010-03-02 1:02 ` [Xen-devel] " Jeremy Fitzhardinge
2010-03-02 1:02 ` Jeremy Fitzhardinge
2010-03-02 1:38 ` [Xen-devel] " Sheng Yang
2010-03-02 1:38 ` Sheng Yang
2010-03-02 1:43 ` Jeremy Fitzhardinge
2010-03-02 9:22 ` Ian Campbell
2010-03-02 20:17 ` Jeremy Fitzhardinge
2010-03-02 20:17 ` Jeremy Fitzhardinge
2010-03-03 11:35 ` [Xen-devel] " Stefano Stabellini
2010-03-03 11:35 ` Stefano Stabellini
2010-03-03 17:35 ` [Xen-devel] " Jeremy Fitzhardinge
2010-03-03 17:41 ` Stefano Stabellini
2010-03-03 17:41 ` Stefano Stabellini
2010-03-04 10:18 ` [Xen-devel] " Ian Campbell
2010-03-04 10:18 ` Ian Campbell
2010-03-01 9:38 ` [PATCH 4/7] xen: The entrance for PV extension of HVM Sheng Yang
2010-03-02 1:05 ` [Xen-devel] " Jeremy Fitzhardinge
2010-03-02 1:41 ` Sheng Yang
2010-03-01 9:38 ` [PATCH 5/7] xen: Make event channel work with " Sheng Yang
2010-03-01 9:38 ` Sheng Yang
2010-03-02 1:38 ` [Xen-devel] " Jeremy Fitzhardinge
2010-03-02 5:48 ` Sheng Yang
2010-03-03 18:31 ` Jeremy Fitzhardinge
2010-03-04 5:37 ` Sheng Yang
2010-03-04 5:37 ` Sheng Yang
2010-03-04 11:58 ` [Xen-devel] " Stefano Stabellini
2010-03-04 11:58 ` Stefano Stabellini
2010-03-08 22:31 ` [Xen-devel] " Jeremy Fitzhardinge
2010-03-08 22:31 ` Jeremy Fitzhardinge
2010-03-01 9:38 ` [PATCH 6/7] xen: Unified checking for Xen of PV drivers to xenbus_register_frontend() Sheng Yang
2010-03-02 1:45 ` [Xen-devel] " Jeremy Fitzhardinge
2010-03-01 9:38 ` [PATCH 7/7] xen: Enable grant table and xenbus for PV extension of HVM Sheng Yang
2010-03-01 17:38 ` [LKML] " Konrad Rzeszutek Wilk
2010-03-01 17:38 ` Konrad Rzeszutek Wilk
2010-03-02 1:13 ` Sheng Yang
2010-03-02 1:13 ` Sheng Yang
2010-03-02 1:21 ` Sheng Yang
2010-03-02 1:21 ` Sheng Yang
2010-03-02 13:41 ` Konrad Rzeszutek Wilk [this message]
2010-03-02 14:09 ` Ian Campbell
2010-03-02 14:09 ` Ian Campbell
2010-03-02 0:42 ` [Xen-devel] [PATCH 0/7][v4] PV extension of HVM (Hybrid) for Xen Jeremy Fitzhardinge
2010-03-02 1:26 ` Sheng Yang
2010-03-02 1:32 ` Jeremy Fitzhardinge
2010-03-02 1:32 ` Jeremy Fitzhardinge
2010-03-02 1:34 ` [Xen-devel] " Sheng Yang
2010-03-02 3:20 ` Dong, Eddie
2010-03-02 3:20 ` Dong, Eddie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100302134127.GA25893@phenom.dumpdata.com \
--to=konrad.wilk@oracle.com \
--cc=Ian.Campbell@citrix.com \
--cc=Ian.Pratt@eu.citrix.com \
--cc=jeremy.fitzhardinge@citrix.com \
--cc=keir.fraser@eu.citrix.com \
--cc=linux-kernel@vger.kernel.org \
--cc=sheng@linux.intel.com \
--cc=stefano.stabellini@eu.citrix.com \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.