From: Sheng Yang <sheng@linux.intel.com> To: Jeremy Fitzhardinge <jeremy@goop.org> Cc: Keir Fraser <keir.fraser@eu.citrix.com>, Jeremy Fitzhardinge <jeremy.fitzhardinge@citrix.com>, Ian Pratt <Ian.Pratt@eu.citrix.com>, linux-kernel@vger.kernel.org, "xen-devel" <xen-devel@lists.xensource.com>, Ian Campbell <Ian.Campbell@citrix.com>, Stefano Stabellini <stefano.stabellini@eu.citrix.com> Subject: Re: [Xen-devel] [PATCH 5/7] xen: Make event channel work with PV extension of HVM Date: Thu, 4 Mar 2010 13:37:26 +0800 [thread overview] Message-ID: <201003041337.26229.sheng@linux.intel.com> (raw) In-Reply-To: <4B8C6C0D.3070005@goop.org> On Tuesday 02 March 2010 09:38:21 Jeremy Fitzhardinge wrote: > On 03/01/2010 01:38 AM, Sheng Yang wrote: > > + > > + x86_platform.calibrate_tsc = xen_tsc_khz; > > + x86_platform.get_wallclock = xen_get_wallclock; > > + x86_platform.set_wallclock = xen_set_wallclock; > > + > > + pv_apic_ops = xen_apic_ops; > > +#ifdef CONFIG_X86_LOCAL_APIC > > + /* > > + * set up the basic apic ops. > > + */ > > + set_xen_basic_apic_ops(); > > + apic->write = xen_hvm_pv_evtchn_apic_write; > > I'd just change the xen_apic_write to remove the WARN_ON, since you > don't seem to care about it either. So which code base I should make these patches against? We expect the patchset can be accepted in the Linux upstream soon after you pick it up. > > > > > - exit_idle(); > > - irq_enter(); > > + /* > > + * If is PV featured HVM, these have already been done > > + */ > > + if (likely(!xen_hvm_pv_evtchn_enabled())) { > > + exit_idle(); > > + irq_enter(); > > + } > > In that case, rather than putting this conditional in the hot path, make > an inner __xen_evtchn_do_upcall which is wrapped by the PV and HVM > variants which do the appropriate things. (And drop the pt_regs arg, I > think.) Seems we still need pt_regs to for handle_irq()? -- regards Yang, Sheng
WARNING: multiple messages have this Message-ID (diff)
From: Sheng Yang <sheng@linux.intel.com> To: Jeremy Fitzhardinge <jeremy@goop.org> Cc: xen-devel <xen-devel@lists.xensource.com>, Ian Campbell <Ian.Campbell@citrix.com>, Stefano Stabellini <stefano.stabellini@eu.citrix.com>, linux-kernel@vger.kernel.org, Ian Pratt <Ian.Pratt@eu.citrix.com>, Jeremy Fitzhardinge <jeremy.fitzhardinge@citrix.com>, Keir Fraser <keir.fraser@eu.citrix.com> Subject: Re: [PATCH 5/7] xen: Make event channel work with PV extension of HVM Date: Thu, 4 Mar 2010 13:37:26 +0800 [thread overview] Message-ID: <201003041337.26229.sheng@linux.intel.com> (raw) In-Reply-To: <4B8C6C0D.3070005@goop.org> On Tuesday 02 March 2010 09:38:21 Jeremy Fitzhardinge wrote: > On 03/01/2010 01:38 AM, Sheng Yang wrote: > > + > > + x86_platform.calibrate_tsc = xen_tsc_khz; > > + x86_platform.get_wallclock = xen_get_wallclock; > > + x86_platform.set_wallclock = xen_set_wallclock; > > + > > + pv_apic_ops = xen_apic_ops; > > +#ifdef CONFIG_X86_LOCAL_APIC > > + /* > > + * set up the basic apic ops. > > + */ > > + set_xen_basic_apic_ops(); > > + apic->write = xen_hvm_pv_evtchn_apic_write; > > I'd just change the xen_apic_write to remove the WARN_ON, since you > don't seem to care about it either. So which code base I should make these patches against? We expect the patchset can be accepted in the Linux upstream soon after you pick it up. > > > > > - exit_idle(); > > - irq_enter(); > > + /* > > + * If is PV featured HVM, these have already been done > > + */ > > + if (likely(!xen_hvm_pv_evtchn_enabled())) { > > + exit_idle(); > > + irq_enter(); > > + } > > In that case, rather than putting this conditional in the hot path, make > an inner __xen_evtchn_do_upcall which is wrapped by the PV and HVM > variants which do the appropriate things. (And drop the pt_regs arg, I > think.) Seems we still need pt_regs to for handle_irq()? -- regards Yang, Sheng
next prev parent reply other threads:[~2010-03-04 5:36 UTC|newest] Thread overview: 53+ messages / expand[flat|nested] mbox.gz Atom feed top 2010-03-01 9:38 [PATCH 0/7][v4] PV extension of HVM (Hybrid) for Xen Sheng Yang 2010-03-01 9:38 ` [PATCH 1/7] xen: add support for hvm_op Sheng Yang 2010-03-01 9:38 ` Sheng Yang 2010-03-01 9:38 ` [PATCH 2/7] xen: Import cpuid.h from Xen Sheng Yang 2010-03-01 9:38 ` [PATCH 3/7] xen/hvm: Xen PV extension of HVM initialization Sheng Yang 2010-03-02 1:02 ` [Xen-devel] " Jeremy Fitzhardinge 2010-03-02 1:02 ` Jeremy Fitzhardinge 2010-03-02 1:38 ` [Xen-devel] " Sheng Yang 2010-03-02 1:38 ` Sheng Yang 2010-03-02 1:43 ` Jeremy Fitzhardinge 2010-03-02 9:22 ` Ian Campbell 2010-03-02 20:17 ` Jeremy Fitzhardinge 2010-03-02 20:17 ` Jeremy Fitzhardinge 2010-03-03 11:35 ` [Xen-devel] " Stefano Stabellini 2010-03-03 11:35 ` Stefano Stabellini 2010-03-03 17:35 ` [Xen-devel] " Jeremy Fitzhardinge 2010-03-03 17:41 ` Stefano Stabellini 2010-03-03 17:41 ` Stefano Stabellini 2010-03-04 10:18 ` [Xen-devel] " Ian Campbell 2010-03-04 10:18 ` Ian Campbell 2010-03-01 9:38 ` [PATCH 4/7] xen: The entrance for PV extension of HVM Sheng Yang 2010-03-02 1:05 ` [Xen-devel] " Jeremy Fitzhardinge 2010-03-02 1:41 ` Sheng Yang 2010-03-01 9:38 ` [PATCH 5/7] xen: Make event channel work with " Sheng Yang 2010-03-01 9:38 ` Sheng Yang 2010-03-02 1:38 ` [Xen-devel] " Jeremy Fitzhardinge 2010-03-02 5:48 ` Sheng Yang 2010-03-03 18:31 ` Jeremy Fitzhardinge 2010-03-04 5:37 ` Sheng Yang [this message] 2010-03-04 5:37 ` Sheng Yang 2010-03-04 11:58 ` [Xen-devel] " Stefano Stabellini 2010-03-04 11:58 ` Stefano Stabellini 2010-03-08 22:31 ` [Xen-devel] " Jeremy Fitzhardinge 2010-03-08 22:31 ` Jeremy Fitzhardinge 2010-03-01 9:38 ` [PATCH 6/7] xen: Unified checking for Xen of PV drivers to xenbus_register_frontend() Sheng Yang 2010-03-02 1:45 ` [Xen-devel] " Jeremy Fitzhardinge 2010-03-01 9:38 ` [PATCH 7/7] xen: Enable grant table and xenbus for PV extension of HVM Sheng Yang 2010-03-01 17:38 ` [LKML] " Konrad Rzeszutek Wilk 2010-03-01 17:38 ` Konrad Rzeszutek Wilk 2010-03-02 1:13 ` Sheng Yang 2010-03-02 1:13 ` Sheng Yang 2010-03-02 1:21 ` Sheng Yang 2010-03-02 1:21 ` Sheng Yang 2010-03-02 13:41 ` Konrad Rzeszutek Wilk 2010-03-02 14:09 ` Ian Campbell 2010-03-02 14:09 ` Ian Campbell 2010-03-02 0:42 ` [Xen-devel] [PATCH 0/7][v4] PV extension of HVM (Hybrid) for Xen Jeremy Fitzhardinge 2010-03-02 1:26 ` Sheng Yang 2010-03-02 1:32 ` Jeremy Fitzhardinge 2010-03-02 1:32 ` Jeremy Fitzhardinge 2010-03-02 1:34 ` [Xen-devel] " Sheng Yang 2010-03-02 3:20 ` Dong, Eddie 2010-03-02 3:20 ` Dong, Eddie
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=201003041337.26229.sheng@linux.intel.com \ --to=sheng@linux.intel.com \ --cc=Ian.Campbell@citrix.com \ --cc=Ian.Pratt@eu.citrix.com \ --cc=jeremy.fitzhardinge@citrix.com \ --cc=jeremy@goop.org \ --cc=keir.fraser@eu.citrix.com \ --cc=linux-kernel@vger.kernel.org \ --cc=stefano.stabellini@eu.citrix.com \ --cc=xen-devel@lists.xensource.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.