[patch] cassini: fix off by one

[patch] cassini: fix off by one

[Dan Carpenter]

There are only 6 link_modes.

Signed-off-by: Dan Carpenter <error27@gmail.com>

diff --git a/drivers/net/cassini.c b/drivers/net/cassini.c
index 7cbcfb0..9bd155e 100644
--- a/drivers/net/cassini.c
+++ b/drivers/net/cassini.c
@@ -5072,7 +5072,7 @@ static int __devinit cas_init_one(struct pci_dev *pdev,
 	INIT_WORK(&cp->reset_task, cas_reset_task);
 
 	/* Default link parameters */
-	if (link_mode >= 0 && link_mode <= 6)
+	if (link_mode >= 0 && link_mode < 6)
 		cp->link_cntl = link_modes[link_mode];
 	else
 		cp->link_cntl = BMCR_ANENABLE;

[patch] cassini: fix off by one

[Dan Carpenter]

There are only 6 link_modes.

Signed-off-by: Dan Carpenter <error27@gmail.com>

diff --git a/drivers/net/cassini.c b/drivers/net/cassini.c
index 7cbcfb0..9bd155e 100644
--- a/drivers/net/cassini.c
+++ b/drivers/net/cassini.c
@@ -5072,7 +5072,7 @@ static int __devinit cas_init_one(struct pci_dev *pdev,
 	INIT_WORK(&cp->reset_task, cas_reset_task);
 
 	/* Default link parameters */
-	if (link_mode >= 0 && link_mode <= 6)
+	if (link_mode >= 0 && link_mode < 6)
 		cp->link_cntl = link_modes[link_mode];
 	else
 		cp->link_cntl = BMCR_ANENABLE;

Re: [patch] cassini: fix off by one

[David Miller]

From: Dan Carpenter <error27@gmail.com>
Date: Wed, 3 Mar 2010 11:22:41 +0300

> There are only 6 link_modes.
> 
> Signed-off-by: Dan Carpenter <error27@gmail.com>

Applied.

Re: [patch] cassini: fix off by one

[David Miller]

From: Dan Carpenter <error27@gmail.com>
Date: Wed, 3 Mar 2010 11:22:41 +0300

> There are only 6 link_modes.
> 
> Signed-off-by: Dan Carpenter <error27@gmail.com>

Applied.

Re: [patch] cassini: fix off by one

[Jaswinder Singh Rajput]

Hello Dave and Dan,

On Wed, Mar 3, 2010 at 2:37 PM, David Miller <davem@davemloft.net> wrote:
> From: Dan Carpenter <error27@gmail.com>
> Date: Wed, 3 Mar 2010 11:22:41 +0300
>
>> There are only 6 link_modes.
>>
>> Signed-off-by: Dan Carpenter <error27@gmail.com>
>
> Applied.

I am curious should we add these kind of email address in git log.
error27 seems error to me ;-)

Can we make Signed-off address little bit more sensible.

Thanks,
--
Jaswinder

Re: [patch] cassini: fix off by one

[David Miller]

From: Jaswinder Singh Rajput <jaswinderlinux@gmail.com>
Date: Wed, 3 Mar 2010 20:40:18 +0530

> Hello Dave and Dan,
> 
> On Wed, Mar 3, 2010 at 2:37 PM, David Miller <davem@davemloft.net> wrote:
>> From: Dan Carpenter <error27@gmail.com>
>> Date: Wed, 3 Mar 2010 11:22:41 +0300
>>
>>> There are only 6 link_modes.
>>>
>>> Signed-off-by: Dan Carpenter <error27@gmail.com>
>>
>> Applied.
> 
> I am curious should we add these kind of email address in git log.
> error27 seems error to me ;-)
> 
> Can we make Signed-off address little bit more sensible.

Some people have silly email addresses, that is their choice.

I can't see any reason to apply censorship to an email address
just because the character sequences in it have some kind of
meaning.

The email address I was using up until 6 or 7 years ago used a host
name that meant "shit" in the Polish languange.

Maybe I should have been censored too?

Re: [patch] cassini: fix off by one

[David Miller]

From: Jaswinder Singh Rajput <jaswinderlinux@gmail.com>
Date: Wed, 3 Mar 2010 20:40:18 +0530

> Hello Dave and Dan,
> 
> On Wed, Mar 3, 2010 at 2:37 PM, David Miller <davem@davemloft.net> wrote:
>> From: Dan Carpenter <error27@gmail.com>
>> Date: Wed, 3 Mar 2010 11:22:41 +0300
>>
>>> There are only 6 link_modes.
>>>
>>> Signed-off-by: Dan Carpenter <error27@gmail.com>
>>
>> Applied.
> 
> I am curious should we add these kind of email address in git log.
> error27 seems error to me ;-)
> 
> Can we make Signed-off address little bit more sensible.

Some people have silly email addresses, that is their choice.

I can't see any reason to apply censorship to an email address
just because the character sequences in it have some kind of
meaning.

The email address I was using up until 6 or 7 years ago used a host
name that meant "shit" in the Polish languange.

Maybe I should have been censored too?

Re: [patch] cassini: fix off by one

[Jaswinder Singh Rajput]

Hello Dave and Dan,

On Wed, Mar 3, 2010 at 2:37 PM, David Miller <davem@davemloft.net> wrote:
> From: Dan Carpenter <error27@gmail.com>
> Date: Wed, 3 Mar 2010 11:22:41 +0300
>
>> There are only 6 link_modes.
>>
>> Signed-off-by: Dan Carpenter <error27@gmail.com>
>
> Applied.

I am curious should we add these kind of email address in git log.
error27 seems error to me ;-)

Can we make Signed-off address little bit more sensible.

Thanks,
--
Jaswinder