[PATCH] Reduce ACPI resource conflict message to KERN_INFO

[PATCH] Reduce ACPI resource conflict message to KERN_INFO

[Chase Douglas]

From: Chase Douglas <chase.douglas@canonical.com>

By default, ACPI resource conflict messages are logged at level
KERN_ERR. This is a rather high level for a message that is more a
warning than an indication of a real kernel error. Also, KERN_ERR level
messages can appear over some boot splash screens, and this message is
not serious enough to warrant such treatment. Thus, the log level has
been reduced to KERN_INFO.

Signed-off-by: Chase Douglas <chase.douglas@canonical.com>
---
 drivers/acpi/osl.c |    4 +---
 1 files changed, 1 insertions(+), 3 deletions(-)

diff --git a/drivers/acpi/osl.c b/drivers/acpi/osl.c
index 02e8464..9689b68 100644
--- a/drivers/acpi/osl.c
+++ b/drivers/acpi/osl.c
@@ -1151,11 +1151,9 @@ int acpi_check_resource_conflict(const struct resource *res)
 
 	if (clash) {
 		if (acpi_enforce_resources != ENFORCE_RESOURCES_NO) {
-			printk("%sACPI: %s resource %s [0x%llx-0x%llx]"
+			printk(KERN_INFO "ACPI: %s resource %s [0x%llx-0x%llx]"
 			       " conflicts with ACPI region %s"
 			       " [0x%llx-0x%llx]\n",
-			       acpi_enforce_resources == ENFORCE_RESOURCES_LAX
-			       ? KERN_WARNING : KERN_ERR,
 			       ioport ? "I/O" : "Memory", res->name,
 			       (long long) res->start, (long long) res->end,
 			       res_list_elem->name,
-- 
1.6.3.3

Re: [PATCH] Reduce ACPI resource conflict message to KERN_INFO

[Bjorn Helgaas]

On Tuesday 02 March 2010 02:09:12 pm Chase Douglas wrote:
> -			printk("%sACPI: %s resource %s [0x%llx-0x%llx]"
> +			printk(KERN_INFO "ACPI: %s resource %s [0x%llx-0x%llx]"
>  			       " conflicts with ACPI region %s"
>  			       " [0x%llx-0x%llx]\n",
> -			       acpi_enforce_resources == ENFORCE_RESOURCES_LAX
> -			       ? KERN_WARNING : KERN_ERR,
>  			       ioport ? "I/O" : "Memory", res->name,
>  			       (long long) res->start, (long long) res->end,
>  			       res_list_elem->name,

Since you're touching this anyway, can you convert this to use %pR?

Bjorn

Re: [PATCH] Reduce ACPI resource conflict message to KERN_INFO

[Chase Douglas]

On Tue, 2010-03-02 at 16:14 -0700, Bjorn Helgaas wrote:
> On Tuesday 02 March 2010 02:09:12 pm Chase Douglas wrote:
> > -			printk("%sACPI: %s resource %s [0x%llx-0x%llx]"
> > +			printk(KERN_INFO "ACPI: %s resource %s [0x%llx-0x%llx]"
> >  			       " conflicts with ACPI region %s"
> >  			       " [0x%llx-0x%llx]\n",
> > -			       acpi_enforce_resources == ENFORCE_RESOURCES_LAX
> > -			       ? KERN_WARNING : KERN_ERR,
> >  			       ioport ? "I/O" : "Memory", res->name,
> >  			       (long long) res->start, (long long) res->end,
> >  			       res_list_elem->name,
> 
> Since you're touching this anyway, can you convert this to use %pR?

I see the potential usage of %p, but is the 'R' a typo? I haven't found
it in man 3 fprintf nor in a google search.

Thanks,
Chase

Re: [PATCH] Reduce ACPI resource conflict message to KERN_INFO

[Bjorn Helgaas]

On Tuesday 02 March 2010 04:45:01 pm Chase Douglas wrote:
> On Tue, 2010-03-02 at 16:14 -0700, Bjorn Helgaas wrote:
> > On Tuesday 02 March 2010 02:09:12 pm Chase Douglas wrote:
> > > -			printk("%sACPI: %s resource %s [0x%llx-0x%llx]"
> > > +			printk(KERN_INFO "ACPI: %s resource %s [0x%llx-0x%llx]"
> > >  			       " conflicts with ACPI region %s"
> > >  			       " [0x%llx-0x%llx]\n",
> > > -			       acpi_enforce_resources == ENFORCE_RESOURCES_LAX
> > > -			       ? KERN_WARNING : KERN_ERR,
> > >  			       ioport ? "I/O" : "Memory", res->name,
> > >  			       (long long) res->start, (long long) res->end,
> > >  			       res_list_elem->name,
> > 
> > Since you're touching this anyway, can you convert this to use %pR?
> 
> I see the potential usage of %p, but is the 'R' a typo? I haven't found
> it in man 3 fprintf nor in a google search.

Nope, see this description of the %p<x> kernel extensions:

http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=blob;f=lib/vsprintf.c;hb=51c24aaacaea90c8e87f1dec75a2ac7622b593f8#l915

There are several examples already in the tree, including
drivers/pci/setup-bus.c.

Bjorn