[BUG #15248] Please apply the suggested fix

[BUG #15248] Please apply the suggested fix

[Maximiliano Curia]

Hi,

My notebook has an I855GME video card, this video card is one of the affected
by the bug #15248 which produces a hard freeze shorly after the load of the i915
kernel module.

A git bisect showed that the affecting patch producing the hard freeze was:

commit b42d4c5c6a872815d711e5d51a600f5122c38eee
Author: Jesse Barnes <jbarnes@virtuousgeek.org>
Date:   Thu Sep 10 15:28:04 2009 -0700

    drm/i915: use ACPI LID status for LVDS ->detect hook
    
    We can't load or hotplug detect LVDS like we can other outputs, but if
    there's a lid device present we can use it as a proxy.  This allows the
    LFP state to be determined at ->detect time, making configurations
    requiring manual intervention today "just work" assuming the lid device
    status is correct.
    
    Signed-off-by: Jesse Barnes <jbarnes@virtuousgeek.org>
    Signed-off-by: Eric Anholt <eric@anholt.net>

Afterwards, I realized this had already been reverted in a patch present only
in git://git.kernel.org/pub/scm/linux/kernel/git/airlied/drm-2.6.git :

commit 7b9c5abee98c54f85bcc04bd4d7ec8d5094c73f4
Author: Jesse Barnes <jbarnes@virtuousgeek.org>
Date:   Fri Feb 12 09:30:00 2010 -0800

    drm/i915: give up on 8xx lid status
    
    These old machines more often than not lie about their lid state.  So
    don't use it to detect LVDS presence, but leave the event handler to
    deal with lid open/close, when we might need to reset the mode.
    
    Fixes kernel bug #15248
    
    Signed-off-by: Jesse Barnes <jbarnes@virtuousgeek.org>
    Cc: stable@kernel.org
    Signed-off-by: Eric Anholt <eric@anholt.net>

This patch is suggested as fix for #15248, but it may have got lost in the
noise.

After applying this patch (and only this patch), my computer worked perfectly
again, with kms enabled.

Please do apply this patch in the mainline kernel.

Thanks,
-- 
"The use of COBOL cripples the mind; its teaching should, therefore, be
regarded as a criminal offense." -- Edsger W. Dijkstra
Saludos /\/\ /\ >< `/

------------------------------------------------------------------------------
Download Intel&#174; Parallel Studio Eval
Try the new software tools for yourself. Speed compiling, find bugs
proactively, and fine-tune applications for parallel performance.
See why Intel Parallel Studio got high marks during beta.
http://p.sf.net/sfu/intel-sw-dev
--

[BUG #15248] Please apply the suggested fix

[Maximiliano Curia]

Hi,

My notebook has an I855GME video card, this video card is one of the affected
by the bug #15248 which produces a hard freeze shorly after the load of the i915
kernel module.

A git bisect showed that the affecting patch producing the hard freeze was:

commit b42d4c5c6a872815d711e5d51a600f5122c38eee
Author: Jesse Barnes <jbarnes@virtuousgeek.org>
Date:   Thu Sep 10 15:28:04 2009 -0700

    drm/i915: use ACPI LID status for LVDS ->detect hook
    
    We can't load or hotplug detect LVDS like we can other outputs, but if
    there's a lid device present we can use it as a proxy.  This allows the
    LFP state to be determined at ->detect time, making configurations
    requiring manual intervention today "just work" assuming the lid device
    status is correct.
    
    Signed-off-by: Jesse Barnes <jbarnes@virtuousgeek.org>
    Signed-off-by: Eric Anholt <eric@anholt.net>

Afterwards, I realized this had already been reverted in a patch present only
in git://git.kernel.org/pub/scm/linux/kernel/git/airlied/drm-2.6.git :

commit 7b9c5abee98c54f85bcc04bd4d7ec8d5094c73f4
Author: Jesse Barnes <jbarnes@virtuousgeek.org>
Date:   Fri Feb 12 09:30:00 2010 -0800

    drm/i915: give up on 8xx lid status
    
    These old machines more often than not lie about their lid state.  So
    don't use it to detect LVDS presence, but leave the event handler to
    deal with lid open/close, when we might need to reset the mode.
    
    Fixes kernel bug #15248
    
    Signed-off-by: Jesse Barnes <jbarnes@virtuousgeek.org>
    Cc: stable@kernel.org
    Signed-off-by: Eric Anholt <eric@anholt.net>

This patch is suggested as fix for #15248, but it may have got lost in the
noise.

After applying this patch (and only this patch), my computer worked perfectly
again, with kms enabled.

Please do apply this patch in the mainline kernel.

Thanks,
-- 
"The use of COBOL cripples the mind; its teaching should, therefore, be
regarded as a criminal offense." -- Edsger W. Dijkstra
Saludos /\/\ /\ >< `/