* git stash save <message>
@ 2010-03-05 12:16 Thomas Singer
2010-03-05 12:55 ` Johannes Sixt
0 siblings, 1 reply; 7+ messages in thread
From: Thomas Singer @ 2010-03-05 12:16 UTC (permalink / raw)
To: git
Where can I find information about what content in <message> is (not)
allowed? We've got a bug-report where a SmartGit user has simply entered a
minus and Git refused to work. Of course, entering just a minus is quite
useless, but we have to be able to reliable detect allowed and disallowed
messages. Should every message with a leading minus be rejected? Maybe the
best would be to add a new command line option, e.g. --message before the
<message>, so one can provide anything as message?
--
Best regards,
Thomas Singer
=============
syntevo GmbH
http://www.syntevo.com
http://blog.syntevo.com
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: git stash save <message>
2010-03-05 12:16 git stash save <message> Thomas Singer
@ 2010-03-05 12:55 ` Johannes Sixt
2010-03-05 13:29 ` Thomas Singer
0 siblings, 1 reply; 7+ messages in thread
From: Johannes Sixt @ 2010-03-05 12:55 UTC (permalink / raw)
To: Thomas Singer; +Cc: git
Thomas Singer schrieb:
> Where can I find information about what content in <message> is (not)
> allowed? We've got a bug-report where a SmartGit user has simply entered a
> minus and Git refused to work. Of course, entering just a minus is quite
> useless, but we have to be able to reliable detect allowed and disallowed
> messages.
Does SmartGit call 'git stash save' behind the scenes with the
user-supplied message? Then it should run
git stash save -- "$msg"
and you don't need to forbid anything.
-- Hannes
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: git stash save <message>
2010-03-05 12:55 ` Johannes Sixt
@ 2010-03-05 13:29 ` Thomas Singer
2010-03-05 16:14 ` [PATCH] stash: suggest the correct command line for unknown options Matthieu Moy
0 siblings, 1 reply; 7+ messages in thread
From: Thomas Singer @ 2010-03-05 13:29 UTC (permalink / raw)
To: Johannes Sixt; +Cc: git
On 05.03.2010 13:55, Johannes Sixt wrote:
> Does SmartGit call 'git stash save' behind the scenes with the
> user-supplied message? Then it should run
>
> git stash save -- "$msg"
>
> and you don't need to forbid anything.
Thank you very much, this solved the problem.
Tom
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH] stash: suggest the correct command line for unknown options.
2010-03-05 13:29 ` Thomas Singer
@ 2010-03-05 16:14 ` Matthieu Moy
2010-03-05 17:08 ` Jeff King
0 siblings, 1 reply; 7+ messages in thread
From: Matthieu Moy @ 2010-03-05 16:14 UTC (permalink / raw)
To: git, gitster; +Cc: Thomas Singer, Matthieu Moy
Signed-off-by: Matthieu Moy <Matthieu.Moy@imag.fr>
---
> > Does SmartGit call 'git stash save' behind the scenes with the
> > user-supplied message? Then it should run
> >
> > git stash save -- "$msg"
> >
> > and you don't need to forbid anything.
>
> Thank you very much, this solved the problem.
... unless one considers that the problem is that you had to ask.
Something like this should avoid others the problem.
git-stash.sh | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/git-stash.sh b/git-stash.sh
index 2d69196..cf4e673 100755
--- a/git-stash.sh
+++ b/git-stash.sh
@@ -151,6 +151,7 @@ save_stash () {
;;
-*)
echo "error: unknown option for 'stash save': $1"
+ echo " To provide a message, use 'git stash -- $1'."
usage
;;
*)
--
1.7.0.231.g9fa6.dirty
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH] stash: suggest the correct command line for unknown options.
2010-03-05 16:14 ` [PATCH] stash: suggest the correct command line for unknown options Matthieu Moy
@ 2010-03-05 17:08 ` Jeff King
2010-03-05 18:43 ` [PATCH v2] " Matthieu Moy
0 siblings, 1 reply; 7+ messages in thread
From: Jeff King @ 2010-03-05 17:08 UTC (permalink / raw)
To: Matthieu Moy; +Cc: git, gitster, Thomas Singer
On Fri, Mar 05, 2010 at 05:14:53PM +0100, Matthieu Moy wrote:
> diff --git a/git-stash.sh b/git-stash.sh
> index 2d69196..cf4e673 100755
> --- a/git-stash.sh
> +++ b/git-stash.sh
> @@ -151,6 +151,7 @@ save_stash () {
> ;;
> -*)
> echo "error: unknown option for 'stash save': $1"
> + echo " To provide a message, use 'git stash -- $1'."
Don't you mean "git stash save -- $1"?
-Peff
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH v2] stash: suggest the correct command line for unknown options.
2010-03-05 17:08 ` Jeff King
@ 2010-03-05 18:43 ` Matthieu Moy
2010-03-07 4:01 ` Junio C Hamano
0 siblings, 1 reply; 7+ messages in thread
From: Matthieu Moy @ 2010-03-05 18:43 UTC (permalink / raw)
To: git, gitster, Thomas Singer, Jeff King; +Cc: Matthieu Moy
Signed-off-by: Matthieu Moy <Matthieu.Moy@imag.fr>
---
Oups, as noticed by peff, my proposed command was wrong ...
git-stash.sh | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/git-stash.sh b/git-stash.sh
index 2d69196..aa47e54 100755
--- a/git-stash.sh
+++ b/git-stash.sh
@@ -151,6 +151,7 @@ save_stash () {
;;
-*)
echo "error: unknown option for 'stash save': $1"
+ echo " To provide a message, use git stash save -- '$1'"
usage
;;
*)
--
1.7.0.231.g9fa6.dirty
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH v2] stash: suggest the correct command line for unknown options.
2010-03-05 18:43 ` [PATCH v2] " Matthieu Moy
@ 2010-03-07 4:01 ` Junio C Hamano
0 siblings, 0 replies; 7+ messages in thread
From: Junio C Hamano @ 2010-03-07 4:01 UTC (permalink / raw)
To: Matthieu Moy; +Cc: git, Thomas Singer, Jeff King
Thanks.
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2010-03-07 4:01 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2010-03-05 12:16 git stash save <message> Thomas Singer
2010-03-05 12:55 ` Johannes Sixt
2010-03-05 13:29 ` Thomas Singer
2010-03-05 16:14 ` [PATCH] stash: suggest the correct command line for unknown options Matthieu Moy
2010-03-05 17:08 ` Jeff King
2010-03-05 18:43 ` [PATCH v2] " Matthieu Moy
2010-03-07 4:01 ` Junio C Hamano
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.