[PATCH] PM_QOS updates for 2.6.34-rc1

[PATCH] PM_QOS updates for 2.6.34-rc1

[640E9920]

The following patch series implements to following:
1) pm_qos now uses a handle based implementation.  No more string
compares while walking lists.
2) renames the exports to using more accurate names.
3) updates kernel clients of pm_qos per this change
4) added ascii interface to pmqos recognizing strings formatted in 10
charactor format "0x12345678"
5) added new pm_qos class, "system_bus_throughput"

I would like to see this series make it into 2.6.34 if its not too late. 

I was able to test it on my laptop and comments welcome.

Thank you!

--mgross

Re: [PATCH] PM_QOS updates for 2.6.34-rc1

[Pavel Machek]

On Sat 2010-03-13 16:34:25, 640E9920 wrote:
> The following patch series implements to following:
> 1) pm_qos now uses a handle based implementation.  No more string
> compares while walking lists.
> 2) renames the exports to using more accurate names.
> 3) updates kernel clients of pm_qos per this change
> 4) added ascii interface to pmqos recognizing strings formatted in 10
> charactor format "0x12345678"
> 5) added new pm_qos class, "system_bus_throughput"
> 
> I would like to see this series make it into 2.6.34 if its not too late. 

I believe it is... -rc1 is past us.

Also... the way the patches are structured... that will break bisect,
no?
									Pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

Re: [PATCH] PM_QOS updates for 2.6.34-rc1

[Pavel Machek]

On Sat 2010-03-13 16:34:25, 640E9920 wrote:
> The following patch series implements to following:
> 1) pm_qos now uses a handle based implementation.  No more string
> compares while walking lists.
> 2) renames the exports to using more accurate names.
> 3) updates kernel clients of pm_qos per this change
> 4) added ascii interface to pmqos recognizing strings formatted in 10
> charactor format "0x12345678"
> 5) added new pm_qos class, "system_bus_throughput"
> 
> I would like to see this series make it into 2.6.34 if its not too late. 

I believe it is... -rc1 is past us.

Also... the way the patches are structured... that will break bisect,
no?
									Pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

Re: [PATCH] PM_QOS updates for 2.6.34-rc1

[Rafael J. Wysocki]

On Sunday 14 March 2010, Pavel Machek wrote:
> On Sat 2010-03-13 16:34:25, 640E9920 wrote:
> > The following patch series implements to following:
> > 1) pm_qos now uses a handle based implementation.  No more string
> > compares while walking lists.
> > 2) renames the exports to using more accurate names.
> > 3) updates kernel clients of pm_qos per this change
> > 4) added ascii interface to pmqos recognizing strings formatted in 10
> > charactor format "0x12345678"
> > 5) added new pm_qos class, "system_bus_throughput"
> > 
> > I would like to see this series make it into 2.6.34 if its not too late. 
> 
> I believe it is... -rc1 is past us.

It definitely is.

> Also... the way the patches are structured... that will break bisect, no?

Not only that.  Some changelogs would be heartily welcome.  In short, what
change the particular patch is going to make and why it's useful.

Rafael

Re: [PATCH] PM_QOS updates for 2.6.34-rc1

[Rafael J. Wysocki]

On Sunday 14 March 2010, Pavel Machek wrote:
> On Sat 2010-03-13 16:34:25, 640E9920 wrote:
> > The following patch series implements to following:
> > 1) pm_qos now uses a handle based implementation.  No more string
> > compares while walking lists.
> > 2) renames the exports to using more accurate names.
> > 3) updates kernel clients of pm_qos per this change
> > 4) added ascii interface to pmqos recognizing strings formatted in 10
> > charactor format "0x12345678"
> > 5) added new pm_qos class, "system_bus_throughput"
> > 
> > I would like to see this series make it into 2.6.34 if its not too late. 
> 
> I believe it is... -rc1 is past us.

It definitely is.

> Also... the way the patches are structured... that will break bisect, no?

Not only that.  Some changelogs would be heartily welcome.  In short, what
change the particular patch is going to make and why it's useful.

Rafael

Re: [PATCH] PM_QOS updates for 2.6.34-rc1

[mark gross]

On Sun, Mar 14, 2010 at 07:26:37AM +0100, Pavel Machek wrote:
> On Sat 2010-03-13 16:34:25, 640E9920 wrote:
> > The following patch series implements to following:
> > 1) pm_qos now uses a handle based implementation.  No more string
> > compares while walking lists.
> > 2) renames the exports to using more accurate names.
> > 3) updates kernel clients of pm_qos per this change
> > 4) added ascii interface to pmqos recognizing strings formatted in 10
> > charactor format "0x12345678"
> > 5) added new pm_qos class, "system_bus_throughput"
> > 
> > I would like to see this series make it into 2.6.34 if its not too late. 
> 
> I believe it is... -rc1 is past us.

crap.  I'll guess I'll redo them for next then.


 
> Also... the way the patches are structured... that will break bisect,
> no?

Um not sure, how would you recomend I structure them?

--mgross

> 									Pavel
> -- 
> (english) http://www.livejournal.com/~pavelmachek
> (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

Re: [PATCH] PM_QOS updates for 2.6.34-rc1

[mark gross]

On Sun, Mar 14, 2010 at 07:26:37AM +0100, Pavel Machek wrote:
> On Sat 2010-03-13 16:34:25, 640E9920 wrote:
> > The following patch series implements to following:
> > 1) pm_qos now uses a handle based implementation.  No more string
> > compares while walking lists.
> > 2) renames the exports to using more accurate names.
> > 3) updates kernel clients of pm_qos per this change
> > 4) added ascii interface to pmqos recognizing strings formatted in 10
> > charactor format "0x12345678"
> > 5) added new pm_qos class, "system_bus_throughput"
> > 
> > I would like to see this series make it into 2.6.34 if its not too late. 
> 
> I believe it is... -rc1 is past us.

crap.  I'll guess I'll redo them for next then.


 
> Also... the way the patches are structured... that will break bisect,
> no?

Um not sure, how would you recomend I structure them?

--mgross

> 									Pavel
> -- 
> (english) http://www.livejournal.com/~pavelmachek
> (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

Re: [PATCH] PM_QOS updates for 2.6.34-rc1

[Rafael J. Wysocki]

On Friday 19 March 2010, mark gross wrote:
> On Sun, Mar 14, 2010 at 07:26:37AM +0100, Pavel Machek wrote:
> > On Sat 2010-03-13 16:34:25, 640E9920 wrote:
> > > The following patch series implements to following:
> > > 1) pm_qos now uses a handle based implementation.  No more string
> > > compares while walking lists.
> > > 2) renames the exports to using more accurate names.
> > > 3) updates kernel clients of pm_qos per this change
> > > 4) added ascii interface to pmqos recognizing strings formatted in 10
> > > charactor format "0x12345678"
> > > 5) added new pm_qos class, "system_bus_throughput"
> > > 
> > > I would like to see this series make it into 2.6.34 if its not too late. 
> > 
> > I believe it is... -rc1 is past us.
> 
> crap.  I'll guess I'll redo them for next then.
> 
> 
>  
> > Also... the way the patches are structured... that will break bisect,
> > no?
> 
> Um not sure, how would you recomend I structure them?

Generally speaking, the kernel should build and should work correctly after
applying each consecutive patch in the series.

Rafael

Re: [PATCH] PM_QOS updates for 2.6.34-rc1

[Rafael J. Wysocki]

On Friday 19 March 2010, mark gross wrote:
> On Sun, Mar 14, 2010 at 07:26:37AM +0100, Pavel Machek wrote:
> > On Sat 2010-03-13 16:34:25, 640E9920 wrote:
> > > The following patch series implements to following:
> > > 1) pm_qos now uses a handle based implementation.  No more string
> > > compares while walking lists.
> > > 2) renames the exports to using more accurate names.
> > > 3) updates kernel clients of pm_qos per this change
> > > 4) added ascii interface to pmqos recognizing strings formatted in 10
> > > charactor format "0x12345678"
> > > 5) added new pm_qos class, "system_bus_throughput"
> > > 
> > > I would like to see this series make it into 2.6.34 if its not too late. 
> > 
> > I believe it is... -rc1 is past us.
> 
> crap.  I'll guess I'll redo them for next then.
> 
> 
>  
> > Also... the way the patches are structured... that will break bisect,
> > no?
> 
> Um not sure, how would you recomend I structure them?

Generally speaking, the kernel should build and should work correctly after
applying each consecutive patch in the series.

Rafael

Re: [PATCH] PM_QOS updates for 2.6.34-rc1

[Daniel Walker]

On Fri, 2010-03-19 at 20:49 +0100, Rafael J. Wysocki wrote:
> On Friday 19 March 2010, mark gross wrote:
> > On Sun, Mar 14, 2010 at 07:26:37AM +0100, Pavel Machek wrote:
> > > On Sat 2010-03-13 16:34:25, 640E9920 wrote:
> > > > The following patch series implements to following:
> > > > 1) pm_qos now uses a handle based implementation.  No more string
> > > > compares while walking lists.
> > > > 2) renames the exports to using more accurate names.
> > > > 3) updates kernel clients of pm_qos per this change
> > > > 4) added ascii interface to pmqos recognizing strings formatted in 10
> > > > charactor format "0x12345678"
> > > > 5) added new pm_qos class, "system_bus_throughput"
> > > > 
> > > > I would like to see this series make it into 2.6.34 if its not too late. 
> > > 
> > > I believe it is... -rc1 is past us.
> > 
> > crap.  I'll guess I'll redo them for next then.
> > 
> > 
> >  
> > > Also... the way the patches are structured... that will break bisect,
> > > no?
> > 
> > Um not sure, how would you recomend I structure them?
> 
> Generally speaking, the kernel should build and should work correctly after
> applying each consecutive patch in the series.

I think you would need to have the handle based method along side the
old method until all the kernel clients are converted.. Then remove the
old method ..

Daniel

Re: [PATCH] PM_QOS updates for 2.6.34-rc1

[Daniel Walker]

On Fri, 2010-03-19 at 20:49 +0100, Rafael J. Wysocki wrote:
> On Friday 19 March 2010, mark gross wrote:
> > On Sun, Mar 14, 2010 at 07:26:37AM +0100, Pavel Machek wrote:
> > > On Sat 2010-03-13 16:34:25, 640E9920 wrote:
> > > > The following patch series implements to following:
> > > > 1) pm_qos now uses a handle based implementation.  No more string
> > > > compares while walking lists.
> > > > 2) renames the exports to using more accurate names.
> > > > 3) updates kernel clients of pm_qos per this change
> > > > 4) added ascii interface to pmqos recognizing strings formatted in 10
> > > > charactor format "0x12345678"
> > > > 5) added new pm_qos class, "system_bus_throughput"
> > > > 
> > > > I would like to see this series make it into 2.6.34 if its not too late. 
> > > 
> > > I believe it is... -rc1 is past us.
> > 
> > crap.  I'll guess I'll redo them for next then.
> > 
> > 
> >  
> > > Also... the way the patches are structured... that will break bisect,
> > > no?
> > 
> > Um not sure, how would you recomend I structure them?
> 
> Generally speaking, the kernel should build and should work correctly after
> applying each consecutive patch in the series.

I think you would need to have the handle based method along side the
old method until all the kernel clients are converted.. Then remove the
old method ..

Daniel

[PATCH] PM_QOS updates for 2.6.34-rc1

[640E9920]

The following patch series implements to following:
1) pm_qos now uses a handle based implementation.  No more string
compares while walking lists.
2) renames the exports to using more accurate names.
3) updates kernel clients of pm_qos per this change
4) added ascii interface to pmqos recognizing strings formatted in 10
charactor format "0x12345678"
5) added new pm_qos class, "system_bus_throughput"

I would like to see this series make it into 2.6.34 if its not too late. 

I was able to test it on my laptop and comments welcome.

Thank you!

--mgross