* [PATCH -mm 2/3] kill the obsolete thread_group_cputime_free() and taskstats_tgid_init() helpers
@ 2010-03-21 18:47 Oleg Nesterov
0 siblings, 0 replies; only message in thread
From: Oleg Nesterov @ 2010-03-21 18:47 UTC (permalink / raw)
To: Andrew Morton
Cc: Balbir Singh, Roland McGrath, Veaceslav Falico,
Stanislaw Gruszka, linux-kernel
Trivial, but a separate patch for paranoid reasons.
- Kill the empty thread_group_cputime_free() helper. It was needed
to free the per-cpu data which we no longer have.
- Kill taskstats_tgid_init(), unneeded since
"copy_signal() cleanup: use zalloc and remove initializations"
a56704ef6b0c5796c9ff38cc78aa232dfb9644d7
Signed-off-by: Oleg Nesterov <oleg@redhat.com>
---
include/linux/sched.h | 4 ----
include/linux/taskstats_kern.h | 7 -------
kernel/fork.c | 1 -
3 files changed, 12 deletions(-)
--- 34-rc1/include/linux/sched.h~12_KILL_DEAD_HELPERS 2010-03-21 18:31:47.000000000 +0100
+++ 34-rc1/include/linux/sched.h 2010-03-21 18:35:01.000000000 +0100
@@ -2396,10 +2396,6 @@ static inline void thread_group_cputime_
sig->cputimer.running = 0;
}
-static inline void thread_group_cputime_free(struct signal_struct *sig)
-{
-}
-
/*
* Reevaluate whether the task has signals pending delivery.
* Wake the task if so.
--- 34-rc1/include/linux/taskstats_kern.h~12_KILL_DEAD_HELPERS 2010-03-21 18:31:47.000000000 +0100
+++ 34-rc1/include/linux/taskstats_kern.h 2010-03-21 18:35:01.000000000 +0100
@@ -14,11 +14,6 @@
extern struct kmem_cache *taskstats_cache;
extern struct mutex taskstats_exit_mutex;
-static inline void taskstats_tgid_init(struct signal_struct *sig)
-{
- sig->stats = NULL;
-}
-
static inline void taskstats_tgid_free(struct signal_struct *sig)
{
if (sig->stats)
@@ -30,8 +25,6 @@ extern void taskstats_init_early(void);
#else
static inline void taskstats_exit(struct task_struct *tsk, int group_dead)
{}
-static inline void taskstats_tgid_init(struct signal_struct *sig)
-{}
static inline void taskstats_tgid_free(struct signal_struct *sig)
{}
static inline void taskstats_init_early(void)
--- 34-rc1/kernel/fork.c~12_KILL_DEAD_HELPERS 2010-03-21 18:34:02.000000000 +0100
+++ 34-rc1/kernel/fork.c 2010-03-21 18:35:01.000000000 +0100
@@ -160,7 +160,6 @@ EXPORT_SYMBOL(free_task);
static inline void free_signal_struct(struct signal_struct *sig)
{
- thread_group_cputime_free(sig);
kmem_cache_free(signal_cachep, sig);
}
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2010-03-21 18:49 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2010-03-21 18:47 [PATCH -mm 2/3] kill the obsolete thread_group_cputime_free() and taskstats_tgid_init() helpers Oleg Nesterov
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.