All of lore.kernel.org
 help / color / mirror / Atom feed
* [patch] fscache: add missing unlock
@ 2010-03-23 11:26 ` Dan Carpenter
  0 siblings, 0 replies; 3+ messages in thread
From: Dan Carpenter @ 2010-03-23 11:26 UTC (permalink / raw)
  To: David Howells
  Cc: Steve Dickson, Al Viro, Trond Myklebust, Daire Byrne,
	linux-cachefs, linux-kernel, kernel-janitors

Sparse complained about this missing spin_unlock()

Signed-off-by: Dan Carpenter <error27@gmail.com>

diff --git a/fs/fscache/page.c b/fs/fscache/page.c
index c598ea4..6980902 100644
--- a/fs/fscache/page.c
+++ b/fs/fscache/page.c
@@ -881,6 +881,7 @@ submit_failed:
 	goto nobufs;
 
 nobufs_unlock_obj:
+	spin_unlock(&cookie->stores_lock);
 	spin_unlock(&object->lock);
 nobufs:
 	spin_unlock(&cookie->lock);

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* [patch] fscache: add missing unlock
@ 2010-03-23 11:26 ` Dan Carpenter
  0 siblings, 0 replies; 3+ messages in thread
From: Dan Carpenter @ 2010-03-23 11:26 UTC (permalink / raw)
  To: David Howells
  Cc: Steve Dickson, Al Viro, Trond Myklebust, Daire Byrne,
	linux-cachefs, linux-kernel, kernel-janitors

Sparse complained about this missing spin_unlock()

Signed-off-by: Dan Carpenter <error27@gmail.com>

diff --git a/fs/fscache/page.c b/fs/fscache/page.c
index c598ea4..6980902 100644
--- a/fs/fscache/page.c
+++ b/fs/fscache/page.c
@@ -881,6 +881,7 @@ submit_failed:
 	goto nobufs;
 
 nobufs_unlock_obj:
+	spin_unlock(&cookie->stores_lock);
 	spin_unlock(&object->lock);
 nobufs:
 	spin_unlock(&cookie->lock);

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* [PATCH] fscache: add missing unlock
@ 2010-03-23 14:48 David Howells
  0 siblings, 0 replies; 3+ messages in thread
From: David Howells @ 2010-03-23 14:48 UTC (permalink / raw)
  To: torvalds, akpm
  Cc: viro, Trond.Myklebust, linux-cachefs, linux-kernel,
	kernel-janitors, Dan Carpenter, David Howells

From: Dan Carpenter <error27@gmail.com>

Sparse complained about this missing spin_unlock()

Signed-off-by: Dan Carpenter <error27@gmail.com>
Signed-off-by: David Howells <dhowells@redhat.com>
---

 fs/fscache/page.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/fs/fscache/page.c b/fs/fscache/page.c
index c598ea4..6980902 100644
--- a/fs/fscache/page.c
+++ b/fs/fscache/page.c
@@ -881,6 +881,7 @@ submit_failed:
 	goto nobufs;
 
 nobufs_unlock_obj:
+	spin_unlock(&cookie->stores_lock);
 	spin_unlock(&object->lock);
 nobufs:
 	spin_unlock(&cookie->lock);


^ permalink raw reply related	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2010-03-23 14:50 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2010-03-23 11:26 [patch] fscache: add missing unlock Dan Carpenter
2010-03-23 11:26 ` Dan Carpenter
2010-03-23 14:48 [PATCH] " David Howells

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.