SIIG DP CyberSerial 4S PCIe Support

SIIG DP CyberSerial 4S PCIe Support

[James Lamanna]

Hi,
I recently purchased a SIIG DP CyberSerial 4S PCIe card, however the
kernel doesn't seem to recognize it.
There are no messages in dmesg or anything about it.
Currently I'm at 2.6.24, but looking at drivers/serial/8250_pci.c
between 2.6.24 and 2.6.32 there doesn't
seem to be real changes with SIIG cards.
Seems like other SIIG cards are supported, so are we just missing the
PCI IDs for this card?

Here's the lspci -nnvvvvvv output:

01:00.0 Serial controller [0700]: Oxford Semiconductor Ltd Unknown
device [1415:c208] (prog-if 06 [16950])
        Subsystem: Siig Inc Unknown device [131f:2250]
        Control: I/O+ Mem+ BusMaster- SpecCycle- MemWINV- VGASnoop-
ParErr- Stepping- SERR- FastB2B-
        Status: Cap+ 66MHz- UDF- FastB2B- ParErr- DEVSEL=fast >TAbort-
<TAbort- <MAbort- >SERR- <PERR-
        Interrupt: pin A routed to IRQ 16
        Region 0: Memory at fe8fc000 (32-bit, non-prefetchable) [size=16K]
        Region 1: Memory at fe600000 (32-bit, non-prefetchable) [size=2M]
        Region 2: Memory at fe400000 (32-bit, non-prefetchable) [size=2M]
        Capabilities: [40] Power Management version 3
                Flags: PMEClk- DSI- D1+ D2+ AuxCurrent=55mA
PME(D0-,D1+,D2+,D3hot+,D3cold+)
                Status: D0 PME-Enable- DSel=0 DScale=0 PME-
        Capabilities: [70] Express Endpoint IRQ 0
                Device: Supported: MaxPayload 128 bytes, PhantFunc 0, ExtTag-
                Device: Latency L0s <128ns, L1 <2us
                Device: AtnBtn- AtnInd- PwrInd-
                Device: Errors: Correctable- Non-Fatal+ Fatal+ Unsupported-
                Device: RlxdOrd+ ExtTag- PhantFunc- AuxPwr- NoSnoop-
                Device: MaxPayload 128 bytes, MaxReadReq 512 bytes
                Link: Supported Speed 2.5Gb/s, Width x1, ASPM L0s L1, Port 0
                Link: Latency L0s <512ns, L1 <64us
                Link: ASPM Disabled RCB 64 bytes CommClk- ExtSynch-
                Link: Speed 2.5Gb/s, Width x1
        Capabilities: [b0] MSI-X: Enable- Mask- TabSize=16
                Vector table: BAR=1 offset=001b3000
                PBA: BAR=1 offset=001b2000

Please CC me for I am not subscribed.

Thanks.

-- James

Re: SIIG DP CyberSerial 4S PCIe Support

[James Lamanna]

On Mon, Mar 8, 2010 at 11:07 AM, James Lamanna <jlamanna@gmail.com> wrote:
> Hi,
> I recently purchased a SIIG DP CyberSerial 4S PCIe card, however the
> kernel doesn't seem to recognize it.
> There are no messages in dmesg or anything about it.
> Currently I'm at 2.6.24, but looking at drivers/serial/8250_pci.c
> between 2.6.24 and 2.6.32 there doesn't
> seem to be real changes with SIIG cards.
> Seems like other SIIG cards are supported, so are we just missing the
> PCI IDs for this card?
>
> Here's the lspci -nnvvvvvv output:
>
> 01:00.0 Serial controller [0700]: Oxford Semiconductor Ltd Unknown
> device [1415:c208] (prog-if 06 [16950])
>        Subsystem: Siig Inc Unknown device [131f:2250]
>        Control: I/O+ Mem+ BusMaster- SpecCycle- MemWINV- VGASnoop-
> ParErr- Stepping- SERR- FastB2B-
>        Status: Cap+ 66MHz- UDF- FastB2B- ParErr- DEVSEL=fast >TAbort-
> <TAbort- <MAbort- >SERR- <PERR-
>        Interrupt: pin A routed to IRQ 16
>        Region 0: Memory at fe8fc000 (32-bit, non-prefetchable) [size=16K]
>        Region 1: Memory at fe600000 (32-bit, non-prefetchable) [size=2M]
>        Region 2: Memory at fe400000 (32-bit, non-prefetchable) [size=2M]
>        Capabilities: [40] Power Management version 3
>                Flags: PMEClk- DSI- D1+ D2+ AuxCurrent=55mA
> PME(D0-,D1+,D2+,D3hot+,D3cold+)
>                Status: D0 PME-Enable- DSel=0 DScale=0 PME-
>        Capabilities: [70] Express Endpoint IRQ 0
>                Device: Supported: MaxPayload 128 bytes, PhantFunc 0, ExtTag-
>                Device: Latency L0s <128ns, L1 <2us
>                Device: AtnBtn- AtnInd- PwrInd-
>                Device: Errors: Correctable- Non-Fatal+ Fatal+ Unsupported-
>                Device: RlxdOrd+ ExtTag- PhantFunc- AuxPwr- NoSnoop-
>                Device: MaxPayload 128 bytes, MaxReadReq 512 bytes
>                Link: Supported Speed 2.5Gb/s, Width x1, ASPM L0s L1, Port 0
>                Link: Latency L0s <512ns, L1 <64us
>                Link: ASPM Disabled RCB 64 bytes CommClk- ExtSynch-
>                Link: Speed 2.5Gb/s, Width x1
>        Capabilities: [b0] MSI-X: Enable- Mask- TabSize=16
>                Vector table: BAR=1 offset=001b3000
>                PBA: BAR=1 offset=001b2000

After some more digging I found these messages in dmesg which doesn't
exactly sound good:

[   52.104180] ACPI: PCI Interrupt 0000:01:00.0[A] -> GSI 16 (level,
low) -> IRQ 16
[   52.104189] ACPI: PCI interrupt for device 0000:01:00.0 disabled

01:00.0 is the device ID of the SIIG card.
Any reason ACPI would disable interrupts for this card?

Thanks.

-- James

>
> Please CC me for I am not subscribed.
>
> Thanks.
>
> -- James
>

Re: SIIG DP CyberSerial 4S PCIe Support

[James Lamanna]

On Mon, Mar 8, 2010 at 11:07 AM, James Lamanna <jlamanna@gmail.com> wrote:
> Hi,
> I recently purchased a SIIG DP CyberSerial 4S PCIe card, however the
> kernel doesn't seem to recognize it.
> There are no messages in dmesg or anything about it.
> Currently I'm at 2.6.24, but looking at drivers/serial/8250_pci.c
> between 2.6.24 and 2.6.32 there doesn't
> seem to be real changes with SIIG cards.
> Seems like other SIIG cards are supported, so are we just missing the
> PCI IDs for this card?
>
> Here's the lspci -nnvvvvvv output:
>
> 01:00.0 Serial controller [0700]: Oxford Semiconductor Ltd Unknown
> device [1415:c208] (prog-if 06 [16950])
>        Subsystem: Siig Inc Unknown device [131f:2250]
>        Control: I/O+ Mem+ BusMaster- SpecCycle- MemWINV- VGASnoop-
> ParErr- Stepping- SERR- FastB2B-
>        Status: Cap+ 66MHz- UDF- FastB2B- ParErr- DEVSEL=fast >TAbort-
> <TAbort- <MAbort- >SERR- <PERR-
>        Interrupt: pin A routed to IRQ 16
>        Region 0: Memory at fe8fc000 (32-bit, non-prefetchable) [size=16K]
>        Region 1: Memory at fe600000 (32-bit, non-prefetchable) [size=2M]
>        Region 2: Memory at fe400000 (32-bit, non-prefetchable) [size=2M]
>        Capabilities: [40] Power Management version 3
>                Flags: PMEClk- DSI- D1+ D2+ AuxCurrent=55mA
> PME(D0-,D1+,D2+,D3hot+,D3cold+)
>                Status: D0 PME-Enable- DSel=0 DScale=0 PME-
>        Capabilities: [70] Express Endpoint IRQ 0
>                Device: Supported: MaxPayload 128 bytes, PhantFunc 0, ExtTag-
>                Device: Latency L0s <128ns, L1 <2us
>                Device: AtnBtn- AtnInd- PwrInd-
>                Device: Errors: Correctable- Non-Fatal+ Fatal+ Unsupported-
>                Device: RlxdOrd+ ExtTag- PhantFunc- AuxPwr- NoSnoop-
>                Device: MaxPayload 128 bytes, MaxReadReq 512 bytes
>                Link: Supported Speed 2.5Gb/s, Width x1, ASPM L0s L1, Port 0
>                Link: Latency L0s <512ns, L1 <64us
>                Link: ASPM Disabled RCB 64 bytes CommClk- ExtSynch-
>                Link: Speed 2.5Gb/s, Width x1
>        Capabilities: [b0] MSI-X: Enable- Mask- TabSize=16
>                Vector table: BAR=1 offset=001b3000
>                PBA: BAR=1 offset=001b2000

After some more digging I found these messages in dmesg which doesn't
exactly sound good:

[   52.104180] ACPI: PCI Interrupt 0000:01:00.0[A] -> GSI 16 (level,
low) -> IRQ 16
[   52.104189] ACPI: PCI interrupt for device 0000:01:00.0 disabled

01:00.0 is the device ID of the SIIG card.
Any reason ACPI would disable interrupts for this card?

Thanks.

-- James

>
> Please CC me for I am not subscribed.
>
> Thanks.
>
> -- James
>
--
To unsubscribe from this list: send the line "unsubscribe linux-serial" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: SIIG DP CyberSerial 4S PCIe Support

[Robert Hancock]

On 03/08/2010 03:13 PM, James Lamanna wrote:
> On Mon, Mar 8, 2010 at 11:07 AM, James Lamanna<jlamanna@gmail.com>  wrote:
>> Hi,
>> I recently purchased a SIIG DP CyberSerial 4S PCIe card, however the
>> kernel doesn't seem to recognize it.
>> There are no messages in dmesg or anything about it.
>> Currently I'm at 2.6.24, but looking at drivers/serial/8250_pci.c
>> between 2.6.24 and 2.6.32 there doesn't
>> seem to be real changes with SIIG cards.
>> Seems like other SIIG cards are supported, so are we just missing the
>> PCI IDs for this card?
>>
>> Here's the lspci -nnvvvvvv output:
>>
>> 01:00.0 Serial controller [0700]: Oxford Semiconductor Ltd Unknown
>> device [1415:c208] (prog-if 06 [16950])
>>         Subsystem: Siig Inc Unknown device [131f:2250]
>>         Control: I/O+ Mem+ BusMaster- SpecCycle- MemWINV- VGASnoop-
>> ParErr- Stepping- SERR- FastB2B-
>>         Status: Cap+ 66MHz- UDF- FastB2B- ParErr- DEVSEL=fast>TAbort-
>> <TAbort-<MAbort->SERR-<PERR-
>>         Interrupt: pin A routed to IRQ 16
>>         Region 0: Memory at fe8fc000 (32-bit, non-prefetchable) [size=16K]
>>         Region 1: Memory at fe600000 (32-bit, non-prefetchable) [size=2M]
>>         Region 2: Memory at fe400000 (32-bit, non-prefetchable) [size=2M]
>>         Capabilities: [40] Power Management version 3
>>                 Flags: PMEClk- DSI- D1+ D2+ AuxCurrent=55mA
>> PME(D0-,D1+,D2+,D3hot+,D3cold+)
>>                 Status: D0 PME-Enable- DSel=0 DScale=0 PME-
>>         Capabilities: [70] Express Endpoint IRQ 0
>>                 Device: Supported: MaxPayload 128 bytes, PhantFunc 0, ExtTag-
>>                 Device: Latency L0s<128ns, L1<2us
>>                 Device: AtnBtn- AtnInd- PwrInd-
>>                 Device: Errors: Correctable- Non-Fatal+ Fatal+ Unsupported-
>>                 Device: RlxdOrd+ ExtTag- PhantFunc- AuxPwr- NoSnoop-
>>                 Device: MaxPayload 128 bytes, MaxReadReq 512 bytes
>>                 Link: Supported Speed 2.5Gb/s, Width x1, ASPM L0s L1, Port 0
>>                 Link: Latency L0s<512ns, L1<64us
>>                 Link: ASPM Disabled RCB 64 bytes CommClk- ExtSynch-
>>                 Link: Speed 2.5Gb/s, Width x1
>>         Capabilities: [b0] MSI-X: Enable- Mask- TabSize=16
>>                 Vector table: BAR=1 offset=001b3000
>>                 PBA: BAR=1 offset=001b2000
>
> After some more digging I found these messages in dmesg which doesn't
> exactly sound good:
>
> [   52.104180] ACPI: PCI Interrupt 0000:01:00.0[A] ->  GSI 16 (level,
> low) ->  IRQ 16
> [   52.104189] ACPI: PCI interrupt for device 0000:01:00.0 disabled
>
> 01:00.0 is the device ID of the SIIG card.
> Any reason ACPI would disable interrupts for this card?

Probably just means some driver temporarily decided to enable the 
interrupt, then disabled it (maybe because it decided it couldn't run 
the device?)

Re: SIIG DP CyberSerial 4S PCIe Support

[James Lamanna]

On Mon, Mar 8, 2010 at 6:19 PM, Robert Hancock <hancockrwd@gmail.com> wrote:
> On 03/08/2010 03:13 PM, James Lamanna wrote:
>>
>> On Mon, Mar 8, 2010 at 11:07 AM, James Lamanna<jlamanna@gmail.com>  wrote:
>>>
>>> Hi,
>>> I recently purchased a SIIG DP CyberSerial 4S PCIe card, however the
>>> kernel doesn't seem to recognize it.
>>> There are no messages in dmesg or anything about it.
>>> Currently I'm at 2.6.24, but looking at drivers/serial/8250_pci.c
>>> between 2.6.24 and 2.6.32 there doesn't
>>> seem to be real changes with SIIG cards.
>>> Seems like other SIIG cards are supported, so are we just missing the
>>> PCI IDs for this card?
>>>
>>> Here's the lspci -nnvvvvvv output:
>>>
>>> 01:00.0 Serial controller [0700]: Oxford Semiconductor Ltd Unknown
>>> device [1415:c208] (prog-if 06 [16950])
>>>        Subsystem: Siig Inc Unknown device [131f:2250]
>>>        Control: I/O+ Mem+ BusMaster- SpecCycle- MemWINV- VGASnoop-
>>> ParErr- Stepping- SERR- FastB2B-
>>>        Status: Cap+ 66MHz- UDF- FastB2B- ParErr- DEVSEL=fast>TAbort-
>>> <TAbort-<MAbort->SERR-<PERR-
>>>        Interrupt: pin A routed to IRQ 16
>>>        Region 0: Memory at fe8fc000 (32-bit, non-prefetchable) [size=16K]
>>>        Region 1: Memory at fe600000 (32-bit, non-prefetchable) [size=2M]
>>>        Region 2: Memory at fe400000 (32-bit, non-prefetchable) [size=2M]
>>>        Capabilities: [40] Power Management version 3
>>>                Flags: PMEClk- DSI- D1+ D2+ AuxCurrent=55mA
>>> PME(D0-,D1+,D2+,D3hot+,D3cold+)
>>>                Status: D0 PME-Enable- DSel=0 DScale=0 PME-
>>>        Capabilities: [70] Express Endpoint IRQ 0
>>>                Device: Supported: MaxPayload 128 bytes, PhantFunc 0,
>>> ExtTag-
>>>                Device: Latency L0s<128ns, L1<2us
>>>                Device: AtnBtn- AtnInd- PwrInd-
>>>                Device: Errors: Correctable- Non-Fatal+ Fatal+
>>> Unsupported-
>>>                Device: RlxdOrd+ ExtTag- PhantFunc- AuxPwr- NoSnoop-
>>>                Device: MaxPayload 128 bytes, MaxReadReq 512 bytes
>>>                Link: Supported Speed 2.5Gb/s, Width x1, ASPM L0s L1, Port
>>> 0
>>>                Link: Latency L0s<512ns, L1<64us
>>>                Link: ASPM Disabled RCB 64 bytes CommClk- ExtSynch-
>>>                Link: Speed 2.5Gb/s, Width x1
>>>        Capabilities: [b0] MSI-X: Enable- Mask- TabSize=16
>>>                Vector table: BAR=1 offset=001b3000
>>>                PBA: BAR=1 offset=001b2000
>>
>> After some more digging I found these messages in dmesg which doesn't
>> exactly sound good:
>>
>> [   52.104180] ACPI: PCI Interrupt 0000:01:00.0[A] ->  GSI 16 (level,
>> low) ->  IRQ 16
>> [   52.104189] ACPI: PCI interrupt for device 0000:01:00.0 disabled
>>
>> 01:00.0 is the device ID of the SIIG card.
>> Any reason ACPI would disable interrupts for this card?
>
> Probably just means some driver temporarily decided to enable the interrupt,
> then disabled it (maybe because it decided it couldn't run the device?)

That's probably the case.
It looks like 8250 doesn't know about this PCIe device at all.
The Oxford PCI ID is not in pci_ids.h nor is the SIIG subsystem ID.
I'll see if I can maybe work up a patch to support this device, since I've found
the datasheet for the Oxford 4 port UART controller, but I may need some help.
Or if anyone else (who has more experience with this) wants to formulate one,
it would be greatly appreciated.

-- James

Re: SIIG DP CyberSerial 4S PCIe Support

[James Lamanna]

On Mon, Mar 8, 2010 at 6:19 PM, Robert Hancock <hancockrwd@gmail.com> wrote:
> On 03/08/2010 03:13 PM, James Lamanna wrote:
>>
>> On Mon, Mar 8, 2010 at 11:07 AM, James Lamanna<jlamanna@gmail.com>  wrote:
>>>
>>> Hi,
>>> I recently purchased a SIIG DP CyberSerial 4S PCIe card, however the
>>> kernel doesn't seem to recognize it.
>>> There are no messages in dmesg or anything about it.
>>> Currently I'm at 2.6.24, but looking at drivers/serial/8250_pci.c
>>> between 2.6.24 and 2.6.32 there doesn't
>>> seem to be real changes with SIIG cards.
>>> Seems like other SIIG cards are supported, so are we just missing the
>>> PCI IDs for this card?
>>>
>>> Here's the lspci -nnvvvvvv output:
>>>
>>> 01:00.0 Serial controller [0700]: Oxford Semiconductor Ltd Unknown
>>> device [1415:c208] (prog-if 06 [16950])
>>>        Subsystem: Siig Inc Unknown device [131f:2250]
>>>        Control: I/O+ Mem+ BusMaster- SpecCycle- MemWINV- VGASnoop-
>>> ParErr- Stepping- SERR- FastB2B-
>>>        Status: Cap+ 66MHz- UDF- FastB2B- ParErr- DEVSEL=fast>TAbort-
>>> <TAbort-<MAbort->SERR-<PERR-
>>>        Interrupt: pin A routed to IRQ 16
>>>        Region 0: Memory at fe8fc000 (32-bit, non-prefetchable) [size=16K]
>>>        Region 1: Memory at fe600000 (32-bit, non-prefetchable) [size=2M]
>>>        Region 2: Memory at fe400000 (32-bit, non-prefetchable) [size=2M]
>>>        Capabilities: [40] Power Management version 3
>>>                Flags: PMEClk- DSI- D1+ D2+ AuxCurrent=55mA
>>> PME(D0-,D1+,D2+,D3hot+,D3cold+)
>>>                Status: D0 PME-Enable- DSel=0 DScale=0 PME-
>>>        Capabilities: [70] Express Endpoint IRQ 0
>>>                Device: Supported: MaxPayload 128 bytes, PhantFunc 0,
>>> ExtTag-
>>>                Device: Latency L0s<128ns, L1<2us
>>>                Device: AtnBtn- AtnInd- PwrInd-
>>>                Device: Errors: Correctable- Non-Fatal+ Fatal+
>>> Unsupported-
>>>                Device: RlxdOrd+ ExtTag- PhantFunc- AuxPwr- NoSnoop-
>>>                Device: MaxPayload 128 bytes, MaxReadReq 512 bytes
>>>                Link: Supported Speed 2.5Gb/s, Width x1, ASPM L0s L1, Port
>>> 0
>>>                Link: Latency L0s<512ns, L1<64us
>>>                Link: ASPM Disabled RCB 64 bytes CommClk- ExtSynch-
>>>                Link: Speed 2.5Gb/s, Width x1
>>>        Capabilities: [b0] MSI-X: Enable- Mask- TabSize=16
>>>                Vector table: BAR=1 offset=001b3000
>>>                PBA: BAR=1 offset=001b2000
>>
>> After some more digging I found these messages in dmesg which doesn't
>> exactly sound good:
>>
>> [   52.104180] ACPI: PCI Interrupt 0000:01:00.0[A] ->  GSI 16 (level,
>> low) ->  IRQ 16
>> [   52.104189] ACPI: PCI interrupt for device 0000:01:00.0 disabled
>>
>> 01:00.0 is the device ID of the SIIG card.
>> Any reason ACPI would disable interrupts for this card?
>
> Probably just means some driver temporarily decided to enable the interrupt,
> then disabled it (maybe because it decided it couldn't run the device?)

That's probably the case.
It looks like 8250 doesn't know about this PCIe device at all.
The Oxford PCI ID is not in pci_ids.h nor is the SIIG subsystem ID.
I'll see if I can maybe work up a patch to support this device, since I've found
the datasheet for the Oxford 4 port UART controller, but I may need some help.
Or if anyone else (who has more experience with this) wants to formulate one,
it would be greatly appreciated.

-- James
--
To unsubscribe from this list: send the line "unsubscribe linux-serial" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: SIIG DP CyberSerial 4S PCIe Support

[Andrey Panin]

[-- Attachment #1: Type: text/plain, Size: 625 bytes --]

On 067, 03 08, 2010 at 09:15:26PM -0800, James Lamanna wrote:

> That's probably the case.
> It looks like 8250 doesn't know about this PCIe device at all.
> The Oxford PCI ID is not in pci_ids.h nor is the SIIG subsystem ID.
> I'll see if I can maybe work up a patch to support this device, since I've found
> the datasheet for the Oxford 4 port UART controller, but I may need some help.
> Or if anyone else (who has more experience with this) wants to formulate one,
> it would be greatly appreciated.

Looks like you card can use existing code for Oxford Semiconductor UARTs.
Can you test the attached patch for 2.6.33 ?

[-- Attachment #2: patch-siig-pcie --]
[-- Type: text/plain, Size: 3150 bytes --]

diff -urdpX dontdiff linux-2.6.33.vanilla/drivers/serial/8250_pci.c linux-2.6.33/drivers/serial/8250_pci.c
--- linux-2.6.33.vanilla/drivers/serial/8250_pci.c	2010-03-09 16:19:55.000000000 +0300
+++ linux-2.6.33/drivers/serial/8250_pci.c	2010-03-09 16:26:02.000000000 +0300
@@ -431,6 +431,38 @@ static void __devexit sbs_exit(struct pc
 }
 
 /*
+ * Oxford Semiconductor Inc.
+ * Check that device is part of the Tornado range of devices, then determine
+ * the number of ports available on the device.
+ */
+static int pci_oxsemi_tornado_init(struct pci_dev *dev)
+{
+	u8 __iomem *p;
+	unsigned long deviceID;
+	unsigned int  number_uarts = 0;
+
+	/* OxSemi Tornado devices are all 0xCxxx */
+	if (dev->vendor == PCI_VENDOR_ID_OXSEMI &&
+	    (dev->device & 0xF000) != 0xC000)
+		return 0;
+
+	p = pci_iomap(dev, 0, 5);
+	if (p == NULL)
+		return -ENOMEM;
+
+	deviceID = ioread32(p);
+	/* Tornado device */
+	if (deviceID == 0x07000200) {
+		number_uarts = ioread8(p + 4);
+		printk(KERN_DEBUG
+			"%d ports detected on Oxford PCI Express device\n",
+								number_uarts);
+	}
+	pci_iounmap(dev, p);
+	return number_uarts;
+}
+
+/*
  * SIIG serial cards have an PCI interface chip which also controls
  * the UART clocking frequency. Each UART can be clocked independently
  * (except cards equiped with 4 UARTs) and initial clocking settings
@@ -515,6 +547,8 @@ static int pci_siig_init(struct pci_dev 
 		return pci_siig10x_init(dev);
 	else if (type == 0x2000)
 		return pci_siig20x_init(dev);
+	else if ((type & 0xf000) == 0xc000)
+		return pci_oxsemi_tornado_init(dev);
 
 	moan_device("Unknown SIIG card", dev);
 	return -ENODEV;
@@ -902,38 +936,6 @@ static void __devexit pci_ite887x_exit(s
 	release_region(ioport, ITE_887x_IOSIZE);
 }
 
-/*
- * Oxford Semiconductor Inc.
- * Check that device is part of the Tornado range of devices, then determine
- * the number of ports available on the device.
- */
-static int pci_oxsemi_tornado_init(struct pci_dev *dev)
-{
-	u8 __iomem *p;
-	unsigned long deviceID;
-	unsigned int  number_uarts = 0;
-
-	/* OxSemi Tornado devices are all 0xCxxx */
-	if (dev->vendor == PCI_VENDOR_ID_OXSEMI &&
-	    (dev->device & 0xF000) != 0xC000)
-		return 0;
-
-	p = pci_iomap(dev, 0, 5);
-	if (p == NULL)
-		return -ENOMEM;
-
-	deviceID = ioread32(p);
-	/* Tornado device */
-	if (deviceID == 0x07000200) {
-		number_uarts = ioread8(p + 4);
-		printk(KERN_DEBUG
-			"%d ports detected on Oxford PCI Express device\n",
-								number_uarts);
-	}
-	pci_iounmap(dev, p);
-	return number_uarts;
-}
-
 static int
 pci_default_setup(struct serial_private *priv,
 		  const struct pciserial_board *board,
@@ -2984,6 +2986,13 @@ static struct pci_device_id serial_pci_t
 		PCI_VENDOR_ID_MAINPINE, 0x4008, 0, 0,
 		pbn_oxsemi_8_4000000 },
 	/*
+	 * SIIG cards utilizing OxSemi Tornado
+	 */
+	{	PCI_VENDOR_ID_SIIG, 0xc208,	/* SIIG DP CyberSerial 4S PCIe */
+		PCI_ANY_ID, PCI_ANY_ID, 0, 0,
+		pbn_oxsemi_4_4000000 },
+
+	/*
 	 * SBS Technologies, Inc. P-Octal and PMC-OCTPRO cards,
 	 * from skokodyn@yahoo.com
 	 */

Re: SIIG DP CyberSerial 4S PCIe Support

[James Lamanna]

--James

On Mar 9, 2010, at 6:15, "Andrey Panin" <pazke@centrinvest.ru> wrote:

> On 067, 03 08, 2010 at 09:15:26PM -0800, James Lamanna wrote:
>
>> That's probably the case.
>> It looks like 8250 doesn't know about this PCIe device at all.
>> The Oxford PCI ID is not in pci_ids.h nor is the SIIG subsystem ID.
>> I'll see if I can maybe work up a patch to support this device,  
>> since I've found
>> the datasheet for the Oxford 4 port UART controller, but I may need  
>> some help.
>> Or if anyone else (who has more experience with this) wants to  
>> formulate one,
>> it would be greatly appreciated.
>
> Looks like you card can use existing code for Oxford Semiconductor  
> UARTs.
> Can you test the attached patch for 2.6.33 ?
> <patch-siig-pcie>

Re: SIIG DP CyberSerial 4S PCIe Support

[James Lamanna]

On Mar 9, 2010, at 6:15, "Andrey Panin" <pazke@centrinvest.ru> wrote:

> On 067, 03 08, 2010 at 09:15:26PM -0800, James Lamanna wrote:
>
>> That's probably the case.
>> It looks like 8250 doesn't know about this PCIe device at all.
>> The Oxford PCI ID is not in pci_ids.h nor is the SIIG subsystem ID.
>> I'll see if I can maybe work up a patch to support this device,  
>> since I've found
>> the datasheet for the Oxford 4 port UART controller, but I may need  
>> some help.
>> Or if anyone else (who has more experience with this) wants to  
>> formulate one,
>> it would be greatly appreciated.
>
> Looks like you card can use existing code for Oxford Semiconductor  
> UARTs.
> Can you test the attached patch for 2.6.33 ?

Hi Andrey,
Coincidentally I found your patch for 2.6.28 that I was able to  
backport to 2.6.24. The card seems to be working great!
Is this patch in mainline now?

Thanks.

-- James

Re: SIIG DP CyberSerial 4S PCIe Support

[Andrey Panin]

On 068, 03 09, 2010 at 07:09:21AM -0800, James Lamanna wrote:
> On Mar 9, 2010, at 6:15, "Andrey Panin" <pazke@centrinvest.ru> wrote:
> 
> >On 067, 03 08, 2010 at 09:15:26PM -0800, James Lamanna wrote:
> >
> >>That's probably the case.
> >>It looks like 8250 doesn't know about this PCIe device at all.
> >>The Oxford PCI ID is not in pci_ids.h nor is the SIIG subsystem ID.
> >>I'll see if I can maybe work up a patch to support this device,
> >>since I've found
> >>the datasheet for the Oxford 4 port UART controller, but I may
> >>need some help.
> >>Or if anyone else (who has more experience with this) wants to
> >>formulate one,
> >>it would be greatly appreciated.
> >
> >Looks like you card can use existing code for Oxford Semiconductor
> >UARTs.
> >Can you test the attached patch for 2.6.33 ?
> 
> Hi Andrey,
> Coincidentally I found your patch for 2.6.28 that I was able to
> backport to 2.6.24. The card seems to be working great!
> Is this patch in mainline now?

Now I'm confused, because I can't remember SIIG related patches for 2.6.28.

Re: SIIG DP CyberSerial 4S PCIe Support

[Andrew Morton]

On Thu, 11 Mar 2010 16:45:08 +0300
"Andrey Panin" <pazke@centrinvest.ru> wrote:

> On 068, 03 09, 2010 at 07:09:21AM -0800, James Lamanna wrote:
> > On Mar 9, 2010, at 6:15, "Andrey Panin" <pazke@centrinvest.ru> wrote:
> > 
> > >On 067, 03 08, 2010 at 09:15:26PM -0800, James Lamanna wrote:
> > >
> > >>That's probably the case.
> > >>It looks like 8250 doesn't know about this PCIe device at all.
> > >>The Oxford PCI ID is not in pci_ids.h nor is the SIIG subsystem ID.
> > >>I'll see if I can maybe work up a patch to support this device,
> > >>since I've found
> > >>the datasheet for the Oxford 4 port UART controller, but I may
> > >>need some help.
> > >>Or if anyone else (who has more experience with this) wants to
> > >>formulate one,
> > >>it would be greatly appreciated.
> > >
> > >Looks like you card can use existing code for Oxford Semiconductor
> > >UARTs.
> > >Can you test the attached patch for 2.6.33 ?
> > 
> > Hi Andrey,
> > Coincidentally I found your patch for 2.6.28 that I was able to
> > backport to 2.6.24. The card seems to be working great!
> > Is this patch in mainline now?
> 
> Now I'm confused, because I can't remember SIIG related patches for 2.6.28.

I'm confused too.  If someone had a patch which they think needs to be
applied, please resend it?

Re: SIIG DP CyberSerial 4S PCIe Support

[James Lamanna]

On Thu, Mar 18, 2010 at 2:06 PM, Andrew Morton
<akpm@linux-foundation.org> wrote:
> On Thu, 11 Mar 2010 16:45:08 +0300
> "Andrey Panin" <pazke@centrinvest.ru> wrote:
>
>> On 068, 03 09, 2010 at 07:09:21AM -0800, James Lamanna wrote:
>> > On Mar 9, 2010, at 6:15, "Andrey Panin" <pazke@centrinvest.ru> wrote:
>> >
>> > >On 067, 03 08, 2010 at 09:15:26PM -0800, James Lamanna wrote:
>> > >
>> > >>That's probably the case.
>> > >>It looks like 8250 doesn't know about this PCIe device at all.
>> > >>The Oxford PCI ID is not in pci_ids.h nor is the SIIG subsystem ID.
>> > >>I'll see if I can maybe work up a patch to support this device,
>> > >>since I've found
>> > >>the datasheet for the Oxford 4 port UART controller, but I may
>> > >>need some help.
>> > >>Or if anyone else (who has more experience with this) wants to
>> > >>formulate one,
>> > >>it would be greatly appreciated.
>> > >
>> > >Looks like you card can use existing code for Oxford Semiconductor
>> > >UARTs.
>> > >Can you test the attached patch for 2.6.33 ?
>> >
>> > Hi Andrey,
>> > Coincidentally I found your patch for 2.6.28 that I was able to
>> > backport to 2.6.24. The card seems to be working great!
>> > Is this patch in mainline now?
>>
>> Now I'm confused, because I can't remember SIIG related patches for 2.6.28.
>
> I'm confused too.  If someone had a patch which they think needs to be
> applied, please resend it?

I believe this was the patch/diff that I saw:
http://www.linuxhq.com/kernel/v2.6/28/drivers/serial/8250_pci.c

So, from that, it looks like everything is in mainline. I had been
working with 2.6.24, which didn't have support.

-- James

Re: SIIG DP CyberSerial 4S PCIe Support

[Andrey Panin]

On 078, 03 19, 2010 at 07:05:38PM -0700, James Lamanna wrote:
> On Thu, Mar 18, 2010 at 2:06 PM, Andrew Morton
> <akpm@linux-foundation.org> wrote:
> > On Thu, 11 Mar 2010 16:45:08 +0300
> > "Andrey Panin" <pazke@centrinvest.ru> wrote:
> >
> >> On 068, 03 09, 2010 at 07:09:21AM -0800, James Lamanna wrote:
> >> > On Mar 9, 2010, at 6:15, "Andrey Panin" <pazke@centrinvest.ru> wrote:
> >> >
> >> > >On 067, 03 08, 2010 at 09:15:26PM -0800, James Lamanna wrote:
> >> > >
> >> > >>That's probably the case.
> >> > >>It looks like 8250 doesn't know about this PCIe device at all.
> >> > >>The Oxford PCI ID is not in pci_ids.h nor is the SIIG subsystem ID.
> >> > >>I'll see if I can maybe work up a patch to support this device,
> >> > >>since I've found
> >> > >>the datasheet for the Oxford 4 port UART controller, but I may
> >> > >>need some help.
> >> > >>Or if anyone else (who has more experience with this) wants to
> >> > >>formulate one,
> >> > >>it would be greatly appreciated.
> >> > >
> >> > >Looks like you card can use existing code for Oxford Semiconductor
> >> > >UARTs.
> >> > >Can you test the attached patch for 2.6.33 ?
> >> >
> >> > Hi Andrey,
> >> > Coincidentally I found your patch for 2.6.28 that I was able to
> >> > backport to 2.6.24. The card seems to be working great!
> >> > Is this patch in mainline now?
> >>
> >> Now I'm confused, because I can't remember SIIG related patches for 2.6.28.
> >
> > I'm confused too.  If someone had a patch which they think needs to be
> > applied, please resend it?
> 
> I believe this was the patch/diff that I saw:
> http://www.linuxhq.com/kernel/v2.6/28/drivers/serial/8250_pci.c

So you backported this patch and then applied my patch to get your card working ?

Re: SIIG DP CyberSerial 4S PCIe Support

[Andrey Panin]

On 078, 03 19, 2010 at 07:05:38PM -0700, James Lamanna wrote:
> On Thu, Mar 18, 2010 at 2:06 PM, Andrew Morton
> <akpm@linux-foundation.org> wrote:
> > On Thu, 11 Mar 2010 16:45:08 +0300
> > "Andrey Panin" <pazke@centrinvest.ru> wrote:
> >
> >> On 068, 03 09, 2010 at 07:09:21AM -0800, James Lamanna wrote:
> >> > On Mar 9, 2010, at 6:15, "Andrey Panin" <pazke@centrinvest.ru> wrote:
> >> >
> >> > >On 067, 03 08, 2010 at 09:15:26PM -0800, James Lamanna wrote:
> >> > >
> >> > >>That's probably the case.
> >> > >>It looks like 8250 doesn't know about this PCIe device at all.
> >> > >>The Oxford PCI ID is not in pci_ids.h nor is the SIIG subsystem ID.
> >> > >>I'll see if I can maybe work up a patch to support this device,
> >> > >>since I've found
> >> > >>the datasheet for the Oxford 4 port UART controller, but I may
> >> > >>need some help.
> >> > >>Or if anyone else (who has more experience with this) wants to
> >> > >>formulate one,
> >> > >>it would be greatly appreciated.
> >> > >
> >> > >Looks like you card can use existing code for Oxford Semiconductor
> >> > >UARTs.
> >> > >Can you test the attached patch for 2.6.33 ?
> >> >
> >> > Hi Andrey,
> >> > Coincidentally I found your patch for 2.6.28 that I was able to
> >> > backport to 2.6.24. The card seems to be working great!
> >> > Is this patch in mainline now?
> >>
> >> Now I'm confused, because I can't remember SIIG related patches for 2.6.28.
> >
> > I'm confused too.  If someone had a patch which they think needs to be
> > applied, please resend it?
> 
> I believe this was the patch/diff that I saw:
> http://www.linuxhq.com/kernel/v2.6/28/drivers/serial/8250_pci.c

So you backported this patch and then applied my patch to get your card working ?
--
To unsubscribe from this list: send the line "unsubscribe linux-serial" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html