[PATCH] imagemagick: convert to BBCLASSEXTEND and new staging

[PATCH] imagemagick: convert to BBCLASSEXTEND and new staging

[Thomas Zimmermann]

* imagemagick-6.3.5-10 doesn't configure with autoconf > 2.63
* problem: without removing imagemagick-native_6.3.5-10 the old version is build

Signed-off-by: Thomas Zimmermann <ml@vdm-design.de>
---
 recipes/imagemagick/imagemagick_6.4.4-1.bb |   11 +++++------
 1 files changed, 5 insertions(+), 6 deletions(-)

diff --git a/recipes/imagemagick/imagemagick_6.4.4-1.bb b/recipes/imagemagick/imagemagick_6.4.4-1.bb
index bc16b0c..b02ce26 100644
--- a/recipes/imagemagick/imagemagick_6.4.4-1.bb
+++ b/recipes/imagemagick/imagemagick_6.4.4-1.bb
@@ -3,8 +3,9 @@ SECTION = "console/utils"
 LICENSE = "GPL"
 # FIXME: There is much more checked libraries. All should be added or explicitly disabled to get consistent results.
 DEPENDS = "bzip2 jpeg libpng librsvg tiff zlib"
+DEPENDS_virtclass-native = "libtool-native bzip2-native jpeg-native libpng-native librsvg-native zlib-native"
 
-PR = "r3"
+PR = "r4"
 
 SRC_URI = "ftp://ftp.nluug.nl/pub/ImageMagick/ImageMagick-${PV}.tar.bz2 \
            file://PerlMagic_MakePatch;patch=1 \
@@ -14,15 +15,11 @@ IMVER = "6.4.4"
 
 S = "${WORKDIR}/ImageMagick-${IMVER}"
 
-inherit autotools binconfig pkgconfig
+inherit autotools_stage binconfig pkgconfig
 
 EXTRA_AUTORECONF += "--exclude=libtoolize"
 EXTRA_OECONF = "--program-prefix= --without-x --without-freetype --without-perl --disable-openmp"
 
-do_stage() {
-	autotools_stage_all
-}
-
 FILES_${PN} += "${libdir}/ImageMagick-${IMVER}/modules-Q16/*/*.so \
                 ${libdir}/ImageMagick-${IMVER}/modules-Q16/*/*.la \
                 ${libdir}/ImageMagick-${IMVER}/config/ \
@@ -32,5 +29,7 @@ FILES_${PN}-dev += "${libdir}/ImageMagick-${IMVER}/modules-Q16/*/*.a"
 
 FILES_${PN}-dbg += "${libdir}/ImageMagick-${IMVER}/modules-Q16/*/.debug/*"
 
+BBCLASSEXTEND = "native"
+
 LEAD_SONAME = "libMagickCore.so.*"
 
-- 
1.7.0.3

Re: [PATCH] imagemagick: convert to BBCLASSEXTEND and new staging

[Chris Larson]

On Tue, Mar 23, 2010 at 3:34 PM, Thomas Zimmermann <ml@vdm-design.de> wrote:

> * imagemagick-6.3.5-10 doesn't configure with autoconf > 2.63
> * problem: without removing imagemagick-native_6.3.5-10 the old version is
> build
>
> Signed-off-by: Thomas Zimmermann <ml@vdm-design.de>
> ---
>  recipes/imagemagick/imagemagick_6.4.4-1.bb |   11 +++++------
>  1 files changed, 5 insertions(+), 6 deletions(-)
>
> diff --git a/recipes/imagemagick/imagemagick_6.4.4-1.bbb/recipes/imagemagick/
> imagemagick_6.4.4-1.bb
> index bc16b0c..b02ce26 100644
> --- a/recipes/imagemagick/imagemagick_6.4.4-1.bb
> +++ b/recipes/imagemagick/imagemagick_6.4.4-1.bb
> @@ -3,8 +3,9 @@ SECTION = "console/utils"
>  LICENSE = "GPL"
>  # FIXME: There is much more checked libraries. All should be added or
> explicitly disabled to get consistent results.
>  DEPENDS = "bzip2 jpeg libpng librsvg tiff zlib"
> +DEPENDS_virtclass-native = "libtool-native bzip2-native jpeg-native
> libpng-native librsvg-native zlib-native"
>

This should not be necessary.  native.bbclass automatically sets deps on the
-native versions of what's in your DEPENDS.  Or was there a specific reason
behind adding libtool-native and removing tiff?
-- 
Christopher Larson
clarson at kergoth dot com
Founder - BitBake, OpenEmbedded, OpenZaurus
Maintainer - Tslib
Senior Software Engineer, Mentor Graphics

Re: [PATCH] imagemagick: convert to BBCLASSEXTEND and new staging

[Thomas Zimmermann]

Am Mittwoch 24 März 2010 01:48:58 schrieb Chris Larson:
> This should not be necessary.  native.bbclass automatically sets deps on
>  the -native versions of what's in your DEPENDS.  Or was there a specific
>  reason behind adding libtool-native and removing tiff?
> 
No there was no such a reason, i just copied it from imagemagick-
native_0.6.3.5-10 recipe.

The question is, do we convert 6.3.5-10 to BBCLASSEXTEND too, or do we remove 
that recipe, or is there a bug about mixed BBCLASSEXTEND and -native recipes, 
that -native recipes are preferred?

Re: [PATCH] imagemagick: convert to BBCLASSEXTEND and new staging

[Chris Larson]

On Wed, Mar 24, 2010 at 12:34 AM, Thomas Zimmermann <ml@vdm-design.de>wrote:

> Am Mittwoch 24 März 2010 01:48:58 schrieb Chris Larson:
> > This should not be necessary.  native.bbclass automatically sets deps on
> >  the -native versions of what's in your DEPENDS.  Or was there a specific
> >  reason behind adding libtool-native and removing tiff?
> >
> No there was no such a reason, i just copied it from imagemagick-
> native_0.6.3.5-10 recipe.
>
> The question is, do we convert 6.3.5-10 to BBCLASSEXTEND too, or do we
> remove
> that recipe, or is there a bug about mixed BBCLASSEXTEND and -native
> recipes,
> that -native recipes are preferred?


It seems to be a bug, yes.  Or questionable behavior, rather.  It's known.
 Best to convert both, unless you're confident no one would be affected by a
removal of the old -native.
-- 
Christopher Larson
clarson at kergoth dot com
Founder - BitBake, OpenEmbedded, OpenZaurus
Maintainer - Tslib
Senior Software Engineer, Mentor Graphics

[PATCH] imagemagick: convert to BBCLASSEXTEND and new staging

[Thomas Zimmermann]

* now imagemagick is buildable again with autoconf > 2.63
* tiff-native now exists, so no need to override DEPENDS of -native anymore

Signed-off-by: Thomas Zimmermann <ml@vdm-design.de>
---
 recipes/imagemagick/imagemagick-native_6.3.5-10.bb |    6 ------
 recipes/imagemagick/imagemagick_6.3.5-10.bb        |   10 ++++------
 recipes/imagemagick/imagemagick_6.4.4-1.bb         |   10 ++++------
 3 files changed, 8 insertions(+), 18 deletions(-)
 delete mode 100644 recipes/imagemagick/imagemagick-native_6.3.5-10.bb

diff --git a/recipes/imagemagick/imagemagick-native_6.3.5-10.bb b/recipes/imagemagick/imagemagick-native_6.3.5-10.bb
deleted file mode 100644
index d2efd36..0000000
--- a/recipes/imagemagick/imagemagick-native_6.3.5-10.bb
+++ /dev/null
@@ -1,6 +0,0 @@
-require imagemagick_${PV}.bb
-DEPENDS ="libtool-native"
-# FIXME: There is much more checked libraries. All should be added or explicitly disabled to get consistent results.
-# tiff-native does not exist
-DEPENDS += "bzip2-native jpeg-native libpng-native librsvg-native zlib-native"
-inherit native
diff --git a/recipes/imagemagick/imagemagick_6.3.5-10.bb b/recipes/imagemagick/imagemagick_6.3.5-10.bb
index b399741..58f3b23 100644
--- a/recipes/imagemagick/imagemagick_6.3.5-10.bb
+++ b/recipes/imagemagick/imagemagick_6.3.5-10.bb
@@ -2,7 +2,7 @@ DESCRIPTION = "ImageMagick is an image convertion tools"
 SECTION = "console/utils"
 LICENSE = "GPL"
 DEPENDS = "tiff jpeg libpng librsvg tiff zlib"
-PR = "r7"
+PR = "r8"
 
 SRC_URI = "ftp://ftp.nluug.nl/pub/ImageMagick/ImageMagick-${PV}.tar.bz2 \
            file://PerlMagic_MakePatch;patch=1 \
@@ -14,16 +14,12 @@ IMVER = "6.3.5"
 
 S = "${WORKDIR}/ImageMagick-${IMVER}"
 
-inherit autotools binconfig pkgconfig
+inherit autotools_stage binconfig pkgconfig
 
 EXTRA_AUTORECONF += "--exclude=libtoolize"
 EXTRA_OECONF = "--without-x --without-freetype --without-perl"
 EXTRA_OECONF_openprotium = "--without-x --without-freetype --without-xml --without-perl"
 
-do_stage() {
-	autotools_stage_all
-}
-
 FILES_${PN} += "${libdir}/ImageMagick-${IMVER}/modules-Q16/*/*.so \
                 ${libdir}/ImageMagick-${IMVER}/modules-Q16/*/*.la \
                 ${libdir}/ImageMagick-${IMVER}/config/ \
@@ -33,5 +29,7 @@ FILES_${PN}-dev += "${libdir}/ImageMagick-${IMVER}/modules-Q16/*/*.a"
 
 FILES_${PN}-dbg += "${libdir}/ImageMagick-${IMVER}/modules-Q16/*/.debug/*"
 
+BBCLASSEXTEND = "native"
+
 LEAD_SONAME = "libMagick.so.*"
 
diff --git a/recipes/imagemagick/imagemagick_6.4.4-1.bb b/recipes/imagemagick/imagemagick_6.4.4-1.bb
index bc16b0c..1b17664 100644
--- a/recipes/imagemagick/imagemagick_6.4.4-1.bb
+++ b/recipes/imagemagick/imagemagick_6.4.4-1.bb
@@ -4,7 +4,7 @@ LICENSE = "GPL"
 # FIXME: There is much more checked libraries. All should be added or explicitly disabled to get consistent results.
 DEPENDS = "bzip2 jpeg libpng librsvg tiff zlib"
 
-PR = "r3"
+PR = "r4"
 
 SRC_URI = "ftp://ftp.nluug.nl/pub/ImageMagick/ImageMagick-${PV}.tar.bz2 \
            file://PerlMagic_MakePatch;patch=1 \
@@ -14,15 +14,11 @@ IMVER = "6.4.4"
 
 S = "${WORKDIR}/ImageMagick-${IMVER}"
 
-inherit autotools binconfig pkgconfig
+inherit autotools_stage binconfig pkgconfig
 
 EXTRA_AUTORECONF += "--exclude=libtoolize"
 EXTRA_OECONF = "--program-prefix= --without-x --without-freetype --without-perl --disable-openmp"
 
-do_stage() {
-	autotools_stage_all
-}
-
 FILES_${PN} += "${libdir}/ImageMagick-${IMVER}/modules-Q16/*/*.so \
                 ${libdir}/ImageMagick-${IMVER}/modules-Q16/*/*.la \
                 ${libdir}/ImageMagick-${IMVER}/config/ \
@@ -32,5 +28,7 @@ FILES_${PN}-dev += "${libdir}/ImageMagick-${IMVER}/modules-Q16/*/*.a"
 
 FILES_${PN}-dbg += "${libdir}/ImageMagick-${IMVER}/modules-Q16/*/.debug/*"
 
+BBCLASSEXTEND = "native"
+
 LEAD_SONAME = "libMagickCore.so.*"
 
-- 
1.7.0.3

Re: [PATCH] imagemagick: convert to BBCLASSEXTEND and new staging

[Thomas Zimmermann]

Am Donnerstag 25 März 2010 09:54:32 schrieb Thomas Zimmermann:
> * now imagemagick is buildable again with autoconf > 2.63
> * tiff-native now exists, so no need to override DEPENDS of -native anymore
> 
> Signed-off-by: Thomas Zimmermann <ml@vdm-design.de>
> ---
>  recipes/imagemagick/imagemagick-native_6.3.5-10.bb |    6 ------
>  recipes/imagemagick/imagemagick_6.3.5-10.bb        |   10 ++++------
>  recipes/imagemagick/imagemagick_6.4.4-1.bb         |   10 ++++------
>  3 files changed, 8 insertions(+), 18 deletions(-)
>  delete mode 100644 recipes/imagemagick/imagemagick-native_6.3.5-10.bb

6.4.4-1 builds fine, but i can't try if 6.3.5 builds fine too, as it doesn't 
compile anymore for me because of to recent autoconf...

So it would be nice if someone can confirm that 6.3.5 builds fine too.

Re: [PATCH] imagemagick: convert to BBCLASSEXTEND and new staging

[Adrian Alonso]

Hi,

I test imagemagick_6.3.5-10.bb and it fails
due that my host system of autoconf > 2.63

I search a bit and found a patch in gnulib mailing list [1] that skips
openm4 configuration when autoconf > 2.62, applying it resolves the failure
with imagemagic_6.3.5-10;

Patches should be at patchwork queue.

[1] http://www.mail-archive.com/bug-gnulib@gnu.org/msg12387.html


On Thu, Mar 25, 2010 at 3:14 AM, Thomas Zimmermann <ml@vdm-design.de> wrote:

> Am Donnerstag 25 März 2010 09:54:32 schrieb Thomas Zimmermann:
> > * now imagemagick is buildable again with autoconf > 2.63
> > * tiff-native now exists, so no need to override DEPENDS of -native
> anymore
> >
> > Signed-off-by: Thomas Zimmermann <ml@vdm-design.de>
> > ---
> >  recipes/imagemagick/imagemagick-native_6.3.5-10.bb |    6 ------
> >  recipes/imagemagick/imagemagick_6.3.5-10.bb        |   10 ++++------
> >  recipes/imagemagick/imagemagick_6.4.4-1.bb         |   10 ++++------
> >  3 files changed, 8 insertions(+), 18 deletions(-)
> >  delete mode 100644 recipes/imagemagick/imagemagick-native_6.3.5-10.bb
>
> 6.4.4-1 builds fine, but i can't try if 6.3.5 builds fine too, as it
> doesn't
> compile anymore for me because of to recent autoconf...
>
> So it would be nice if someone can confirm that 6.3.5 builds fine too.
>
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel
>



-- 
Saludos
Adrian Alonso
http://aalonso.wordpress.com