* [PATCH] musb: Add extvbus in musb_board_data
@ 2010-02-24 4:30 Ajay Kumar Gupta
2010-03-23 12:46 ` Gupta, Ajay Kumar
0 siblings, 1 reply; 3+ messages in thread
From: Ajay Kumar Gupta @ 2010-02-24 4:30 UTC (permalink / raw)
To: linux-omap; +Cc: felipe.balbi, Ajay Kumar Gupta
EXTVBUS programming is required by OMAP3EVM REV >=E to supply 500mA
power so adding a flag which can be used by musb driver to program
EXTVBUS.
Signed-off-by: Ajay Kumar Gupta <ajay.gupta@ti.com>
---
Created against l-o master branch and on top of below patch.
[PATCH] musb: fix power field to hold all possible values
arch/arm/mach-omap2/board-omap3evm.c | 3 +++
arch/arm/mach-omap2/usb-musb.c | 1 +
arch/arm/plat-omap/include/plat/usb.h | 1 +
3 files changed, 5 insertions(+), 0 deletions(-)
diff --git a/arch/arm/mach-omap2/board-omap3evm.c b/arch/arm/mach-omap2/board-omap3evm.c
index d6bc88c..b7ea9b7 100644
--- a/arch/arm/mach-omap2/board-omap3evm.c
+++ b/arch/arm/mach-omap2/board-omap3evm.c
@@ -702,6 +702,9 @@ static void __init omap3_evm_init(void)
omap_mux_init_gpio(21, OMAP_PIN_INPUT_PULLUP);
ehci_pdata.reset_gpio_port[1] = 21;
+ /* EVM REV >= E can supply 500mA with EXTVBUS programming */
+ musb_board_data.power = 500;
+ musb_board_data.extvbus = 1;
} else {
/* setup EHCI phy reset on MDC */
omap_mux_init_gpio(135, OMAP_PIN_OUTPUT);
diff --git a/arch/arm/mach-omap2/usb-musb.c b/arch/arm/mach-omap2/usb-musb.c
index 53a9638..17726ac 100644
--- a/arch/arm/mach-omap2/usb-musb.c
+++ b/arch/arm/mach-omap2/usb-musb.c
@@ -106,6 +106,7 @@ void __init usb_musb_init(struct omap_musb_board_data *board_data)
musb_plat.board_data = board_data;
musb_plat.power = board_data->power >> 1;
musb_plat.mode = board_data->mode;
+ musb_plat.extvbus = board_data->extvbus;
if (platform_device_register(&musb_device) < 0)
printk(KERN_ERR "Unable to register HS-USB (MUSB) device\n");
diff --git a/arch/arm/plat-omap/include/plat/usb.h b/arch/arm/plat-omap/include/plat/usb.h
index b181297..d82bf77 100644
--- a/arch/arm/plat-omap/include/plat/usb.h
+++ b/arch/arm/plat-omap/include/plat/usb.h
@@ -47,6 +47,7 @@ struct omap_musb_board_data {
u8 interface_type;
u8 mode;
u16 power;
+ unsigned extvbus:1;
};
enum musb_interface {MUSB_INTERFACE_ULPI, MUSB_INTERFACE_UTMI};
--
1.6.2.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* RE: [PATCH] musb: Add extvbus in musb_board_data
2010-02-24 4:30 [PATCH] musb: Add extvbus in musb_board_data Ajay Kumar Gupta
@ 2010-03-23 12:46 ` Gupta, Ajay Kumar
2010-03-24 9:58 ` Felipe Balbi
0 siblings, 1 reply; 3+ messages in thread
From: Gupta, Ajay Kumar @ 2010-03-23 12:46 UTC (permalink / raw)
To: Gupta, Ajay Kumar, linux-omap; +Cc: felipe.balbi
Hi,
> -----Original Message-----
> From: Gupta, Ajay Kumar
> Sent: Wednesday, February 24, 2010 10:01 AM
> To: linux-omap@vger.kernel.org
> Cc: felipe.balbi@nokia.com; Gupta, Ajay Kumar
> Subject: [PATCH] musb: Add extvbus in musb_board_data
>
> EXTVBUS programming is required by OMAP3EVM REV >=E to supply 500mA
> power so adding a flag which can be used by musb driver to program
> EXTVBUS.
Felipe,
Any comment on this one ?
Regards,
ajay
>
> Signed-off-by: Ajay Kumar Gupta <ajay.gupta@ti.com>
> ---
> Created against l-o master branch and on top of below patch.
>
> [PATCH] musb: fix power field to hold all possible values
>
> arch/arm/mach-omap2/board-omap3evm.c | 3 +++
> arch/arm/mach-omap2/usb-musb.c | 1 +
> arch/arm/plat-omap/include/plat/usb.h | 1 +
> 3 files changed, 5 insertions(+), 0 deletions(-)
>
> diff --git a/arch/arm/mach-omap2/board-omap3evm.c b/arch/arm/mach-
> omap2/board-omap3evm.c
> index d6bc88c..b7ea9b7 100644
> --- a/arch/arm/mach-omap2/board-omap3evm.c
> +++ b/arch/arm/mach-omap2/board-omap3evm.c
> @@ -702,6 +702,9 @@ static void __init omap3_evm_init(void)
> omap_mux_init_gpio(21, OMAP_PIN_INPUT_PULLUP);
> ehci_pdata.reset_gpio_port[1] = 21;
>
> + /* EVM REV >= E can supply 500mA with EXTVBUS programming */
> + musb_board_data.power = 500;
> + musb_board_data.extvbus = 1;
> } else {
> /* setup EHCI phy reset on MDC */
> omap_mux_init_gpio(135, OMAP_PIN_OUTPUT);
> diff --git a/arch/arm/mach-omap2/usb-musb.c b/arch/arm/mach-omap2/usb-
> musb.c
> index 53a9638..17726ac 100644
> --- a/arch/arm/mach-omap2/usb-musb.c
> +++ b/arch/arm/mach-omap2/usb-musb.c
> @@ -106,6 +106,7 @@ void __init usb_musb_init(struct omap_musb_board_data
> *board_data)
> musb_plat.board_data = board_data;
> musb_plat.power = board_data->power >> 1;
> musb_plat.mode = board_data->mode;
> + musb_plat.extvbus = board_data->extvbus;
>
> if (platform_device_register(&musb_device) < 0)
> printk(KERN_ERR "Unable to register HS-USB (MUSB) device\n");
> diff --git a/arch/arm/plat-omap/include/plat/usb.h b/arch/arm/plat-
> omap/include/plat/usb.h
> index b181297..d82bf77 100644
> --- a/arch/arm/plat-omap/include/plat/usb.h
> +++ b/arch/arm/plat-omap/include/plat/usb.h
> @@ -47,6 +47,7 @@ struct omap_musb_board_data {
> u8 interface_type;
> u8 mode;
> u16 power;
> + unsigned extvbus:1;
> };
>
> enum musb_interface {MUSB_INTERFACE_ULPI, MUSB_INTERFACE_UTMI};
> --
> 1.6.2.4
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] musb: Add extvbus in musb_board_data
2010-03-23 12:46 ` Gupta, Ajay Kumar
@ 2010-03-24 9:58 ` Felipe Balbi
0 siblings, 0 replies; 3+ messages in thread
From: Felipe Balbi @ 2010-03-24 9:58 UTC (permalink / raw)
To: ext Gupta, Ajay Kumar; +Cc: linux-omap, Balbi Felipe (Nokia-D/Helsinki)
On Tue, Mar 23, 2010 at 01:46:18PM +0100, ext Gupta, Ajay Kumar wrote:
>Hi,
>> -----Original Message-----
>> From: Gupta, Ajay Kumar
>> Sent: Wednesday, February 24, 2010 10:01 AM
>> To: linux-omap@vger.kernel.org
>> Cc: felipe.balbi@nokia.com; Gupta, Ajay Kumar
>> Subject: [PATCH] musb: Add extvbus in musb_board_data
>>
>> EXTVBUS programming is required by OMAP3EVM REV >=E to supply 500mA
>> power so adding a flag which can be used by musb driver to program
>> EXTVBUS.
>
>Felipe,
>
>Any comment on this one ?
applied, thanks
--
balbi
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2010-03-24 9:59 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2010-02-24 4:30 [PATCH] musb: Add extvbus in musb_board_data Ajay Kumar Gupta
2010-03-23 12:46 ` Gupta, Ajay Kumar
2010-03-24 9:58 ` Felipe Balbi
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.