* [patch] rds: cleanup: remove unneeded variable
@ 2010-03-24 11:57 ` Dan Carpenter
0 siblings, 0 replies; 4+ messages in thread
From: Dan Carpenter @ 2010-03-24 11:57 UTC (permalink / raw)
To: Andy Grover
Cc: David S. Miller, Stephen Hemminger, Alexey Dobriyan, Eric Paris,
rds-devel, netdev, kernel-janitors
We never use "sk" so this patch removes it.
Signed-off-by: Dan Carpenter <error27@gmail.com>
diff --git a/net/rds/af_rds.c b/net/rds/af_rds.c
index 853c52b..9abc825 100644
--- a/net/rds/af_rds.c
+++ b/net/rds/af_rds.c
@@ -446,7 +446,6 @@ static void rds_sock_inc_info(struct socket *sock, unsigned int len,
struct rds_info_lengths *lens)
{
struct rds_sock *rs;
- struct sock *sk;
struct rds_incoming *inc;
unsigned long flags;
unsigned int total = 0;
@@ -456,7 +455,6 @@ static void rds_sock_inc_info(struct socket *sock, unsigned int len,
spin_lock_irqsave(&rds_sock_lock, flags);
list_for_each_entry(rs, &rds_sock_list, rs_item) {
- sk = rds_rs_to_sk(rs);
read_lock(&rs->rs_recv_lock);
/* XXX too lazy to maintain counts.. */
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [patch] rds: cleanup: remove unneeded variable
@ 2010-03-24 11:57 ` Dan Carpenter
0 siblings, 0 replies; 4+ messages in thread
From: Dan Carpenter @ 2010-03-24 11:57 UTC (permalink / raw)
To: Andy Grover
Cc: David S. Miller, Stephen Hemminger, Alexey Dobriyan, Eric Paris,
rds-devel, netdev, kernel-janitors
We never use "sk" so this patch removes it.
Signed-off-by: Dan Carpenter <error27@gmail.com>
diff --git a/net/rds/af_rds.c b/net/rds/af_rds.c
index 853c52b..9abc825 100644
--- a/net/rds/af_rds.c
+++ b/net/rds/af_rds.c
@@ -446,7 +446,6 @@ static void rds_sock_inc_info(struct socket *sock, unsigned int len,
struct rds_info_lengths *lens)
{
struct rds_sock *rs;
- struct sock *sk;
struct rds_incoming *inc;
unsigned long flags;
unsigned int total = 0;
@@ -456,7 +455,6 @@ static void rds_sock_inc_info(struct socket *sock, unsigned int len,
spin_lock_irqsave(&rds_sock_lock, flags);
list_for_each_entry(rs, &rds_sock_list, rs_item) {
- sk = rds_rs_to_sk(rs);
read_lock(&rs->rs_recv_lock);
/* XXX too lazy to maintain counts.. */
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [patch] rds: cleanup: remove unneeded variable
2010-03-24 11:57 ` Dan Carpenter
@ 2010-03-24 20:37 ` David Miller
-1 siblings, 0 replies; 4+ messages in thread
From: David Miller @ 2010-03-24 20:37 UTC (permalink / raw)
To: error27
Cc: andy.grover, shemminger, adobriyan, eparis, rds-devel, netdev,
kernel-janitors
From: Dan Carpenter <error27@gmail.com>
Date: Wed, 24 Mar 2010 14:57:30 +0300
> We never use "sk" so this patch removes it.
>
> Signed-off-by: Dan Carpenter <error27@gmail.com>
Applied, thanks Dan.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [patch] rds: cleanup: remove unneeded variable
@ 2010-03-24 20:37 ` David Miller
0 siblings, 0 replies; 4+ messages in thread
From: David Miller @ 2010-03-24 20:37 UTC (permalink / raw)
To: error27
Cc: andy.grover, shemminger, adobriyan, eparis, rds-devel, netdev,
kernel-janitors
From: Dan Carpenter <error27@gmail.com>
Date: Wed, 24 Mar 2010 14:57:30 +0300
> We never use "sk" so this patch removes it.
>
> Signed-off-by: Dan Carpenter <error27@gmail.com>
Applied, thanks Dan.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2010-03-24 20:37 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2010-03-24 11:57 [patch] rds: cleanup: remove unneeded variable Dan Carpenter
2010-03-24 11:57 ` Dan Carpenter
2010-03-24 20:37 ` David Miller
2010-03-24 20:37 ` David Miller
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.