All of lore.kernel.org
 help / color / mirror / Atom feed
* [RFC/PATCH] Perl 5.10.1 and a bunch of modules
@ 2010-03-18 19:12 Roman I Khimov
  2010-03-18 19:36 ` Frans Meulenbroeks
                   ` (3 more replies)
  0 siblings, 4 replies; 24+ messages in thread
From: Roman I Khimov @ 2010-03-18 19:12 UTC (permalink / raw)
  To: openembedded-devel

[-- Attachment #1: Type: Text/Plain, Size: 486 bytes --]

Hello all.

As perl 5.10.1 is a big patch by itself and series overall is 42 patches and I 
don't want to banned from list for spam ;), I've commited that to the 
"rik/perl-5.10" branch of OE repo.

In general, the most interesting and the most requiring review are the first 
4, all the other are just various modules. So, please 
review/try/test/ack/nack.

-- 
 http://roman.khimov.ru
mailto: roman@khimov.ru
gpg --keyserver hkp://subkeys.pgp.net --recv-keys 0xE5E055C3

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 205 bytes --]

^ permalink raw reply	[flat|nested] 24+ messages in thread

* Re: [RFC/PATCH] Perl 5.10.1 and a bunch of modules
  2010-03-18 19:12 [RFC/PATCH] Perl 5.10.1 and a bunch of modules Roman I Khimov
@ 2010-03-18 19:36 ` Frans Meulenbroeks
  2010-03-18 19:46   ` Roman I Khimov
  2010-03-18 19:50 ` Roman I Khimov
                   ` (2 subsequent siblings)
  3 siblings, 1 reply; 24+ messages in thread
From: Frans Meulenbroeks @ 2010-03-18 19:36 UTC (permalink / raw)
  To: openembedded-devel

2010/3/18 Roman I Khimov <roman@khimov.ru>:
> Hello all.
>
> As perl 5.10.1 is a big patch by itself and series overall is 42 patches and I
> don't want to banned from list for spam ;), I've commited that to the
> "rik/perl-5.10" branch of OE repo.
>
> In general, the most interesting and the most requiring review are the first
> 4, all the other are just various modules. So, please
> review/try/test/ack/nack.
>
Nice work Roman!
Any particular reason not to go to 5.11?

BTW had some issues with perl in the past where it came to path's (in
perl-config or something like that).
Also I'm not sure whether all the native recipes we have now are really needed.
Perhaps the new staging will take care of that. Do you have any idea?

Frans.



^ permalink raw reply	[flat|nested] 24+ messages in thread

* Re: [RFC/PATCH] Perl 5.10.1 and a bunch of modules
  2010-03-18 19:36 ` Frans Meulenbroeks
@ 2010-03-18 19:46   ` Roman I Khimov
  0 siblings, 0 replies; 24+ messages in thread
From: Roman I Khimov @ 2010-03-18 19:46 UTC (permalink / raw)
  To: openembedded-devel

[-- Attachment #1: Type: Text/Plain, Size: 1218 bytes --]

В сообщении от Четверг 18 марта 2010 22:36:57 автор Frans Meulenbroeks 
написал:
> 2010/3/18 Roman I Khimov <roman@khimov.ru>:
> > Hello all.
> >
> > As perl 5.10.1 is a big patch by itself and series overall is 42 patches
> > and I don't want to banned from list for spam ;), I've commited that to
> > the "rik/perl-5.10" branch of OE repo.
> >
> > In general, the most interesting and the most requiring review are the
> > first 4, all the other are just various modules. So, please
> > review/try/test/ack/nack.
> 
> Nice work Roman!

Thanks.

> Any particular reason not to go to 5.11?

AFAIK, 5.11 is development branch and we're more interested in stable.

> Also I'm not sure whether all the native recipes we have now are really
>  needed. Perhaps the new staging will take care of that. Do you have any
>  idea?

Most of -native were converted to BBCLASSEXTEND and those are at least 
harmless, I think. And then some modules check for dependencies when 
configuring, so -native version is needed for those checks to succeed.

-- 
 http://roman.khimov.ru
mailto: roman@khimov.ru
gpg --keyserver hkp://subkeys.pgp.net --recv-keys 0xE5E055C3

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 205 bytes --]

^ permalink raw reply	[flat|nested] 24+ messages in thread

* Re: [RFC/PATCH] Perl 5.10.1 and a bunch of modules
  2010-03-18 19:12 [RFC/PATCH] Perl 5.10.1 and a bunch of modules Roman I Khimov
  2010-03-18 19:36 ` Frans Meulenbroeks
@ 2010-03-18 19:50 ` Roman I Khimov
  2010-03-18 20:30 ` Koen Kooi
  2010-03-20 14:49 ` Koen Kooi
  3 siblings, 0 replies; 24+ messages in thread
From: Roman I Khimov @ 2010-03-18 19:50 UTC (permalink / raw)
  To: openembedded-devel

[-- Attachment #1: Type: Text/Plain, Size: 241 bytes --]

BTW, I also think that we should drop versions 5.8.4 and 5.8.7, I see no 
single reason for them to stay in March 2010.

-- 
 http://roman.khimov.ru
mailto: roman@khimov.ru
gpg --keyserver hkp://subkeys.pgp.net --recv-keys 0xE5E055C3

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 205 bytes --]

^ permalink raw reply	[flat|nested] 24+ messages in thread

* Re: [RFC/PATCH] Perl 5.10.1 and a bunch of modules
  2010-03-18 19:12 [RFC/PATCH] Perl 5.10.1 and a bunch of modules Roman I Khimov
  2010-03-18 19:36 ` Frans Meulenbroeks
  2010-03-18 19:50 ` Roman I Khimov
@ 2010-03-18 20:30 ` Koen Kooi
  2010-03-18 20:47   ` Roman I Khimov
  2010-03-20 14:49 ` Koen Kooi
  3 siblings, 1 reply; 24+ messages in thread
From: Koen Kooi @ 2010-03-18 20:30 UTC (permalink / raw)
  To: openembedded-devel

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 18-03-10 20:12, Roman I Khimov wrote:
> Hello all.
> 
> As perl 5.10.1 is a big patch by itself and series overall is 42 patches and I 
> don't want to banned from list for spam ;), I've commited that to the 
> "rik/perl-5.10" branch of OE repo.
> 
> In general, the most interesting and the most requiring review are the first 
> 4, all the other are just various modules. So, please 
> review/try/test/ack/nack.

Do these include the poky tweaks to make new-style staging work (needs
cpan changes as well iirc)?

regards,

Koen
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.5 (Darwin)

iD8DBQFLoo1LMkyGM64RGpERAjowAKCGmzq0A+uxg7jbfi+P8n4MMn253gCeIHmo
ybvoQBgcdGq/ENNmBvxq0yk=
=ZrAB
-----END PGP SIGNATURE-----




^ permalink raw reply	[flat|nested] 24+ messages in thread

* Re: [RFC/PATCH] Perl 5.10.1 and a bunch of modules
  2010-03-18 20:30 ` Koen Kooi
@ 2010-03-18 20:47   ` Roman I Khimov
  2010-03-18 21:04     ` Roman I Khimov
  0 siblings, 1 reply; 24+ messages in thread
From: Roman I Khimov @ 2010-03-18 20:47 UTC (permalink / raw)
  To: openembedded-devel

[-- Attachment #1: Type: Text/Plain, Size: 1005 bytes --]

В сообщении от Четверг 18 марта 2010 23:30:03 автор Koen Kooi написал:
> On 18-03-10 20:12, Roman I Khimov wrote:
> > Hello all.
> >
> > As perl 5.10.1 is a big patch by itself and series overall is 42 patches
> > and I don't want to banned from list for spam ;), I've commited that to
> > the "rik/perl-5.10" branch of OE repo.
> >
> > In general, the most interesting and the most requiring review are the
> > first 4, all the other are just various modules. So, please
> > review/try/test/ack/nack.
> 
> Do these include the poky tweaks to make new-style staging work (needs
> cpan changes as well iirc)?

No. You mean, this one?
http://git.pokylinux.org/cgit.cgi/poky/commit/?id=ca5f36ee6ad756e1e540288a56a504c1d8ecc7a3

Looks like a good thing to have, so if Richard will push it to OE.dev I can do 
a rebase of my patchset.

-- 
 http://roman.khimov.ru
mailto: roman@khimov.ru
gpg --keyserver hkp://subkeys.pgp.net --recv-keys 0xE5E055C3

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 205 bytes --]

^ permalink raw reply	[flat|nested] 24+ messages in thread

* Re: [RFC/PATCH] Perl 5.10.1 and a bunch of modules
  2010-03-18 20:47   ` Roman I Khimov
@ 2010-03-18 21:04     ` Roman I Khimov
  2010-03-18 21:23       ` Roman I Khimov
  0 siblings, 1 reply; 24+ messages in thread
From: Roman I Khimov @ 2010-03-18 21:04 UTC (permalink / raw)
  To: openembedded-devel

[-- Attachment #1: Type: Text/Plain, Size: 589 bytes --]

В сообщении от Четверг 18 марта 2010 23:47:01 автор Roman I Khimov написал:
> No. You mean, this one?
> http://git.pokylinux.org/cgit.cgi/poky/commit/?id=ca5f36ee6ad756e1e540288a5
> 6a504c1d8ecc7a3
> 
> Looks like a good thing to have, so if Richard will push it to OE.dev I can
>  do a rebase of my patchset.

Actually, the better sequence is
 * drop 5.8.4 and 5.8.7
 * bring in staging changes
 * bring in 5.10.1

I'll prepare 5.8.4/5.8.7 removal patch.

-- 
 http://roman.khimov.ru
mailto: roman@khimov.ru
gpg --keyserver hkp://subkeys.pgp.net --recv-keys 0xE5E055C3

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 205 bytes --]

^ permalink raw reply	[flat|nested] 24+ messages in thread

* Re: [RFC/PATCH] Perl 5.10.1 and a bunch of modules
  2010-03-18 21:04     ` Roman I Khimov
@ 2010-03-18 21:23       ` Roman I Khimov
  2010-03-19 21:05         ` Roman I Khimov
  0 siblings, 1 reply; 24+ messages in thread
From: Roman I Khimov @ 2010-03-18 21:23 UTC (permalink / raw)
  To: openembedded-devel

[-- Attachment #1: Type: Text/Plain, Size: 1115 bytes --]

В сообщении от Пятница 19 марта 2010 00:04:30 автор Roman I Khimov написал:
> В сообщении от Четверг 18 марта 2010 23:47:01 автор Roman I Khimov написал:
> > No. You mean, this one?
> > http://git.pokylinux.org/cgit.cgi/poky/commit/?id=ca5f36ee6ad756e1e540288
> >a5 6a504c1d8ecc7a3
> >
> > Looks like a good thing to have, so if Richard will push it to OE.dev I
> > can do a rebase of my patchset.
> 
> Actually, the better sequence is
>  * drop 5.8.4 and 5.8.7
>  * bring in staging changes
>  * bring in 5.10.1
> 
> I'll prepare 5.8.4/5.8.7 removal patch.

Updated rik/perl-5.10 branch with removal patch, please ACK.

BTW, if it's not intentional, the commit mentioned above has a bug in cpan-
base in

-    if is_new_perl(d) == "yes":
-             libdirs = libdir + '/perl5'
-    else:
-                libdirs = libdir + '/*/*/perl5'
+    libdirs = libdir + '/*/*/perl5'

Shouldn't it be

+    libdirs = libdir + '/perl5'

as we're left with new perl only?

-- 
 http://roman.khimov.ru
mailto: roman@khimov.ru
gpg --keyserver hkp://subkeys.pgp.net --recv-keys 0xE5E055C3

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 205 bytes --]

^ permalink raw reply	[flat|nested] 24+ messages in thread

* Re: [RFC/PATCH] Perl 5.10.1 and a bunch of modules
  2010-03-18 21:23       ` Roman I Khimov
@ 2010-03-19 21:05         ` Roman I Khimov
  2010-03-19 21:12           ` Graeme Gregory
  2010-03-23 13:51           ` Roman I Khimov
  0 siblings, 2 replies; 24+ messages in thread
From: Roman I Khimov @ 2010-03-19 21:05 UTC (permalink / raw)
  To: openembedded-devel

[-- Attachment #1: Type: Text/Plain, Size: 1394 bytes --]

В сообщении от Пятница 19 марта 2010 00:23:25 автор Roman I Khimov написал:
> В сообщении от Пятница 19 марта 2010 00:04:30 автор Roman I Khimov написал:
> > В сообщении от Четверг 18 марта 2010 23:47:01 автор Roman I Khimov 
написал:
> > > No. You mean, this one?
> > > http://git.pokylinux.org/cgit.cgi/poky/commit/?id=ca5f36ee6ad756e1e5402
> > >88 a5 6a504c1d8ecc7a3
> > >
> > > Looks like a good thing to have, so if Richard will push it to OE.dev I
> > > can do a rebase of my patchset.
> >
> > Actually, the better sequence is
> >  * drop 5.8.4 and 5.8.7
> >  * bring in staging changes
> >  * bring in 5.10.1
> >
> > I'll prepare 5.8.4/5.8.7 removal patch.
> 
> Updated rik/perl-5.10 branch with removal patch, please ACK.

Tried to compile for arm, succeeded with perl, discovered and fixed some 
problems in modules. Updated the branch.

I think I need some ACK's for dusty old Perl versions removal and then 
Richard's Perl staging update could be merged better on top of that (CC'ing 
Richard) and than I'll update 5.10.1 to new staging and push the series. At 
least, that's how I think it should be. If there are any problems with staging 
update and it's not ready to be pushed in OE.dev, I think we can merge 5.10.1 
as it is now.

-- 
 http://roman.khimov.ru
mailto: roman@khimov.ru
gpg --keyserver hkp://subkeys.pgp.net --recv-keys 0xE5E055C3

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 205 bytes --]

^ permalink raw reply	[flat|nested] 24+ messages in thread

* Re: [RFC/PATCH] Perl 5.10.1 and a bunch of modules
  2010-03-19 21:05         ` Roman I Khimov
@ 2010-03-19 21:12           ` Graeme Gregory
  2010-03-19 22:47             ` Koen Kooi
  2010-03-20  8:49             ` Frans Meulenbroeks
  2010-03-23 13:51           ` Roman I Khimov
  1 sibling, 2 replies; 24+ messages in thread
From: Graeme Gregory @ 2010-03-19 21:12 UTC (permalink / raw)
  To: openembedded-devel

On Sat, Mar 20, 2010 at 12:05:35AM +0300, Roman I Khimov wrote:
> В сообщении от Пятница 19 марта 2010 00:23:25 автор Roman I Khimov написал:
> > В сообщении от Пятница 19 марта 2010 00:04:30 автор Roman I Khimov написал:
> > > В сообщении от Четверг 18 марта 2010 23:47:01 автор Roman I Khimov 
> написал:
> > > > No. You mean, this one?
> > > > http://git.pokylinux.org/cgit.cgi/poky/commit/?id=ca5f36ee6ad756e1e5402
> > > >88 a5 6a504c1d8ecc7a3
> > > >
> > > > Looks like a good thing to have, so if Richard will push it to OE.dev I
> > > > can do a rebase of my patchset.
> > >
> > > Actually, the better sequence is
> > >  * drop 5.8.4 and 5.8.7
> > >  * bring in staging changes
> > >  * bring in 5.10.1
> > >
> > > I'll prepare 5.8.4/5.8.7 removal patch.
> > 
> > Updated rik/perl-5.10 branch with removal patch, please ACK.
> 
> Tried to compile for arm, succeeded with perl, discovered and fixed some 
> problems in modules. Updated the branch.
> 
> I think I need some ACK's for dusty old Perl versions removal and then 
> Richard's Perl staging update could be merged better on top of that (CC'ing 
> Richard) and than I'll update 5.10.1 to new staging and push the series. At 
> least, that's how I think it should be. If there are any problems with staging 
> update and it's not ready to be pushed in OE.dev, I think we can merge 5.10.1 
> as it is now.
> 
For removal of old perl versions

Acked-by: Graeme Gregory <dp@xora.org.uk>




^ permalink raw reply	[flat|nested] 24+ messages in thread

* Re: [RFC/PATCH] Perl 5.10.1 and a bunch of modules
  2010-03-19 21:12           ` Graeme Gregory
@ 2010-03-19 22:47             ` Koen Kooi
  2010-03-20  8:49             ` Frans Meulenbroeks
  1 sibling, 0 replies; 24+ messages in thread
From: Koen Kooi @ 2010-03-19 22:47 UTC (permalink / raw)
  To: openembedded-devel

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 19-03-10 22:12, Graeme Gregory wrote:
> On Sat, Mar 20, 2010 at 12:05:35AM +0300, Roman I Khimov wrote:
>> В сообщении от Пятница 19 марта 2010 00:23:25 автор Roman I Khimov написал:
>>> В сообщении от Пятница 19 марта 2010 00:04:30 автор Roman I Khimov написал:
>>>> В сообщении от Четверг 18 марта 2010 23:47:01 автор Roman I Khimov 
>> написал:
>>>>> No. You mean, this one?
>>>>> http://git.pokylinux.org/cgit.cgi/poky/commit/?id=ca5f36ee6ad756e1e5402
>>>>> 88 a5 6a504c1d8ecc7a3
>>>>>
>>>>> Looks like a good thing to have, so if Richard will push it to OE.dev I
>>>>> can do a rebase of my patchset.
>>>>
>>>> Actually, the better sequence is
>>>>  * drop 5.8.4 and 5.8.7
>>>>  * bring in staging changes
>>>>  * bring in 5.10.1
>>>>
>>>> I'll prepare 5.8.4/5.8.7 removal patch.
>>>
>>> Updated rik/perl-5.10 branch with removal patch, please ACK.
>>
>> Tried to compile for arm, succeeded with perl, discovered and fixed some 
>> problems in modules. Updated the branch.
>>
>> I think I need some ACK's for dusty old Perl versions removal and then 
>> Richard's Perl staging update could be merged better on top of that (CC'ing 
>> Richard) and than I'll update 5.10.1 to new staging and push the series. At 
>> least, that's how I think it should be. If there are any problems with staging 
>> update and it's not ready to be pushed in OE.dev, I think we can merge 5.10.1 
>> as it is now.
>>
> For removal of old perl versions
> 
> Acked-by: Graeme Gregory <dp@xora.org.uk>

Acked-by: Koen Kooi <koen@openembedded.org>
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.5 (Darwin)

iD8DBQFLo/70MkyGM64RGpERAixEAJwJOkgBATjeiofMEyyZGpH4WhMk8ACeMn2t
4wFDmIwNNd1tgnO0Syx94dE=
=Vzni
-----END PGP SIGNATURE-----




^ permalink raw reply	[flat|nested] 24+ messages in thread

* Re: [RFC/PATCH] Perl 5.10.1 and a bunch of modules
  2010-03-19 21:12           ` Graeme Gregory
  2010-03-19 22:47             ` Koen Kooi
@ 2010-03-20  8:49             ` Frans Meulenbroeks
  1 sibling, 0 replies; 24+ messages in thread
From: Frans Meulenbroeks @ 2010-03-20  8:49 UTC (permalink / raw)
  To: openembedded-devel

2010/3/19 Graeme Gregory <dp@xora.org.uk>:
> On Sat, Mar 20, 2010 at 12:05:35AM +0300, Roman I Khimov wrote:
>> В сообщении от Пятница 19 марта 2010 00:23:25 автор Roman I Khimov написал:
>> > В сообщении от Пятница 19 марта 2010 00:04:30 автор Roman I Khimov написал:
>> > > В сообщении от Четверг 18 марта 2010 23:47:01 автор Roman I Khimov
>> написал:
>> > > > No. You mean, this one?
>> > > > http://git.pokylinux.org/cgit.cgi/poky/commit/?id=ca5f36ee6ad756e1e5402
>> > > >88 a5 6a504c1d8ecc7a3
>> > > >
>> > > > Looks like a good thing to have, so if Richard will push it to OE.dev I
>> > > > can do a rebase of my patchset.
>> > >
>> > > Actually, the better sequence is
>> > >  * drop 5.8.4 and 5.8.7
>> > >  * bring in staging changes
>> > >  * bring in 5.10.1
>> > >
>> > > I'll prepare 5.8.4/5.8.7 removal patch.
>> >
>> > Updated rik/perl-5.10 branch with removal patch, please ACK.
>>
>> Tried to compile for arm, succeeded with perl, discovered and fixed some
>> problems in modules. Updated the branch.
>>
>> I think I need some ACK's for dusty old Perl versions removal and then
>> Richard's Perl staging update could be merged better on top of that (CC'ing
>> Richard) and than I'll update 5.10.1 to new staging and push the series. At
>> least, that's how I think it should be. If there are any problems with staging
>> update and it's not ready to be pushed in OE.dev, I think we can merge 5.10.1
>> as it is now.
>>
> For removal of old perl versions
>
> Acked-by: Graeme Gregory <dp@xora.org.uk>

 For removal of old perl versions
Acked-by: Frans Meulenbroeks <fransmeulenbroeks@gmail.com>



^ permalink raw reply	[flat|nested] 24+ messages in thread

* Re: [RFC/PATCH] Perl 5.10.1 and a bunch of modules
  2010-03-18 19:12 [RFC/PATCH] Perl 5.10.1 and a bunch of modules Roman I Khimov
                   ` (2 preceding siblings ...)
  2010-03-18 20:30 ` Koen Kooi
@ 2010-03-20 14:49 ` Koen Kooi
  2010-03-21 12:05   ` Roman I Khimov
  3 siblings, 1 reply; 24+ messages in thread
From: Koen Kooi @ 2010-03-20 14:49 UTC (permalink / raw)
  To: openembedded-devel

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 18-03-10 20:12, Roman I Khimov wrote:
> Hello all.
> 
> As perl 5.10.1 is a big patch by itself and series overall is 42 patches and I 
> don't want to banned from list for spam ;), I've commited that to the 
> "rik/perl-5.10" branch of OE repo.
> 
> In general, the most interesting and the most requiring review are the first 
> 4, all the other are just various modules. So, please 
> review/try/test/ack/nack.

As a generic remark, can we have a master include file for INC_PR so
perl modules get rebuilt automagically when something in perl changes?

regards,

Koen
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.5 (Darwin)

iD8DBQFLpOCMMkyGM64RGpERAn8PAJoCMVWaoefI8VeIZ8YosvCvXH9zgACfdI1c
I7z6bOfRPTfVylgVRCw2T8s=
=IO0Q
-----END PGP SIGNATURE-----




^ permalink raw reply	[flat|nested] 24+ messages in thread

* Re: [RFC/PATCH] Perl 5.10.1 and a bunch of modules
  2010-03-20 14:49 ` Koen Kooi
@ 2010-03-21 12:05   ` Roman I Khimov
  2010-03-23 21:51     ` [PATCH 01/44] cpan-base: add perl version to PR Roman I Khimov
  0 siblings, 1 reply; 24+ messages in thread
From: Roman I Khimov @ 2010-03-21 12:05 UTC (permalink / raw)
  To: openembedded-devel

[-- Attachment #1: Type: Text/Plain, Size: 940 bytes --]

В сообщении от Суббота 20 марта 2010 17:49:49 автор Koen Kooi написал:
> As a generic remark, can we have a master include file for INC_PR so
> perl modules get rebuilt automagically when something in perl changes?

Not sure how to do it best. Perl-only modules should survive most of version 
bumps (BTW, we could handle those better with 'PACKAGE_ARCH = "all"'), modules 
with binary components should work within patchlevel range (like 5.8.7 -> 
5.8.8). Of course it's only if we're not changing Perl build itself in some 
strange way, but I doubt that.

So, we could probably add Perl version to the PV, thus allowing perl PR bumps 
and rebuilding on version change. That could be made dependent on 
PACKAGE_ARCH, so that Perl-only modules wouldn't be touched at all.

-- 
 http://roman.khimov.ru
mailto: roman@khimov.ru
gpg --keyserver hkp://subkeys.pgp.net --recv-keys 0xE5E055C3

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 205 bytes --]

^ permalink raw reply	[flat|nested] 24+ messages in thread

* Re: [RFC/PATCH] Perl 5.10.1 and a bunch of modules
  2010-03-19 21:05         ` Roman I Khimov
  2010-03-19 21:12           ` Graeme Gregory
@ 2010-03-23 13:51           ` Roman I Khimov
  1 sibling, 0 replies; 24+ messages in thread
From: Roman I Khimov @ 2010-03-23 13:51 UTC (permalink / raw)
  To: openembedded-devel

В сообщении от Суббота 20 марта 2010 00:05:35 автор Roman I Khimov написал:
> I think I need some ACK's for dusty old Perl versions removal and then
> Richard's Perl staging update could be merged better on top of that (CC'ing
> Richard) and than I'll update 5.10.1 to new staging and push the series. At
> least, that's how I think it should be. If there are any problems with
>  staging update and it's not ready to be pushed in OE.dev, I think we can
>  merge 5.10.1 as it is now.

OK, I think I'm pushing 5.10.1 as is some hours later and Richard could port 
his staging changes when ready.



^ permalink raw reply	[flat|nested] 24+ messages in thread

* [PATCH 01/44] cpan-base: add perl version to PR
  2010-03-21 12:05   ` Roman I Khimov
@ 2010-03-23 21:51     ` Roman I Khimov
  2010-03-24 12:57       ` Roman I Khimov
  0 siblings, 1 reply; 24+ messages in thread
From: Roman I Khimov @ 2010-03-23 21:51 UTC (permalink / raw)
  To: openembedded-devel

Makes perl modules rebuild on perl version change, since binary compatibility
could be broken with that (although perl itself tries to maintain it  within
patchlevel range, like 5.8.7 -> 5.8.8).

This is conditional on PACKAGE_ARCH, since there is nothing to rebuild for
pure perl modules (and those should use 'PACKAGE_ARCH = "all"') even if they
break with perl version change.

This also should ease transition to perl 5.10.1.

Signed-off-by: Roman I Khimov <khimov@altell.ru>
---
 classes/cpan-base.bbclass |    8 ++++++++
 1 files changed, 8 insertions(+), 0 deletions(-)

diff --git a/classes/cpan-base.bbclass b/classes/cpan-base.bbclass
index 8eb173e..1c77c9b 100644
--- a/classes/cpan-base.bbclass
+++ b/classes/cpan-base.bbclass
@@ -35,6 +35,14 @@ def is_target(d):
         return "yes"
     return "no"
 
+def perl_get_version_suffix(d):
+	if bb.data.expand('${PACKAGE_ARCH}', d) != "all":
+		return '-' + get_perl_version(d)
+	else:
+		return ''
+
+PR .= "${@perl_get_version_suffix(d)}"
+
 PERLLIBDIRS = "${@perl_get_libdirs(d)}"
 
 FILES_${PN}-dbg += "${PERLLIBDIRS}/auto/*/.debug \
-- 
1.6.4.2




^ permalink raw reply related	[flat|nested] 24+ messages in thread

* Re: [PATCH 01/44] cpan-base: add perl version to PR
  2010-03-23 21:51     ` [PATCH 01/44] cpan-base: add perl version to PR Roman I Khimov
@ 2010-03-24 12:57       ` Roman I Khimov
  2010-03-24 16:09         ` Koen Kooi
  0 siblings, 1 reply; 24+ messages in thread
From: Roman I Khimov @ 2010-03-24 12:57 UTC (permalink / raw)
  To: openembedded-devel

В сообщении от Среда 24 марта 2010 00:51:08 вы написали:
> Makes perl modules rebuild on perl version change, since binary
>  compatibility could be broken with that (although perl itself tries to
>  maintain it  within patchlevel range, like 5.8.7 -> 5.8.8).
> 
> This is conditional on PACKAGE_ARCH, since there is nothing to rebuild for
> pure perl modules (and those should use 'PACKAGE_ARCH = "all"') even if
>  they break with perl version change.
> 
> This also should ease transition to perl 5.10.1.

OK to push? I've realized yesterday that without it or similar thing many 
binary modules would be broken when someone would try to use 5.10.1 and manual 
cleaning and rebuilding a ton of perl modules is no fun.



^ permalink raw reply	[flat|nested] 24+ messages in thread

* Re: [PATCH 01/44] cpan-base: add perl version to PR
  2010-03-24 12:57       ` Roman I Khimov
@ 2010-03-24 16:09         ` Koen Kooi
  2010-03-24 17:26           ` Roman I Khimov
  0 siblings, 1 reply; 24+ messages in thread
From: Koen Kooi @ 2010-03-24 16:09 UTC (permalink / raw)
  To: openembedded-devel

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 24-03-10 13:57, Roman I Khimov wrote:
> В сообщении от Среда 24 марта 2010 00:51:08 вы написали:
>> Makes perl modules rebuild on perl version change, since binary
>>  compatibility could be broken with that (although perl itself tries to
>>  maintain it  within patchlevel range, like 5.8.7 -> 5.8.8).
>>
>> This is conditional on PACKAGE_ARCH, since there is nothing to rebuild for
>> pure perl modules (and those should use 'PACKAGE_ARCH = "all"') even if
>>  they break with perl version change.
>>
>> This also should ease transition to perl 5.10.1.
> 
> OK to push?

Yes

> I've realized yesterday that without it or similar thing many 
> binary modules would be broken when someone would try to use 5.10.1 and manual 
> cleaning and rebuilding a ton of perl modules is no fun.

And manually bumping PR as well, which is why I asked for this :)

regards,

Koen
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.5 (Darwin)

iD8DBQFLqjk4MkyGM64RGpERAtHuAJ9UNAvsTQJcRG8stOt0zXI5TeWjzQCeOC2J
HSypchX1JCQ3Uj6nexlelYs=
=aSbz
-----END PGP SIGNATURE-----




^ permalink raw reply	[flat|nested] 24+ messages in thread

* Re: [PATCH 01/44] cpan-base: add perl version to PR
  2010-03-24 16:09         ` Koen Kooi
@ 2010-03-24 17:26           ` Roman I Khimov
  2010-03-24 17:41             ` Marcin Juszkiewicz
  0 siblings, 1 reply; 24+ messages in thread
From: Roman I Khimov @ 2010-03-24 17:26 UTC (permalink / raw)
  To: openembedded-devel

[-- Attachment #1: Type: Text/Plain, Size: 903 bytes --]

В сообщении от Среда 24 марта 2010 19:09:28 автор Koen Kooi написал:
> On 24-03-10 13:57, Roman I Khimov wrote:
> > В сообщении от Среда 24 марта 2010 00:51:08 вы написали:
> >> Makes perl modules rebuild on perl version change, since binary
> >>  compatibility could be broken with that (although perl itself tries to
> >>  maintain it  within patchlevel range, like 5.8.7 -> 5.8.8).
> >>
> >> This is conditional on PACKAGE_ARCH, since there is nothing to rebuild
> >> for pure perl modules (and those should use 'PACKAGE_ARCH = "all"') even
> >> if they break with perl version change.
> >>
> >> This also should ease transition to perl 5.10.1.
> >
> > OK to push?
> 
> Yes

OK. Pushed perl 5.10.1, everybody, have fun!

-- 
 http://roman.khimov.ru
mailto: roman@khimov.ru
gpg --keyserver hkp://subkeys.pgp.net --recv-keys 0xE5E055C3

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 205 bytes --]

^ permalink raw reply	[flat|nested] 24+ messages in thread

* Re: [PATCH 01/44] cpan-base: add perl version to PR
  2010-03-24 17:26           ` Roman I Khimov
@ 2010-03-24 17:41             ` Marcin Juszkiewicz
  2010-03-24 17:55               ` Roman I Khimov
  2010-03-24 17:58               ` Roman I Khimov
  0 siblings, 2 replies; 24+ messages in thread
From: Marcin Juszkiewicz @ 2010-03-24 17:41 UTC (permalink / raw)
  To: openembedded-devel

Dnia środa, 24 marca 2010 o 18:26:16 Roman I Khimov napisał(a):

> OK. Pushed perl 5.10.1, everybody, have fun!

18:39 hrw@home:angstrom$ bitbake perl
NOTE: Handling BitBake files: - (0975/8143) [11 %]NOTE: <type 
'exceptions.TypeError'>:cannot concatenate 'str' and 'NoneType' objects while 
evaluating:
r0${@perl_get_version_suffix(d)}
NOTE: <type 'exceptions.TypeError'>:cannot concatenate 'str' and 'NoneType' 
objects while evaluating:
${PN}-${EXTENDPE}${PV}-${PR}
NOTE: <type 'exceptions.TypeError'>:cannot concatenate 'str' and 'NoneType' 
objects while evaluating:
${TMPDIR}/work/${MULTIMACH_TARGET_SYS}/${PF}
NOTE: <type 'exceptions.TypeError'>:cannot concatenate 'str' and 'NoneType' 
objects while evaluating:
${WORKDIR}/callweaver-1.2-${CWRCV}/contrib/ogi-perl/callweaver-perl-0.0.1
NOTE: <type 'exceptions.TypeError'>:cannot concatenate 'str' and 'NoneType' 
objects while evaluating:
${S}
ERROR: cannot concatenate 'str' and 'NoneType' objects while parsing 
/home/hrw/devel/oe/openembedded/recipes/callweaver/callweaver-perl.bb
NOTE: Handling BitBake files: - (3827/8143) [46 %]NOTE: <type 
'exceptions.TypeError'>:cannot concatenate 'str' and 'NoneType' objects while 
evaluating:
r2${@perl_get_version_suffix(d)}
NOTE: <type 'exceptions.TypeError'>:cannot concatenate 'str' and 'NoneType' 
objects while evaluating:
${PN}-${EXTENDPE}${PV}-${PR}
NOTE: <type 'exceptions.TypeError'>:cannot concatenate 'str' and 'NoneType' 
objects while evaluating:
${TMPDIR}/work/${MULTIMACH_TARGET_SYS}/${PF}
NOTE: <type 'exceptions.TypeError'>:cannot concatenate 'str' and 'NoneType' 
objects while evaluating:
${WORKDIR}/SDL_perl-${PV}
NOTE: <type 'exceptions.TypeError'>:cannot concatenate 'str' and 'NoneType' 
objects while evaluating:
${S}
ERROR: cannot concatenate 'str' and 'NoneType' objects while parsing 
/home/hrw/devel/oe/openembedded/recipes/sdlperl/sdl-perl_1.20.3.bb

And same for lot of perl recipes.

Regards, 
-- 
JID:      hrw@jabber.org
Website:  http://marcin.juszkiewicz.com.pl/
LinkedIn: http://www.linkedin.com/in/marcinjuszkiewicz





^ permalink raw reply	[flat|nested] 24+ messages in thread

* Re: [PATCH 01/44] cpan-base: add perl version to PR
  2010-03-24 17:41             ` Marcin Juszkiewicz
@ 2010-03-24 17:55               ` Roman I Khimov
  2010-03-25  7:28                 ` Koen Kooi
  2010-03-24 17:58               ` Roman I Khimov
  1 sibling, 1 reply; 24+ messages in thread
From: Roman I Khimov @ 2010-03-24 17:55 UTC (permalink / raw)
  To: openembedded-devel

[-- Attachment #1: Type: Text/Plain, Size: 1772 bytes --]

В сообщении от Среда 24 марта 2010 20:41:00 автор Marcin Juszkiewicz написал:
> Dnia środa, 24 marca 2010 o 18:26:16 Roman I Khimov napisał(a):
> > OK. Pushed perl 5.10.1, everybody, have fun!
> 
> 18:39 hrw@home:angstrom$ bitbake perl
> NOTE: Handling BitBake files: - (0975/8143) [11 %]NOTE: <type
> 'exceptions.TypeError'>:cannot concatenate 'str' and 'NoneType' objects
>  while evaluating:
> r0${@perl_get_version_suffix(d)}
> NOTE: <type 'exceptions.TypeError'>:cannot concatenate 'str' and 'NoneType'
> objects while evaluating:
> ${PN}-${EXTENDPE}${PV}-${PR}
> NOTE: <type 'exceptions.TypeError'>:cannot concatenate 'str' and 'NoneType'
> objects while evaluating:
> ${TMPDIR}/work/${MULTIMACH_TARGET_SYS}/${PF}
> NOTE: <type 'exceptions.TypeError'>:cannot concatenate 'str' and 'NoneType'
> objects while evaluating:
> ${WORKDIR}/callweaver-1.2-${CWRCV}/contrib/ogi-perl/callweaver-perl-0.0.1
> NOTE: <type 'exceptions.TypeError'>:cannot concatenate 'str' and 'NoneType'
> objects while evaluating:
> ${S}
> ERROR: cannot concatenate 'str' and 'NoneType' objects while parsing
> /home/hrw/devel/oe/openembedded/recipes/callweaver/callweaver-perl.bb
> NOTE: Handling BitBake files: - (3827/8143) [46 %]NOTE: <type
> 'exceptions.TypeError'>:cannot concatenate 'str' and 'NoneType' objects
>  while evaluating:
> r2${@perl_get_version_suffix(d)}

(0_0)
Never had that and just tried, nothing like that, test setup is Angstrom for 
qemuarm.

Ah. I guess it might be something with bitbake versions, no? I'm using bitbake 
1.8.x, commit d99de1c3f35a01f6d06b2965da823ae3cd16d0eb.

-- 
 http://roman.khimov.ru
mailto: roman@khimov.ru
gpg --keyserver hkp://subkeys.pgp.net --recv-keys 0xE5E055C3

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 205 bytes --]

^ permalink raw reply	[flat|nested] 24+ messages in thread

* Re: [PATCH 01/44] cpan-base: add perl version to PR
  2010-03-24 17:41             ` Marcin Juszkiewicz
  2010-03-24 17:55               ` Roman I Khimov
@ 2010-03-24 17:58               ` Roman I Khimov
  1 sibling, 0 replies; 24+ messages in thread
From: Roman I Khimov @ 2010-03-24 17:58 UTC (permalink / raw)
  To: openembedded-devel

[-- Attachment #1: Type: Text/Plain, Size: 721 bytes --]

В сообщении от Среда 24 марта 2010 20:41:00 автор Marcin Juszkiewicz написал:
> Dnia środa, 24 marca 2010 o 18:26:16 Roman I Khimov napisał(a):
> > OK. Pushed perl 5.10.1, everybody, have fun!
> 
> 18:39 hrw@home:angstrom$ bitbake perl
> NOTE: Handling BitBake files: - (0975/8143) [11 %]NOTE: <type
> 'exceptions.TypeError'>:cannot concatenate 'str' and 'NoneType' objects
>  while evaluating:
> r0${@perl_get_version_suffix(d)}

Argh! Sure, I have perl built already and it's get_perl_version that gives 
None here. Ugh. Sorry, thinking on better fix.

-- 
 http://roman.khimov.ru
mailto: roman@khimov.ru
gpg --keyserver hkp://subkeys.pgp.net --recv-keys 0xE5E055C3

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 205 bytes --]

^ permalink raw reply	[flat|nested] 24+ messages in thread

* Re: [PATCH 01/44] cpan-base: add perl version to PR
  2010-03-24 17:55               ` Roman I Khimov
@ 2010-03-25  7:28                 ` Koen Kooi
  2010-03-25  7:35                   ` Roman I Khimov
  0 siblings, 1 reply; 24+ messages in thread
From: Koen Kooi @ 2010-03-25  7:28 UTC (permalink / raw)
  To: openembedded-devel

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 24-03-10 18:55, Roman I Khimov wrote:
> В сообщении от Среда 24 марта 2010 20:41:00 автор Marcin Juszkiewicz написал:
>> Dnia środa, 24 marca 2010 o 18:26:16 Roman I Khimov napisał(a):
>>> OK. Pushed perl 5.10.1, everybody, have fun!
>>
>> 18:39 hrw@home:angstrom$ bitbake perl
>> NOTE: Handling BitBake files: - (0975/8143) [11 %]NOTE: <type
>> 'exceptions.TypeError'>:cannot concatenate 'str' and 'NoneType' objects
>>  while evaluating:
>> r0${@perl_get_version_suffix(d)}
>> NOTE: <type 'exceptions.TypeError'>:cannot concatenate 'str' and 'NoneType'
>> objects while evaluating:
>> ${PN}-${EXTENDPE}${PV}-${PR}
>> NOTE: <type 'exceptions.TypeError'>:cannot concatenate 'str' and 'NoneType'
>> objects while evaluating:
>> ${TMPDIR}/work/${MULTIMACH_TARGET_SYS}/${PF}
>> NOTE: <type 'exceptions.TypeError'>:cannot concatenate 'str' and 'NoneType'
>> objects while evaluating:
>> ${WORKDIR}/callweaver-1.2-${CWRCV}/contrib/ogi-perl/callweaver-perl-0.0.1
>> NOTE: <type 'exceptions.TypeError'>:cannot concatenate 'str' and 'NoneType'
>> objects while evaluating:
>> ${S}
>> ERROR: cannot concatenate 'str' and 'NoneType' objects while parsing
>> /home/hrw/devel/oe/openembedded/recipes/callweaver/callweaver-perl.bb
>> NOTE: Handling BitBake files: - (3827/8143) [46 %]NOTE: <type
>> 'exceptions.TypeError'>:cannot concatenate 'str' and 'NoneType' objects
>>  while evaluating:
>> r2${@perl_get_version_suffix(d)}
> 
> (0_0)
> Never had that and just tried, nothing like that, test setup is Angstrom for 
> qemuarm.

I think this is the same problem as we have with KERNEL_VERSION. IIRC we
cheat a bit and write out a file in staging with the version.

regards,

Koen
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.5 (Darwin)

iD8DBQFLqxCBMkyGM64RGpERAttaAKCsWP+WLeWIRkSZBfiaqUrT15L1QgCcDvIZ
gN3dYKQn5EjTC4lqqqu5cX4=
=Oaop
-----END PGP SIGNATURE-----




^ permalink raw reply	[flat|nested] 24+ messages in thread

* Re: [PATCH 01/44] cpan-base: add perl version to PR
  2010-03-25  7:28                 ` Koen Kooi
@ 2010-03-25  7:35                   ` Roman I Khimov
  0 siblings, 0 replies; 24+ messages in thread
From: Roman I Khimov @ 2010-03-25  7:35 UTC (permalink / raw)
  To: openembedded-devel

[-- Attachment #1: Type: Text/Plain, Size: 2278 bytes --]

В сообщении от Четверг 25 марта 2010 10:28:02 автор Koen Kooi написал:
> On 24-03-10 18:55, Roman I Khimov wrote:
> > В сообщении от Среда 24 марта 2010 20:41:00 автор Marcin Juszkiewicz 
написал:
> >> Dnia środa, 24 marca 2010 o 18:26:16 Roman I Khimov napisał(a):
> >>> OK. Pushed perl 5.10.1, everybody, have fun!
> >>
> >> 18:39 hrw@home:angstrom$ bitbake perl
> >> NOTE: Handling BitBake files: - (0975/8143) [11 %]NOTE: <type
> >> 'exceptions.TypeError'>:cannot concatenate 'str' and 'NoneType' objects
> >>  while evaluating:
> >> r0${@perl_get_version_suffix(d)}
> >> NOTE: <type 'exceptions.TypeError'>:cannot concatenate 'str' and
> >> 'NoneType' objects while evaluating:
> >> ${PN}-${EXTENDPE}${PV}-${PR}
> >> NOTE: <type 'exceptions.TypeError'>:cannot concatenate 'str' and
> >> 'NoneType' objects while evaluating:
> >> ${TMPDIR}/work/${MULTIMACH_TARGET_SYS}/${PF}
> >> NOTE: <type 'exceptions.TypeError'>:cannot concatenate 'str' and
> >> 'NoneType' objects while evaluating:
> >> ${WORKDIR}/callweaver-1.2-${CWRCV}/contrib/ogi-perl/callweaver-perl-0.0.
> >>1 NOTE: <type 'exceptions.TypeError'>:cannot concatenate 'str' and
> >> 'NoneType' objects while evaluating:
> >> ${S}
> >> ERROR: cannot concatenate 'str' and 'NoneType' objects while parsing
> >> /home/hrw/devel/oe/openembedded/recipes/callweaver/callweaver-perl.bb
> >> NOTE: Handling BitBake files: - (3827/8143) [46 %]NOTE: <type
> >> 'exceptions.TypeError'>:cannot concatenate 'str' and 'NoneType' objects
> >>  while evaluating:
> >> r2${@perl_get_version_suffix(d)}
> >
> > (0_0)
> > Never had that and just tried, nothing like that, test setup is Angstrom
> > for qemuarm.
> 
> I think this is the same problem as we have with KERNEL_VERSION. IIRC we
> cheat a bit and write out a file in staging with the version.

Yep, see my other message and as we've discussed a bit on IRC, there is no 
good way to handle it other than DISTRO_PR or some kind of mangling of PKGR, 
but that's also not perfect. I think that perl version change might deserve 
DISTRO_PR bump.

-- 
 http://roman.khimov.ru
mailto: roman@khimov.ru
gpg --keyserver hkp://subkeys.pgp.net --recv-keys 0xE5E055C3

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 205 bytes --]

^ permalink raw reply	[flat|nested] 24+ messages in thread

end of thread, other threads:[~2010-03-25  7:41 UTC | newest]

Thread overview: 24+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2010-03-18 19:12 [RFC/PATCH] Perl 5.10.1 and a bunch of modules Roman I Khimov
2010-03-18 19:36 ` Frans Meulenbroeks
2010-03-18 19:46   ` Roman I Khimov
2010-03-18 19:50 ` Roman I Khimov
2010-03-18 20:30 ` Koen Kooi
2010-03-18 20:47   ` Roman I Khimov
2010-03-18 21:04     ` Roman I Khimov
2010-03-18 21:23       ` Roman I Khimov
2010-03-19 21:05         ` Roman I Khimov
2010-03-19 21:12           ` Graeme Gregory
2010-03-19 22:47             ` Koen Kooi
2010-03-20  8:49             ` Frans Meulenbroeks
2010-03-23 13:51           ` Roman I Khimov
2010-03-20 14:49 ` Koen Kooi
2010-03-21 12:05   ` Roman I Khimov
2010-03-23 21:51     ` [PATCH 01/44] cpan-base: add perl version to PR Roman I Khimov
2010-03-24 12:57       ` Roman I Khimov
2010-03-24 16:09         ` Koen Kooi
2010-03-24 17:26           ` Roman I Khimov
2010-03-24 17:41             ` Marcin Juszkiewicz
2010-03-24 17:55               ` Roman I Khimov
2010-03-25  7:28                 ` Koen Kooi
2010-03-25  7:35                   ` Roman I Khimov
2010-03-24 17:58               ` Roman I Khimov

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.