From: Amit Shah <amit.shah@redhat.com> To: Anton Blanchard <anton@samba.org> Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>, Greg Kroah-Hartman <gregkh@suse.de>, Linus Torvalds <torvalds@linux-foundation.org>, linux-kernel@vger.kernel.org, linuxppc-dev@ozlabs.org, Rusty Russell <rusty@rustcorp.com.au>, Alan Cox <alan@lxorguk.ukuu.org.uk>, tglx@linutronix.de, mingo@elte.hu, a.p.zijlstra@chello.nl Subject: Re: [PATCH 4/7] hvc_console: Fix race between hvc_close and hvc_remove Date: Fri, 26 Mar 2010 07:31:11 +0530 [thread overview] Message-ID: <20100326020111.GF8111@amit-x200.redhat.com> (raw) In-Reply-To: <20100325233031.GC5594@kryten> On (Fri) Mar 26 2010 [10:30:31], Anton Blanchard wrote: > > Hi, > > > And this suggests that hvc_kick() is called before hvc_task is > > initialised, ie, before hvc_init() is called. > > > > Does this help? > > Looks good, tests OK on my POWER5 box. Thanks! > > Tested-by: Anton Blanchard <anton@samba.org> Thanks. Before I submit this patch, though, I'd like to see why hvc_kick() gets called before hvc_init. If I can get to it real quick, I'll do it, else I'll just queue this one up. > > diff --git a/drivers/char/hvc_console.c b/drivers/char/hvc_console.c > > index ba55bba..50ac983 100644 > > --- a/drivers/char/hvc_console.c > > +++ b/drivers/char/hvc_console.c > > @@ -285,6 +285,9 @@ EXPORT_SYMBOL_GPL(hvc_instantiate); > > /* Wake the sleeping khvcd */ > > void hvc_kick(void) > > { > > + if (!hvc_task) > > + return; > > + > > hvc_kicked = 1; > > wake_up_process(hvc_task); > > } Amit
WARNING: multiple messages have this Message-ID (diff)
From: Amit Shah <amit.shah@redhat.com> To: Anton Blanchard <anton@samba.org> Cc: Greg Kroah-Hartman <gregkh@suse.de>, a.p.zijlstra@chello.nl, Rusty Russell <rusty@rustcorp.com.au>, linux-kernel@vger.kernel.org, linuxppc-dev@ozlabs.org, tglx@linutronix.de, Linus Torvalds <torvalds@linux-foundation.org>, mingo@elte.hu, Alan Cox <alan@lxorguk.ukuu.org.uk> Subject: Re: [PATCH 4/7] hvc_console: Fix race between hvc_close and hvc_remove Date: Fri, 26 Mar 2010 07:31:11 +0530 [thread overview] Message-ID: <20100326020111.GF8111@amit-x200.redhat.com> (raw) In-Reply-To: <20100325233031.GC5594@kryten> On (Fri) Mar 26 2010 [10:30:31], Anton Blanchard wrote: > > Hi, > > > And this suggests that hvc_kick() is called before hvc_task is > > initialised, ie, before hvc_init() is called. > > > > Does this help? > > Looks good, tests OK on my POWER5 box. Thanks! > > Tested-by: Anton Blanchard <anton@samba.org> Thanks. Before I submit this patch, though, I'd like to see why hvc_kick() gets called before hvc_init. If I can get to it real quick, I'll do it, else I'll just queue this one up. > > diff --git a/drivers/char/hvc_console.c b/drivers/char/hvc_console.c > > index ba55bba..50ac983 100644 > > --- a/drivers/char/hvc_console.c > > +++ b/drivers/char/hvc_console.c > > @@ -285,6 +285,9 @@ EXPORT_SYMBOL_GPL(hvc_instantiate); > > /* Wake the sleeping khvcd */ > > void hvc_kick(void) > > { > > + if (!hvc_task) > > + return; > > + > > hvc_kicked = 1; > > wake_up_process(hvc_task); > > } Amit
next prev parent reply other threads:[~2010-03-26 2:03 UTC|newest] Thread overview: 54+ messages / expand[flat|nested] mbox.gz Atom feed top 2010-03-19 15:13 [GIT PATCH] TTY fixes for 2.6.34-git Greg KH 2010-03-19 15:18 ` [PATCH 1/7] Revert "tty: Add a new VT mode which is like VT_PROCESS but doesn't require a VT_RELDISP ioctl call" Greg Kroah-Hartman 2010-03-19 15:18 ` [PATCH 2/7] tty: Take a 256 byte padding into account when buffering below sub-page units Greg Kroah-Hartman 2010-03-19 15:18 ` [PATCH 3/7] uartlite: Fix build on sparc Greg Kroah-Hartman 2010-03-19 16:15 ` Grant Likely 2010-03-19 16:26 ` Grant Likely 2010-03-26 14:31 ` Michal Simek 2010-03-19 15:18 ` [PATCH 4/7] hvc_console: Fix race between hvc_close and hvc_remove Greg Kroah-Hartman 2010-03-19 15:18 ` Greg Kroah-Hartman 2010-03-20 21:04 ` Benjamin Herrenschmidt 2010-03-20 21:04 ` Benjamin Herrenschmidt 2010-03-21 4:37 ` Amit Shah 2010-03-21 4:37 ` Amit Shah 2010-03-24 12:19 ` Amit Shah 2010-03-24 12:19 ` Amit Shah 2010-03-25 23:30 ` Anton Blanchard 2010-03-25 23:30 ` Anton Blanchard 2010-03-26 2:01 ` Amit Shah [this message] 2010-03-26 2:01 ` Amit Shah 2010-03-26 9:13 ` Sachin Sant 2010-03-26 9:13 ` Sachin Sant 2010-03-26 9:58 ` Amit Shah 2010-03-26 9:58 ` Amit Shah 2010-03-26 10:54 ` Stephen Rothwell 2010-03-26 10:54 ` Stephen Rothwell 2010-03-26 11:42 ` Sachin Sant 2010-03-26 11:42 ` Sachin Sant 2010-03-26 11:52 ` Alan Cox 2010-03-26 11:52 ` Alan Cox 2010-03-26 12:49 ` Amit Shah 2010-03-26 12:49 ` Amit Shah 2010-03-26 12:43 ` Amit Shah 2010-03-26 12:43 ` Amit Shah 2010-04-06 11:42 ` Anton Blanchard 2010-04-06 11:42 ` Anton Blanchard 2010-04-06 12:09 ` Amit Shah 2010-04-06 12:09 ` Amit Shah 2010-04-06 12:27 ` Sachin Sant 2010-04-06 12:27 ` Sachin Sant 2010-04-06 12:32 ` Alan Cox 2010-04-06 12:32 ` Alan Cox 2010-04-08 0:26 ` Rusty Russell 2010-04-08 0:26 ` Rusty Russell 2010-03-24 10:45 ` Benjamin Herrenschmidt 2010-03-24 10:45 ` Benjamin Herrenschmidt 2010-03-24 10:57 ` Amit Shah 2010-03-24 10:57 ` Amit Shah 2010-03-24 11:37 ` Alan Cox 2010-03-24 11:37 ` Alan Cox 2010-03-24 15:05 ` Amit Shah 2010-03-24 15:05 ` Amit Shah 2010-03-19 15:18 ` [PATCH 5/7] tty_buffer: Fix distinct type warning Greg Kroah-Hartman 2010-03-19 15:18 ` [PATCH 6/7] tty: cpm_uart: use resource_size() Greg Kroah-Hartman 2010-03-19 15:18 ` [PATCH 7/7] tty_port,usb-console: Fix usb serial console open/close regression Greg Kroah-Hartman
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20100326020111.GF8111@amit-x200.redhat.com \ --to=amit.shah@redhat.com \ --cc=a.p.zijlstra@chello.nl \ --cc=alan@lxorguk.ukuu.org.uk \ --cc=anton@samba.org \ --cc=benh@kernel.crashing.org \ --cc=gregkh@suse.de \ --cc=linux-kernel@vger.kernel.org \ --cc=linuxppc-dev@ozlabs.org \ --cc=mingo@elte.hu \ --cc=rusty@rustcorp.com.au \ --cc=tglx@linutronix.de \ --cc=torvalds@linux-foundation.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.