All of lore.kernel.org
 help / color / mirror / Atom feed
* request for enhancement: gitk highlight whitespace
@ 2010-03-26 14:19 Simon Braunschmidt
  2010-03-26 16:21 ` Oliver Kullmann
  0 siblings, 1 reply; 2+ messages in thread
From: Simon Braunschmidt @ 2010-03-26 14:19 UTC (permalink / raw)
  To: git; +Cc: Simon Braunschmidt

Hi

It would be great if I could teach gitk to better highlight 
whitespace changes in the diff view.

Every once in a while (and again today) I have to review 
patches that "fix whitespace". Allthough the fixes are usually 
trivial, I have to check them, which is not trivial with the gitk 
display. Also I often mistakenly accept changes after 
review with gitk that turn out to contain a mix of 
tabs/whitespace etc. 

I searched the mailinglist (for gitk whitespace) and asked on irc, yet 
nobody seemed to care so far.

What do you think about it?

Regards,Gruessle
Simon

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: request for enhancement: gitk highlight whitespace
  2010-03-26 14:19 request for enhancement: gitk highlight whitespace Simon Braunschmidt
@ 2010-03-26 16:21 ` Oliver Kullmann
  0 siblings, 0 replies; 2+ messages in thread
From: Oliver Kullmann @ 2010-03-26 16:21 UTC (permalink / raw)
  To: git

Yeah, that would be good.
Don't know whether it has something to do
with a change in Git (I'm using 1.7.0.1),
but recently I got quite a few submissions
where gitk shows lines as changed, but I couldn't
find out what it was. 

A general option to show explicitly the change would
be a good thing.

Oliver

P.S. This would also be helpful for long lines (yet it's a pain with
gitk to find out where the change is).


On Fri, Mar 26, 2010 at 03:19:17PM +0100, Simon Braunschmidt wrote:
> Hi
> 
> It would be great if I could teach gitk to better highlight 
> whitespace changes in the diff view.
> 
> Every once in a while (and again today) I have to review 
> patches that "fix whitespace". Allthough the fixes are usually 
> trivial, I have to check them, which is not trivial with the gitk 
> display. Also I often mistakenly accept changes after 
> review with gitk that turn out to contain a mix of 
> tabs/whitespace etc. 
> 
> I searched the mailinglist (for gitk whitespace) and asked on irc, yet 
> nobody seemed to care so far.
> 
> What do you think about it?
> 
> Regards,Gruessle
> Simon
> --
> To unsubscribe from this list: send the line "unsubscribe git" in
> the body of a message to majordomo@vger.kernel.org

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2010-03-26 16:21 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2010-03-26 14:19 request for enhancement: gitk highlight whitespace Simon Braunschmidt
2010-03-26 16:21 ` Oliver Kullmann

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.