[Bug 27402] New: [r300g] Earth textures in celestia are partially corrupted in all rendering paths

[Bug 27402] New: [r300g] Earth textures in celestia are partially corrupted in all rendering paths

[bugzilla-daemon]

http://bugs.freedesktop.org/show_bug.cgi?id=27402

           Summary: [r300g] Earth textures in celestia are partially
                    corrupted in all rendering paths
           Product: Mesa
           Version: git
          Platform: x86 (IA32)
        OS/Version: Linux (All)
            Status: NEW
          Severity: normal
          Priority: medium
         Component: Drivers/DRI/r300
        AssignedTo: dri-devel@lists.sourceforge.net
        ReportedBy: rankincj@googlemail.com


The Earth textures on the band between "daytime" and "nighttime" are corrupt,
in all 3 of the Basic, Multi-texture and OpenGL vertex program rendering paths.
(They're gone completely in the OpenGL 2.0 rendering path, but that's a
separate bug entirely.)

This is a new bug, which has appeared at around the time of this commit:

commit 3623202834e9ca1073a4aa66f72f584812fb14df
Author: Corbin Simpson <MostAwesomeDude@gmail.com>
Date:   Tue Mar 30 10:43:51 2010 -0700

    r300/compiler: Unbreak DDX/DDY.

    Fixes progs/glsl/deriv.


-- 
Configure bugmail: http://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

------------------------------------------------------------------------------
Download Intel&#174; Parallel Studio Eval
Try the new software tools for yourself. Speed compiling, find bugs
proactively, and fine-tune applications for parallel performance.
See why Intel Parallel Studio got high marks during beta.
http://p.sf.net/sfu/intel-sw-dev
--

[Bug 27402] [r300g] Earth textures in celestia are partially corrupted in all rendering paths

[bugzilla-daemon]

http://bugs.freedesktop.org/show_bug.cgi?id=27402





--- Comment #1 from Marek Olšák <maraeo@gmail.com>  2010-03-31 17:56:03 PST ---
Does reverting the commit help? If not, could you please bisect?


-- 
Configure bugmail: http://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
------------------------------------------------------------------------------
Download Intel&#174; Parallel Studio Eval
Try the new software tools for yourself. Speed compiling, find bugs
proactively, and fine-tune applications for parallel performance.
See why Intel Parallel Studio got high marks during beta.
http://p.sf.net/sfu/intel-sw-dev
--
_______________________________________________
Dri-devel mailing list
Dri-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/dri-devel

[Bug 27402] [r300g] Earth textures in celestia are partially corrupted in all rendering paths

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=27402

--- Comment #2 from Chris Rankin <rankincj@googlemail.com> 2010-04-02 17:09:23 PDT ---
(In reply to comment #1)
> Does reverting the commit help? If not, could you please bisect?

Sorry, I've just spent the last hour trying to perform a git bisect, and got
nothing except broken builds and core dumps for my troubles. So "no", you're
going to have to debug the old-fashioned way instead.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

------------------------------------------------------------------------------
Download Intel&#174; Parallel Studio Eval
Try the new software tools for yourself. Speed compiling, find bugs
proactively, and fine-tune applications for parallel performance.
See why Intel Parallel Studio got high marks during beta.
http://p.sf.net/sfu/intel-sw-dev
--

[Bug 27402] [r300g] Earth textures in celestia are partially corrupted in all rendering paths

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=27402

--- Comment #3 from Xavier <shiningxc@gmail.com> 2010-04-03 00:20:47 PDT ---
(In reply to comment #2)
> (In reply to comment #1)
> > Does reverting the commit help? If not, could you please bisect?
> 
> Sorry, I've just spent the last hour trying to perform a git bisect, and got
> nothing except broken builds and core dumps for my troubles. So "no", you're
> going to have to debug the old-fashioned way instead.

To avoid segfaults (caused by incomplete rebuilds), did you have makedepend
installed ?
( http://www.x.org/releases/individual/util/makedepend-1.0.2.tar.bz2 )
Otherwise you need to make clean before each rebuild. You can speed that a lot
using ccache.

http://www.mail-archive.com/nouveau@lists.freedesktop.org/msg04939.html has
more information.

To avoid build errors, did you have an up-to-date configure ?
$ autoreconf -iv && ./config.status --recheck && ./config.status

Read http://www.mail-archive.com/mesa3d-dev@lists.sourceforge.net/msg12767.html
for more explanation.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

------------------------------------------------------------------------------
Download Intel&#174; Parallel Studio Eval
Try the new software tools for yourself. Speed compiling, find bugs
proactively, and fine-tune applications for parallel performance.
See why Intel Parallel Studio got high marks during beta.
http://p.sf.net/sfu/intel-sw-dev
--

[Bug 27402] [r300g] Earth textures in celestia are partially corrupted in all rendering paths

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=27402

--- Comment #4 from Chris Rankin <rankincj@googlemail.com> 2010-04-03 03:46:37 PDT ---
(In reply to comment #3)
> Read http://www.mail-archive.com/mesa3d-dev@lists.sourceforge.net/msg12767.html
> for more explanation.

Yada yada yada!

The big problem with "git bisect" is that (despite what some people seem to
think), it is NOT a tool which you can ask an inexperienced person to turn a
handle blindly and have an answer pop out of a slot. There is no guarantee
whatsoever that an intermediate build will either compile or work. In fact, it
is becoming increasingly clear that I have no friggin' clue how "git bisect" is
actually working because I have tried to bisect again this morning! Between now
and last night, someone has checked something in that has FIXED this problem.
So lets see:

This is the most recent commit in my local tree:

commit f618867645b3ce2570958bfacc1faf8c88e7a620
Author: Brian Paul <brianp@vmware.com>
Date:   Fri Apr 2 22:38:18 2010 -0600

    mesa: display list support for GL_EXT_transform_feedback

$ git bisect start
$ git bisect good

And the last commit I remember seeing last night (when it was still broken) was
this one:

commit f6c7b911653fb1508256c63518ef0bd15d68186e
Author: Dave Airlie <airlied@redhat.com>
Date:   Sat Apr 3 07:00:03 2010 +1000

    r300g: make dithering work like fglrx.

    From fglrx traces the dithering is never enabled.

So lets declare that one as "bad":

$ git bisect bad f6c7b911653fb1508256c63518ef0bd15d68186e
Some good revs are not ancestor of the bad rev.
git bisect cannot work properly in this case.
Maybe you mistake good and bad revs?

?????? WTF ??????? How can a commit that I already had last night be more
recent (in the sense of when I added it into my local tree - which is the only
measure that matters) than one I only picked up a few minutes ago this morning?

So **NO**, I am not going to use "git friggin' bisect" for you!

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

------------------------------------------------------------------------------
Download Intel&#174; Parallel Studio Eval
Try the new software tools for yourself. Speed compiling, find bugs
proactively, and fine-tune applications for parallel performance.
See why Intel Parallel Studio got high marks during beta.
http://p.sf.net/sfu/intel-sw-dev
--

[Bug 27402] [r300g] Earth textures in celestia are partially corrupted in all rendering paths

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=27402

--- Comment #5 from Michel Dänzer <michel@daenzer.net> 2010-04-03 04:07:32 PDT ---
You need to run

git bisect reset

before starting a new bisect run, otherwise the previous bisect data is still
used and can lead to inconsistent results.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
------------------------------------------------------------------------------
Download Intel&#174; Parallel Studio Eval
Try the new software tools for yourself. Speed compiling, find bugs
proactively, and fine-tune applications for parallel performance.
See why Intel Parallel Studio got high marks during beta.
http://p.sf.net/sfu/intel-sw-dev
--
_______________________________________________
Dri-devel mailing list
Dri-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/dri-devel

[Bug 27402] [r300g] Earth textures in celestia are partially corrupted in all rendering paths

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=27402

--- Comment #6 from Chris Rankin <rankincj@googlemail.com> 2010-04-03 04:14:27 PDT ---
(In reply to comment #5)
> You need to run
> 
> git bisect reset

Like this, you mean?

$ git bisect reset
Already on 'master'
$ git bisect start
$ git bisect good
$ git bisect bad f6c7b911653fb1508256c63518ef0bd15d68186e
Some good revs are not ancestor of the bad rev.
git bisect cannot work properly in this case.
Maybe you mistake good and bad revs?

Been there, done that.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

------------------------------------------------------------------------------
Download Intel&#174; Parallel Studio Eval
Try the new software tools for yourself. Speed compiling, find bugs
proactively, and fine-tune applications for parallel performance.
See why Intel Parallel Studio got high marks during beta.
http://p.sf.net/sfu/intel-sw-dev
--

Re: [Bug 27402] [r300g] Earth textures in celestia are partially corrupted in all rendering paths

[Yann Vernier]

On Sat,  3 Apr 2010 03:46:37 -0700 (PDT)
bugzilla-daemon@freedesktop.org wrote:

> $ git bisect start
> $ git bisect good
> $ git bisect bad f6c7b911653fb1508256c63518ef0bd15d68186e
> Some good revs are not ancestor of the bad rev.
> git bisect cannot work properly in this case.
> Maybe you mistake good and bad revs?
> 
> ?????? WTF ??????? How can a commit that I already had last night be more
> recent (in the sense of when I added it into my local tree - which is the only
> measure that matters) than one I only picked up a few minutes ago this morning?
> 
> So **NO**, I am not going to use "git friggin' bisect" for you!

Bisect is specifically made to track down regressions - i.e. something used to work but doesn't anymore. It should only start from somewhere the problem exists.
It sounds to me like the tree you had was something like:
 A---B---C          or   A---B---D---C
      \--D
Where C had fixed a problem and D had not. In this case, bisecting from C makes no sense, unless you want to do it backwards to find when the issue was *fixed*. "bad" and "good" should probably have been called "present" and "later", or some such.
If a particular revision doesn't build at all (exhibits some other problem than that which you're trying to track down), I guess that's when to use the skip command.

Basically it does a binary search down the revision history, although it might split along merge/branch paths. bad means after the point you look for, good means before, and the weighted words may be misleading.

Sorry you're having trouble and I hope this is more explanatory than annoying. This was meant to describe my understanding of the tool.


------------------------------------------------------------------------------
Download Intel® Parallel Studio Eval
Try the new software tools for yourself. Speed compiling, find bugs
proactively, and fine-tune applications for parallel performance.
See why Intel Parallel Studio got high marks during beta.
http://p.sf.net/sfu/intel-sw-dev
--

[Bug 27402] [r300g] Earth textures in celestia are partially corrupted in all rendering paths

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=27402

--- Comment #7 from Xavier <shiningxc@gmail.com> 2010-04-03 04:53:47 PDT ---
If this issue has been fixed, there is nothing more to see.
Why do you want to bisect something that works ?

If you are really curious and want to find what commit fixed it (instead of
what commit broke it, which is the common case), you could reverse the meaning
of good and bad with git bisect :
good when it is broken
bad when it works

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

------------------------------------------------------------------------------
Download Intel&#174; Parallel Studio Eval
Try the new software tools for yourself. Speed compiling, find bugs
proactively, and fine-tune applications for parallel performance.
See why Intel Parallel Studio got high marks during beta.
http://p.sf.net/sfu/intel-sw-dev
--

[Bug 27402] [r300g] Earth textures in celestia are partially corrupted in all rendering paths

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=27402

--- Comment #8 from Chris Rankin <rankincj@googlemail.com> 2010-04-03 06:00:45 PDT ---
(In reply to comment #7)
> Why do you want to bisect something that works ?

a) To find the commit that fixed the bug. (Which is precisely what I was
describing in comment 4), and
b) To point out that "git bisect" is not the "magic" tool that some developers
seem to think that it is. ESPECIALLY since there were only 10 possible commits
that could have fixed my problem, and "git bisect" still proved to be esoteric
and unhelpful!

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

------------------------------------------------------------------------------
Download Intel&#174; Parallel Studio Eval
Try the new software tools for yourself. Speed compiling, find bugs
proactively, and fine-tune applications for parallel performance.
See why Intel Parallel Studio got high marks during beta.
http://p.sf.net/sfu/intel-sw-dev
--

[Bug 27402] [r300g] Earth textures in celestia are partially corrupted in all rendering paths

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=27402

--- Comment #9 from Chris Rankin <rankincj@googlemail.com> 2010-04-05 12:58:58 PDT ---
Created an attachment (id=34683)
 --> (https://bugs.freedesktop.org/attachment.cgi?id=34683)
Screenshot of corrupt Earth textures in celestia (plus kernel WARNING)

And the corruption is back again. I took this screenshot using The Gimp, and in
the process triggered this kernel warning:

------------[ cut here ]------------
WARNING: at /home/chris/LINUX/linux-2.6.33/arch/x86/kernel/apic/ipi.c:109
default_send_IPI_mask_logical+0x2a/0xad()
Hardware name: Precision WorkStation 650    
empty IPI mask
Modules linked in: fuse nfsd exportfs uvcvideo videodev v4l1_compat
snd_usb_audio snd_usb_lib autofs4 nfs lockd auth_rpcgss sunrpc p4_clockmod
speedstep_lib af_packet ipt_LOG xt_tcpudp nf_conntrack_ipv4 nf_defrag_ipv4
iptable_filter ip_tables ip6t_LOG nf_conntrack_ipv6 xt_state nf_conntrack
ip6table_filter ip6_tables x_tables ipv6 binfmt_misc dm_mirror dm_region_hash
dm_log dm_mod uinput snd_emu10k1_synth snd_emux_synth snd_seq_virmidi
snd_seq_midi_event snd_seq_midi_emul snd_emu10k1 snd_rawmidi snd_ac97_codec
ac97_bus snd_seq snd_pcm joydev firewire_ohci floppy usbhid snd_seq_device
i2c_i801 ppdev firewire_core pcspkr snd_timer parport_pc sg parport
snd_page_alloc snd_util_mem psmouse snd_hwdep serio_raw snd dcdbas crc_itu_t
soundcore ext3 jbd mbcache sr_mod cdrom sd_mod pata_acpi ata_piix sata_sil
uhci_hcd libata ehci_hcd scsi_mod usbcore e1000 thermal button radeon intel_agp
ttm drm_kms_helper drm agpgart i2c_algo_bit cfbcopyarea cfbimgblt cfbfillrect
[last unloaded: processor]
Pid: 4634, comm: celestia Not tainted 2.6.33.2 #1
Call Trace:
 [<c102559b>] ? warn_slowpath_common+0x5d/0x70
 [<c10171d2>] ? __cpa_flush_range+0x0/0x24
 [<c10255e1>] ? warn_slowpath_fmt+0x26/0x2a
 [<c101274c>] ? default_send_IPI_mask_logical+0x2a/0xad
 [<c10171d2>] ? __cpa_flush_range+0x0/0x24
 [<c1011381>] ? native_send_call_func_ipi+0x4f/0x56
 [<c1043aa0>] ? smp_call_function_many+0x161/0x17a
 [<c10171d2>] ? __cpa_flush_range+0x0/0x24
 [<c1043ae2>] ? smp_call_function+0x29/0x4f
 [<c10171d2>] ? __cpa_flush_range+0x0/0x24
 [<c10297f9>] ? on_each_cpu+0x23/0x50
 [<c1017abe>] ? change_page_attr_set_clr+0x24a/0x2c6
 [<c11da880>] ? _raw_spin_unlock+0xb/0x1f
 [<c1017d44>] ? _set_memory_wc+0x21/0x48
 [<c1017fc4>] ? set_memory_wc+0x61/0x84
 [<f80bac8f>] ? ttm_tt_set_caching+0xb7/0x1a5 [ttm]
 [<f80bb61d>] ? ttm_bo_add_ttm+0x4b/0xb0 [ttm]
 [<f80bbccf>] ? ttm_bo_handle_move_mem+0xd4/0x243 [ttm]
 [<f80bd22b>] ? ttm_bo_move_buffer+0x9b/0xe3 [ttm]
 [<f80bd30f>] ? ttm_bo_validate+0x9c/0xe2 [ttm]
 [<f80bd5e3>] ? ttm_bo_init+0x28e/0x2bc [ttm]
 [<f81a0f49>] ? radeon_bo_create+0xb9/0x142 [radeon]
 [<f81a0fd2>] ? radeon_ttm_bo_destroy+0x0/0x4a [radeon]
 [<f81ad3b7>] ? radeon_gem_object_create+0x64/0xcb [radeon]
 [<f81ad469>] ? radeon_gem_create_ioctl+0x4b/0xcf [radeon]
 [<f8073223>] ? drm_ioctl+0x1f7/0x281 [drm]
 [<f81ad41e>] ? radeon_gem_create_ioctl+0x0/0xcf [radeon]
 [<c11da881>] ? _raw_spin_unlock+0xc/0x1f
 [<f80be520>] ? ttm_bo_vm_fault+0x1f3/0x1fd [ttm]
 [<c102997e>] ? irq_exit+0x38/0x63
 [<f819fba5>] ? radeon_ttm_fault+0x14/0x19 [radeon]
 [<c106fe65>] ? __do_fault+0x40/0x365
 [<c10e663f>] ? prio_tree_insert+0xe9/0x1ce
 [<c10e66a6>] ? prio_tree_insert+0x150/0x1ce
 [<f807302c>] ? drm_ioctl+0x0/0x281 [drm]
 [<c109215d>] ? vfs_ioctl+0x1c/0x7d
 [<c10926c1>] ? do_vfs_ioctl+0x45e/0x4a2
 [<c116a2f7>] ? acpi_pm_read+0xb/0x15
 [<c103bd07>] ? getnstimeofday+0x4e/0xd2
 [<c1092732>] ? sys_ioctl+0x2d/0x46
 [<c100270c>] ? sysenter_do_call+0x12/0x22
---[ end trace 7c5ac0a8dc2bf27c ]---

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

------------------------------------------------------------------------------
Download Intel&#174; Parallel Studio Eval
Try the new software tools for yourself. Speed compiling, find bugs
proactively, and fine-tune applications for parallel performance.
See why Intel Parallel Studio got high marks during beta.
http://p.sf.net/sfu/intel-sw-dev
--

[Bug 27402] [r300g] Earth textures in celestia are partially corrupted in all rendering paths

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=27402

--- Comment #10 from Chris Rankin <rankincj@googlemail.com> 2010-04-13 12:59:00 PDT ---
Earth textures are now completely missing in all rendering paths. Earth has
become Hoth.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

[Bug 27402] [r300g] Earth textures in celestia are partially corrupted in all rendering paths

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=27402

Chris Rankin <rankincj@googlemail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED

--- Comment #11 from Chris Rankin <rankincj@googlemail.com> 2010-04-18 16:12:55 PDT ---
I think this bug can be closed now, as the corrupt textures have finally
disappeared and not come back. In fact, the Earth is now being rendered
correctly (? I think) even with the OpenGL 2.0 path.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.