From: Mel Gorman <mel@csn.ul.ie> To: Andrew Morton <akpm@linux-foundation.org> Cc: Andrea Arcangeli <aarcange@redhat.com>, Christoph Lameter <cl@linux-foundation.org>, Adam Litke <agl@us.ibm.com>, Avi Kivity <avi@redhat.com>, David Rientjes <rientjes@google.com>, Minchan Kim <minchan.kim@gmail.com>, KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>, KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>, Rik van Riel <riel@redhat.com>, linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH 11/14] Direct compact when a high-order allocation fails Date: Wed, 7 Apr 2010 19:29:16 +0100 [thread overview] Message-ID: <20100407182916.GY17882@csn.ul.ie> (raw) In-Reply-To: <20100406170603.8a999dc2.akpm@linux-foundation.org> On Tue, Apr 06, 2010 at 05:06:03PM -0700, Andrew Morton wrote: > > @@ -896,6 +904,9 @@ static const char * const vmstat_text[] = { > > "compact_blocks_moved", > > "compact_pages_moved", > > "compact_pagemigrate_failed", > > + "compact_stall", > > + "compact_fail", > > + "compact_success", > > CONFIG_COMPACTION=n? > This patch goes on top of the series. It looks big but it's mainly moving code. ==== CUT HERE ==== mm,compaction: Do not display compaction-related stats when !CONFIG_COMPACTION Although compaction can be disabled from .config, the vmstat entries still exist. This patch removes the vmstat entries. As page_alloc.c refers directly to the counters, the patch introduces __alloc_pages_direct_compact() to isolate use of the counters. Signed-off-by: Mel Gorman <mel@csn.ul.ie> --- include/linux/vmstat.h | 2 + mm/page_alloc.c | 92 ++++++++++++++++++++++++++++++++--------------- mm/vmstat.c | 2 + 3 files changed, 66 insertions(+), 30 deletions(-) diff --git a/include/linux/vmstat.h b/include/linux/vmstat.h index b4b4d34..7f43ccd 100644 --- a/include/linux/vmstat.h +++ b/include/linux/vmstat.h @@ -43,8 +43,10 @@ enum vm_event_item { PGPGIN, PGPGOUT, PSWPIN, PSWPOUT, KSWAPD_LOW_WMARK_HIT_QUICKLY, KSWAPD_HIGH_WMARK_HIT_QUICKLY, KSWAPD_SKIP_CONGESTION_WAIT, PAGEOUTRUN, ALLOCSTALL, PGROTATED, +#ifdef CONFIG_COMPACTION COMPACTBLOCKS, COMPACTPAGES, COMPACTPAGEFAILED, COMPACTSTALL, COMPACTFAIL, COMPACTSUCCESS, +#endif #ifdef CONFIG_HUGETLB_PAGE HTLB_BUDDY_PGALLOC, HTLB_BUDDY_PGALLOC_FAIL, #endif diff --git a/mm/page_alloc.c b/mm/page_alloc.c index 46f6be4..514cc96 100644 --- a/mm/page_alloc.c +++ b/mm/page_alloc.c @@ -1756,6 +1756,59 @@ out: return page; } +#ifdef CONFIG_COMPACTION +/* Try memory compaction for high-order allocations before reclaim */ +static struct page * +__alloc_pages_direct_compact(gfp_t gfp_mask, unsigned int order, + struct zonelist *zonelist, enum zone_type high_zoneidx, + nodemask_t *nodemask, int alloc_flags, struct zone *preferred_zone, + int migratetype, unsigned long *did_some_progress) +{ + struct page *page; + + if (!order) + return NULL; + + *did_some_progress = try_to_compact_pages(zonelist, order, gfp_mask, + nodemask); + if (*did_some_progress != COMPACT_SKIPPED) { + + /* Page migration frees to the PCP lists but we want merging */ + drain_pages(get_cpu()); + put_cpu(); + + page = get_page_from_freelist(gfp_mask, nodemask, + order, zonelist, high_zoneidx, + alloc_flags, preferred_zone, + migratetype); + if (page) { + __count_vm_event(COMPACTSUCCESS); + return page; + } + + /* + * It's bad if compaction run occurs and fails. + * The most likely reason is that pages exist, + * but not enough to satisfy watermarks. + */ + count_vm_event(COMPACTFAIL); + + cond_resched(); + } + + return NULL; +} +#else +static inline struct page * +__alloc_pages_direct_compact(gfp_t gfp_mask, unsigned int order, + struct zonelist *zonelist, enum zone_type high_zoneidx, + nodemask_t *nodemask, int alloc_flags, struct zone *preferred_zone, + int migratetype, unsigned long *did_some_progress) +{ + return NULL; +} +#endif /* CONFIG_COMPACTION */ + /* The really slow allocator path where we enter direct reclaim */ static inline struct page * __alloc_pages_direct_reclaim(gfp_t gfp_mask, unsigned int order, @@ -1769,36 +1822,6 @@ __alloc_pages_direct_reclaim(gfp_t gfp_mask, unsigned int order, cond_resched(); - /* Try memory compaction for high-order allocations before reclaim */ - if (order) { - *did_some_progress = try_to_compact_pages(zonelist, - order, gfp_mask, nodemask); - if (*did_some_progress != COMPACT_SKIPPED) { - - /* Page migration frees to the PCP lists but we want merging */ - drain_pages(get_cpu()); - put_cpu(); - - page = get_page_from_freelist(gfp_mask, nodemask, - order, zonelist, high_zoneidx, - alloc_flags, preferred_zone, - migratetype); - if (page) { - __count_vm_event(COMPACTSUCCESS); - return page; - } - - /* - * It's bad if compaction run occurs and fails. - * The most likely reason is that pages exist, - * but not enough to satisfy watermarks. - */ - count_vm_event(COMPACTFAIL); - - cond_resched(); - } - } - /* We now go into synchronous reclaim */ cpuset_memory_pressure_bump(); p->flags |= PF_MEMALLOC; @@ -1972,6 +1995,15 @@ rebalance: if (test_thread_flag(TIF_MEMDIE) && !(gfp_mask & __GFP_NOFAIL)) goto nopage; + /* Try direct compaction */ + page = __alloc_pages_direct_compact(gfp_mask, order, + zonelist, high_zoneidx, + nodemask, + alloc_flags, preferred_zone, + migratetype, &did_some_progress); + if (page) + goto got_pg; + /* Try direct reclaim and then allocating */ page = __alloc_pages_direct_reclaim(gfp_mask, order, zonelist, high_zoneidx, diff --git a/mm/vmstat.c b/mm/vmstat.c index 2780a36..0a58cbe 100644 --- a/mm/vmstat.c +++ b/mm/vmstat.c @@ -901,12 +901,14 @@ static const char * const vmstat_text[] = { "pgrotated", +#ifdef CONFIG_COMPACTION "compact_blocks_moved", "compact_pages_moved", "compact_pagemigrate_failed", "compact_stall", "compact_fail", "compact_success", +#endif #ifdef CONFIG_HUGETLB_PAGE "htlb_buddy_alloc_success",
WARNING: multiple messages have this Message-ID (diff)
From: Mel Gorman <mel@csn.ul.ie> To: Andrew Morton <akpm@linux-foundation.org> Cc: Andrea Arcangeli <aarcange@redhat.com>, Christoph Lameter <cl@linux-foundation.org>, Adam Litke <agl@us.ibm.com>, Avi Kivity <avi@redhat.com>, David Rientjes <rientjes@google.com>, Minchan Kim <minchan.kim@gmail.com>, KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>, KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>, Rik van Riel <riel@redhat.com>, linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH 11/14] Direct compact when a high-order allocation fails Date: Wed, 7 Apr 2010 19:29:16 +0100 [thread overview] Message-ID: <20100407182916.GY17882@csn.ul.ie> (raw) In-Reply-To: <20100406170603.8a999dc2.akpm@linux-foundation.org> On Tue, Apr 06, 2010 at 05:06:03PM -0700, Andrew Morton wrote: > > @@ -896,6 +904,9 @@ static const char * const vmstat_text[] = { > > "compact_blocks_moved", > > "compact_pages_moved", > > "compact_pagemigrate_failed", > > + "compact_stall", > > + "compact_fail", > > + "compact_success", > > CONFIG_COMPACTION=n? > This patch goes on top of the series. It looks big but it's mainly moving code. ==== CUT HERE ==== mm,compaction: Do not display compaction-related stats when !CONFIG_COMPACTION Although compaction can be disabled from .config, the vmstat entries still exist. This patch removes the vmstat entries. As page_alloc.c refers directly to the counters, the patch introduces __alloc_pages_direct_compact() to isolate use of the counters. Signed-off-by: Mel Gorman <mel@csn.ul.ie> --- include/linux/vmstat.h | 2 + mm/page_alloc.c | 92 ++++++++++++++++++++++++++++++++--------------- mm/vmstat.c | 2 + 3 files changed, 66 insertions(+), 30 deletions(-) diff --git a/include/linux/vmstat.h b/include/linux/vmstat.h index b4b4d34..7f43ccd 100644 --- a/include/linux/vmstat.h +++ b/include/linux/vmstat.h @@ -43,8 +43,10 @@ enum vm_event_item { PGPGIN, PGPGOUT, PSWPIN, PSWPOUT, KSWAPD_LOW_WMARK_HIT_QUICKLY, KSWAPD_HIGH_WMARK_HIT_QUICKLY, KSWAPD_SKIP_CONGESTION_WAIT, PAGEOUTRUN, ALLOCSTALL, PGROTATED, +#ifdef CONFIG_COMPACTION COMPACTBLOCKS, COMPACTPAGES, COMPACTPAGEFAILED, COMPACTSTALL, COMPACTFAIL, COMPACTSUCCESS, +#endif #ifdef CONFIG_HUGETLB_PAGE HTLB_BUDDY_PGALLOC, HTLB_BUDDY_PGALLOC_FAIL, #endif diff --git a/mm/page_alloc.c b/mm/page_alloc.c index 46f6be4..514cc96 100644 --- a/mm/page_alloc.c +++ b/mm/page_alloc.c @@ -1756,6 +1756,59 @@ out: return page; } +#ifdef CONFIG_COMPACTION +/* Try memory compaction for high-order allocations before reclaim */ +static struct page * +__alloc_pages_direct_compact(gfp_t gfp_mask, unsigned int order, + struct zonelist *zonelist, enum zone_type high_zoneidx, + nodemask_t *nodemask, int alloc_flags, struct zone *preferred_zone, + int migratetype, unsigned long *did_some_progress) +{ + struct page *page; + + if (!order) + return NULL; + + *did_some_progress = try_to_compact_pages(zonelist, order, gfp_mask, + nodemask); + if (*did_some_progress != COMPACT_SKIPPED) { + + /* Page migration frees to the PCP lists but we want merging */ + drain_pages(get_cpu()); + put_cpu(); + + page = get_page_from_freelist(gfp_mask, nodemask, + order, zonelist, high_zoneidx, + alloc_flags, preferred_zone, + migratetype); + if (page) { + __count_vm_event(COMPACTSUCCESS); + return page; + } + + /* + * It's bad if compaction run occurs and fails. + * The most likely reason is that pages exist, + * but not enough to satisfy watermarks. + */ + count_vm_event(COMPACTFAIL); + + cond_resched(); + } + + return NULL; +} +#else +static inline struct page * +__alloc_pages_direct_compact(gfp_t gfp_mask, unsigned int order, + struct zonelist *zonelist, enum zone_type high_zoneidx, + nodemask_t *nodemask, int alloc_flags, struct zone *preferred_zone, + int migratetype, unsigned long *did_some_progress) +{ + return NULL; +} +#endif /* CONFIG_COMPACTION */ + /* The really slow allocator path where we enter direct reclaim */ static inline struct page * __alloc_pages_direct_reclaim(gfp_t gfp_mask, unsigned int order, @@ -1769,36 +1822,6 @@ __alloc_pages_direct_reclaim(gfp_t gfp_mask, unsigned int order, cond_resched(); - /* Try memory compaction for high-order allocations before reclaim */ - if (order) { - *did_some_progress = try_to_compact_pages(zonelist, - order, gfp_mask, nodemask); - if (*did_some_progress != COMPACT_SKIPPED) { - - /* Page migration frees to the PCP lists but we want merging */ - drain_pages(get_cpu()); - put_cpu(); - - page = get_page_from_freelist(gfp_mask, nodemask, - order, zonelist, high_zoneidx, - alloc_flags, preferred_zone, - migratetype); - if (page) { - __count_vm_event(COMPACTSUCCESS); - return page; - } - - /* - * It's bad if compaction run occurs and fails. - * The most likely reason is that pages exist, - * but not enough to satisfy watermarks. - */ - count_vm_event(COMPACTFAIL); - - cond_resched(); - } - } - /* We now go into synchronous reclaim */ cpuset_memory_pressure_bump(); p->flags |= PF_MEMALLOC; @@ -1972,6 +1995,15 @@ rebalance: if (test_thread_flag(TIF_MEMDIE) && !(gfp_mask & __GFP_NOFAIL)) goto nopage; + /* Try direct compaction */ + page = __alloc_pages_direct_compact(gfp_mask, order, + zonelist, high_zoneidx, + nodemask, + alloc_flags, preferred_zone, + migratetype, &did_some_progress); + if (page) + goto got_pg; + /* Try direct reclaim and then allocating */ page = __alloc_pages_direct_reclaim(gfp_mask, order, zonelist, high_zoneidx, diff --git a/mm/vmstat.c b/mm/vmstat.c index 2780a36..0a58cbe 100644 --- a/mm/vmstat.c +++ b/mm/vmstat.c @@ -901,12 +901,14 @@ static const char * const vmstat_text[] = { "pgrotated", +#ifdef CONFIG_COMPACTION "compact_blocks_moved", "compact_pages_moved", "compact_pagemigrate_failed", "compact_stall", "compact_fail", "compact_success", +#endif #ifdef CONFIG_HUGETLB_PAGE "htlb_buddy_alloc_success", -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2010-04-07 18:29 UTC|newest] Thread overview: 112+ messages / expand[flat|nested] mbox.gz Atom feed top 2010-04-02 16:02 [PATCH 0/14] Memory Compaction v7 Mel Gorman 2010-04-02 16:02 ` Mel Gorman 2010-04-02 16:02 ` [PATCH 01/14] mm,migration: Take a reference to the anon_vma before migrating Mel Gorman 2010-04-02 16:02 ` Mel Gorman 2010-04-07 0:05 ` Andrew Morton 2010-04-07 0:05 ` Andrew Morton 2010-04-07 9:56 ` Mel Gorman 2010-04-07 9:56 ` Mel Gorman 2010-04-02 16:02 ` [PATCH 02/14] mm,migration: Do not try to migrate unmapped anonymous pages Mel Gorman 2010-04-02 16:02 ` Mel Gorman 2010-04-02 16:02 ` [PATCH 03/14] mm: Share the anon_vma ref counts between KSM and page migration Mel Gorman 2010-04-02 16:02 ` Mel Gorman 2010-04-07 0:05 ` Andrew Morton 2010-04-07 0:05 ` Andrew Morton 2010-04-07 0:10 ` Rik van Riel 2010-04-07 0:10 ` Rik van Riel 2010-04-07 10:01 ` Mel Gorman 2010-04-07 10:01 ` Mel Gorman 2010-04-02 16:02 ` [PATCH 04/14] Allow CONFIG_MIGRATION to be set without CONFIG_NUMA or memory hot-remove Mel Gorman 2010-04-02 16:02 ` Mel Gorman 2010-04-07 0:05 ` Andrew Morton 2010-04-07 0:05 ` Andrew Morton 2010-04-07 10:22 ` Mel Gorman 2010-04-07 10:22 ` Mel Gorman 2010-04-02 16:02 ` [PATCH 05/14] Export unusable free space index via /proc/unusable_index Mel Gorman 2010-04-02 16:02 ` Mel Gorman 2010-04-07 0:05 ` Andrew Morton 2010-04-07 0:05 ` Andrew Morton 2010-04-07 10:35 ` Mel Gorman 2010-04-07 10:35 ` Mel Gorman 2010-04-13 12:42 ` Mel Gorman 2010-04-13 12:42 ` Mel Gorman 2010-04-02 16:02 ` [PATCH 06/14] Export fragmentation index via /proc/extfrag_index Mel Gorman 2010-04-02 16:02 ` Mel Gorman 2010-04-07 0:05 ` Andrew Morton 2010-04-07 0:05 ` Andrew Morton 2010-04-07 10:46 ` Mel Gorman 2010-04-07 10:46 ` Mel Gorman 2010-04-13 12:43 ` Mel Gorman 2010-04-13 12:43 ` Mel Gorman 2010-04-02 16:02 ` [PATCH 07/14] Move definition for LRU isolation modes to a header Mel Gorman 2010-04-02 16:02 ` Mel Gorman 2010-04-02 16:02 ` [PATCH 08/14] Memory compaction core Mel Gorman 2010-04-02 16:02 ` Mel Gorman 2010-04-07 0:05 ` Andrew Morton 2010-04-07 0:05 ` Andrew Morton 2010-04-07 15:21 ` Mel Gorman 2010-04-07 15:21 ` Mel Gorman 2010-04-08 16:59 ` Mel Gorman 2010-04-08 16:59 ` Mel Gorman 2010-04-08 17:06 ` Andrea Arcangeli 2010-04-08 17:06 ` Andrea Arcangeli 2010-04-02 16:02 ` [PATCH 09/14] Add /proc trigger for memory compaction Mel Gorman 2010-04-02 16:02 ` Mel Gorman 2010-04-07 0:05 ` Andrew Morton 2010-04-07 0:05 ` Andrew Morton 2010-04-07 15:39 ` Mel Gorman 2010-04-07 15:39 ` Mel Gorman 2010-04-07 18:27 ` Mel Gorman 2010-04-07 18:27 ` Mel Gorman 2010-04-02 16:02 ` [PATCH 10/14] Add /sys trigger for per-node " Mel Gorman 2010-04-02 16:02 ` Mel Gorman 2010-04-07 0:05 ` Andrew Morton 2010-04-07 0:05 ` Andrew Morton 2010-04-07 0:31 ` KAMEZAWA Hiroyuki 2010-04-07 0:31 ` KAMEZAWA Hiroyuki 2010-04-06 21:56 ` Andrew Morton 2010-04-06 21:56 ` Andrew Morton 2010-04-07 1:19 ` KAMEZAWA Hiroyuki 2010-04-07 1:19 ` KAMEZAWA Hiroyuki 2010-04-07 15:42 ` Mel Gorman 2010-04-07 15:42 ` Mel Gorman 2010-04-02 16:02 ` [PATCH 11/14] Direct compact when a high-order allocation fails Mel Gorman 2010-04-02 16:02 ` Mel Gorman 2010-04-07 0:06 ` Andrew Morton 2010-04-07 0:06 ` Andrew Morton 2010-04-07 16:06 ` Mel Gorman 2010-04-07 16:06 ` Mel Gorman 2010-04-07 18:29 ` Mel Gorman [this message] 2010-04-07 18:29 ` Mel Gorman 2010-04-02 16:02 ` [PATCH 12/14] Add a tunable that decides when memory should be compacted and when it should be reclaimed Mel Gorman 2010-04-02 16:02 ` Mel Gorman 2010-04-07 0:06 ` Andrew Morton 2010-04-07 0:06 ` Andrew Morton 2010-04-07 16:11 ` Mel Gorman 2010-04-07 16:11 ` Mel Gorman 2010-04-02 16:02 ` [PATCH 13/14] Do not compact within a preferred zone after a compaction failure Mel Gorman 2010-04-02 16:02 ` Mel Gorman 2010-04-07 0:06 ` Andrew Morton 2010-04-07 0:06 ` Andrew Morton 2010-04-07 0:55 ` Andrea Arcangeli 2010-04-07 0:55 ` Andrea Arcangeli 2010-04-07 16:32 ` Mel Gorman 2010-04-07 16:32 ` Mel Gorman 2010-04-02 16:02 ` [PATCH 14/14] mm,migration: Allow the migration of PageSwapCache pages Mel Gorman 2010-04-02 16:02 ` Mel Gorman 2010-04-06 6:54 ` KAMEZAWA Hiroyuki 2010-04-06 6:54 ` KAMEZAWA Hiroyuki 2010-04-06 15:37 ` Minchan Kim 2010-04-06 15:37 ` Minchan Kim 2010-04-07 0:06 ` Andrew Morton 2010-04-07 0:06 ` Andrew Morton 2010-04-07 16:49 ` Mel Gorman 2010-04-07 16:49 ` Mel Gorman 2010-04-06 14:47 ` [PATCH 0/14] Memory Compaction v7 Tarkan Erimer 2010-04-06 14:47 ` Tarkan Erimer 2010-04-06 15:00 ` Mel Gorman 2010-04-06 15:00 ` Mel Gorman 2010-04-06 15:03 ` Tarkan Erimer 2010-04-06 15:03 ` Tarkan Erimer -- strict thread matches above, loose matches on Subject: below -- 2010-03-30 9:14 [PATCH 0/14] Memory Compaction v6 Mel Gorman 2010-03-30 9:14 ` [PATCH 11/14] Direct compact when a high-order allocation fails Mel Gorman 2010-03-30 9:14 ` Mel Gorman
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20100407182916.GY17882@csn.ul.ie \ --to=mel@csn.ul.ie \ --cc=aarcange@redhat.com \ --cc=agl@us.ibm.com \ --cc=akpm@linux-foundation.org \ --cc=avi@redhat.com \ --cc=cl@linux-foundation.org \ --cc=kamezawa.hiroyu@jp.fujitsu.com \ --cc=kosaki.motohiro@jp.fujitsu.com \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-mm@kvack.org \ --cc=minchan.kim@gmail.com \ --cc=riel@redhat.com \ --cc=rientjes@google.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.