* [PATCH] net: fix definition of netdev_for_each_mc_addr()
@ 2010-04-07 22:01 Pavel Roskin
2010-04-07 23:40 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Pavel Roskin @ 2010-04-07 22:01 UTC (permalink / raw)
To: netdev, David Miller
The first argument should be called ha, not mclist. All callers use the
name "ha", but if they used a different name, there would be a compile
error.
Signed-off-by: Pavel Roskin <proski@gnu.org>
---
This is against the current net-next.
include/linux/netdevice.h | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/include/linux/netdevice.h b/include/linux/netdevice.h
index a343a21..d1a21b5 100644
--- a/include/linux/netdevice.h
+++ b/include/linux/netdevice.h
@@ -260,7 +260,7 @@ struct netdev_hw_addr_list {
#define netdev_mc_count(dev) netdev_hw_addr_list_count(&(dev)->mc)
#define netdev_mc_empty(dev) netdev_hw_addr_list_empty(&(dev)->mc)
-#define netdev_for_each_mc_addr(mclist, dev) \
+#define netdev_for_each_mc_addr(ha, dev) \
netdev_hw_addr_list_for_each(ha, &(dev)->mc)
struct hh_cache {
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] net: fix definition of netdev_for_each_mc_addr()
2010-04-07 22:01 [PATCH] net: fix definition of netdev_for_each_mc_addr() Pavel Roskin
@ 2010-04-07 23:40 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2010-04-07 23:40 UTC (permalink / raw)
To: proski; +Cc: netdev
From: Pavel Roskin <proski@gnu.org>
Date: Wed, 07 Apr 2010 18:01:52 -0400
> The first argument should be called ha, not mclist. All callers use the
> name "ha", but if they used a different name, there would be a compile
> error.
>
> Signed-off-by: Pavel Roskin <proski@gnu.org>
Applied, thank you.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-04-07 23:40 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2010-04-07 22:01 [PATCH] net: fix definition of netdev_for_each_mc_addr() Pavel Roskin
2010-04-07 23:40 ` David Miller
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.