* [net-2.6 PATCH] e1000e: stop cleaning when we reach tx_ring->next_to_use
@ 2010-04-09 20:29 Jeff Kirsher
2010-04-13 10:09 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Jeff Kirsher @ 2010-04-09 20:29 UTC (permalink / raw)
To: davem; +Cc: netdev, gospo, Terry Loftin, Bruce Allan, Jeff Kirsher
From: Terry Loftin <terry.loftin@hp.com>
Tx ring buffers after tx_ring->next_to_use are volatile and could
change, possibly causing a crash. Stop cleaning when we hit
tx_ring->next_to_use.
Signed-off-by: Terry Loftin <terry.loftin@hp.com>
Acked-by: Bruce Allan <bruce.w.allan@intel.com>
Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
---
drivers/net/e1000e/netdev.c | 2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/drivers/net/e1000e/netdev.c b/drivers/net/e1000e/netdev.c
index e1cceb6..60288e4 100644
--- a/drivers/net/e1000e/netdev.c
+++ b/drivers/net/e1000e/netdev.c
@@ -660,6 +660,8 @@ static bool e1000_clean_tx_irq(struct e1000_adapter *adapter)
i = 0;
}
+ if (i == tx_ring->next_to_use)
+ break;
eop = tx_ring->buffer_info[i].next_to_watch;
eop_desc = E1000_TX_DESC(*tx_ring, eop);
}
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [net-2.6 PATCH] e1000e: stop cleaning when we reach tx_ring->next_to_use
2010-04-09 20:29 [net-2.6 PATCH] e1000e: stop cleaning when we reach tx_ring->next_to_use Jeff Kirsher
@ 2010-04-13 10:09 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2010-04-13 10:09 UTC (permalink / raw)
To: jeffrey.t.kirsher; +Cc: netdev, gospo, terry.loftin, bruce.w.allan
From: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Date: Fri, 09 Apr 2010 13:29:49 -0700
> From: Terry Loftin <terry.loftin@hp.com>
>
> Tx ring buffers after tx_ring->next_to_use are volatile and could
> change, possibly causing a crash. Stop cleaning when we hit
> tx_ring->next_to_use.
>
> Signed-off-by: Terry Loftin <terry.loftin@hp.com>
> Acked-by: Bruce Allan <bruce.w.allan@intel.com>
> Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Applied.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-04-13 10:09 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2010-04-09 20:29 [net-2.6 PATCH] e1000e: stop cleaning when we reach tx_ring->next_to_use Jeff Kirsher
2010-04-13 10:09 ` David Miller
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.