[U-Boot] [PATCH 4/7] Adding uC5272 dimm module support

[Wolfgang Denk <wd@denx.de>]

Dear "David Wu",

In message <op.vatgy5upqigx4y@cyprus.local> you wrote:
> Signed-off-by: David Wu <davidwu@arcturusnetworks.com>
> ---
>   Makefile                         |   46 +++++
>   board/Arcturus/uC5272/Makefile   |   44 +++++
>   board/Arcturus/uC5272/config.mk  |    1 +
>   board/Arcturus/uC5272/u-boot.lds |  142 +++++++++++++++
>   board/Arcturus/uC5272/uC5272.c   |   57 ++++++
>   include/configs/uC5272.h         |  354  
> ++++++++++++++++++++++++++++++++++++++
>   6 files changed, 644 insertions(+), 0 deletions(-)
>   create mode 100644 board/Arcturus/uC5272/Makefile
>   create mode 100644 board/Arcturus/uC5272/config.mk
>   create mode 100644 board/Arcturus/uC5272/u-boot.lds
>   create mode 100644 board/Arcturus/uC5272/uC5272.c
>   create mode 100644 include/configs/uC5272.h
> 
> diff --git a/Makefile b/Makefile
> index 1b61049..c9215d0 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -2222,6 +2222,52 @@ M5485HFE_config :	unconfig
>   TASREG_config :		unconfig
>   	@$(MKCONFIG) $(@:_config=) m68k mcf52x2 tasreg esd
> 
> +uC5272-4E16U48_config \
> +uC5272-8EE16U66_config \
> +uC5272-8E32U66_config \
> +uC5272-4EE16U48_config \
> +uC5272-4E8U48_config \
> +uC5272-4EE8U48_config \
> +uC5272-4E8U66_config \
> +uC5272-4EE8U66_config \
> +uC5272-4E16U66_config \
> +uC5272-4EE16U66_config \
> +uC5272-4EE32U66_config \
> +uC5272-8EE32U66_config:		unconfig
> +	@mkdir -p $(obj)include
> +	@if [ "$(findstring U48,$@)" ] ; then \
> +		echo "#define SYSCLK_48MHZ " >>$(obj)include/config.h ;\
> +	fi ;
> +	@if [ "$(findstring U66,$@)" ] ; then \
> +		echo "#define SYSCLK_66MHZ " >>$(obj)include/config.h ;\
> +	fi ;
> +	@if [ "$(findstring EE,$@)" ] ; then \
> +		echo "#define HAS_ETH1 " >>$(obj)include/config.h ;\
> +	fi ;
> +	@if [ "$(findstring 4E,$@)" ] ; then \
> +		echo "#define __4MFlash__ " >>$(obj)include/config.h ;\
> +		echo "#define CONFIG_SYS_FLASH_SIZE 0x00400000"  
> >>$(obj)include/config.h ;\
> +		echo "TEXT_BASE = 0x10c00000" > board/Arcturus/uC5272/config.mk ;\
> +	fi ;
> +	@if [ "$(findstring 8E,$@)" ] ; then \
> +		echo "#define __8MFlash__ " >>$(obj)include/config.h ;\
> +		echo "#define CONFIG_SYS_FLASH_SIZE 0x00800000"  
> >>$(obj)include/config.h ;\
> +		echo "TEXT_BASE = 0x40000000" > board/Arcturus/uC5272/config.mk ;\
> +	fi ;
> +	@if [ "$(findstring E8,$@)" ] ; then \
> +		echo "#define __8MRam__ " >>$(obj)include/config.h ;\
> +		echo "#define CONFIG_SYS_SDRAM_SIZE 8" >>$(obj)include/config.h ;\
> +	fi ;
> +	@if [ "$(findstring E16,$@)" ] ; then \
> +		echo "#define __16MRam__ " >>$(obj)include/config.h ;\
> +		echo "#define CONFIG_SYS_SDRAM_SIZE 16" >>$(obj)include/config.h ;\
> +	fi ;
> +	@if [ "$(findstring E32,$@)" ] ; then \
> +		echo "#define __32MRam__ " >>$(obj)include/config.h ;\
> +		echo "#define CONFIG_SYS_SDRAM_SIZE 32" >>$(obj)include/config.h ;\
> +	fi ;
> +	@$(MKCONFIG) -a uC5272 m68k mcf52x2 uC5272 Arcturus
> +

NAK!


You must be joking.

We will not accept such a mess of scriting in the top level Makefile.


Also, I don't understand why adding DIMM module support would result
in a new config.mk file and a new linker script being added?

The additions to the board config file are an unacceptable mess, too.

This needs a complete rework.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
"It ain't so much the things we don't know that get  us  in  trouble.
It's  the  things  we know that ain't so." - Artemus Ward aka Charles
Farrar Brown