All of lore.kernel.org
 help / color / mirror / Atom feed
From: Marek Vasut <marek.vasut@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] PXAMMC: Drop different delays for PXA27X
Date: Wed, 14 Apr 2010 21:43:27 +0200	[thread overview]
Message-ID: <201004142143.27279.marek.vasut@gmail.com> (raw)
In-Reply-To: <1270427570-29948-1-git-send-email-marek.vasut@gmail.com>

Dne Po 5. dubna 2010 02:32:50 Marek Vasut napsal(a):
> In case the delays were set to 10000, the MMC card on PXA27X boards (and
> PXA3xx boards) didn't initialize on first try. Increasing the delays and
> leaving just those for PXA25x and 26x (that is 200000) fixes this problem.
> 
> Signed-off-by: Marek Vasut <marek.vasut@gmail.com>
> ---
>  drivers/mmc/pxa_mmc.c |    8 --------
>  1 files changed, 0 insertions(+), 8 deletions(-)
> 
> diff --git a/drivers/mmc/pxa_mmc.c b/drivers/mmc/pxa_mmc.c
> index 8225235..b155541 100644
> --- a/drivers/mmc/pxa_mmc.c
> +++ b/drivers/mmc/pxa_mmc.c
> @@ -584,11 +584,7 @@ mmc_legacy_init(int verbose)
>  			debug("Detected SD card\n");
>  			break;
>  		}
> -#ifdef CONFIG_PXA27X
> -		udelay(10000);
> -#else
>  		udelay(200000);
> -#endif
>  	}
> 
>  	if (retries <= 0 || !(IF_TYPE_SD == mmc_dev.if_type)) {
> @@ -598,11 +594,7 @@ mmc_legacy_init(int verbose)
> 
>  		retries = 10;
>  		while (retries-- && resp && !(resp[0] & 0x80000000)) {
> -#ifdef CONFIG_PXA27X
> -			udelay(10000);
> -#else
>  			udelay(200000);
> -#endif
>  			resp =
>  			    mmc_cmd(MMC_CMD_SEND_OP_COND, 0x00ff, 0x8000,
>  				    MMC_CMDAT_R3);

CCed Andy Fleming. Please review. Thanks.

  reply	other threads:[~2010-04-14 19:43 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-04-05  0:32 [U-Boot] [PATCH] PXAMMC: Drop different delays for PXA27X Marek Vasut
2010-04-14 19:43 ` Marek Vasut [this message]
2010-04-24  1:13 ` Andy Fleming
2010-04-24  1:29   ` Marek Vasut
2010-04-24  1:39     ` Andy Fleming
2010-04-24 11:30       ` Marek Vasut

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201004142143.27279.marek.vasut@gmail.com \
    --to=marek.vasut@gmail.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.