From: Andy Fleming <afleming@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] PXAMMC: Drop different delays for PXA27X
Date: Fri, 23 Apr 2010 20:39:24 -0500 [thread overview]
Message-ID: <k2r2acbd3e41004231839ocb11feackf9cae29d513d8e3@mail.gmail.com> (raw)
In-Reply-To: <201004240329.34513.marek.vasut@gmail.com>
On Fri, Apr 23, 2010 at 8:29 PM, Marek Vasut <marek.vasut@gmail.com> wrote:
> Dne So 24. dubna 2010 03:13:07 Andy Fleming napsal(a):
>> On Sun, Apr 4, 2010 at 7:32 PM, Marek Vasut <marek.vasut@gmail.com> wrote:
>> > In case the delays were set to 10000, the MMC card on PXA27X boards (and
>> > PXA3xx boards) didn't initialize on first try. Increasing the delays and
>> > leaving just those for PXA25x and 26x (that is 200000) fixes this
>> > problem.
>>
>> In general, I object to board-specific #ifdefs in drivers.
>
> This is not a board specific ifdef.
I'm sorry, I misread the patch completely. I assumed you were adding
the #ifdefs, instead of removing them, as that is the usual pattern,
and I had misunderstood your patch description. 200000us is a long
time. Are you sure it's necessary (would 100000 work)? Let me know,
and I'll apply this patch.
Andy
next prev parent reply other threads:[~2010-04-24 1:39 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-05 0:32 [U-Boot] [PATCH] PXAMMC: Drop different delays for PXA27X Marek Vasut
2010-04-14 19:43 ` Marek Vasut
2010-04-24 1:13 ` Andy Fleming
2010-04-24 1:29 ` Marek Vasut
2010-04-24 1:39 ` Andy Fleming [this message]
2010-04-24 11:30 ` Marek Vasut
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=k2r2acbd3e41004231839ocb11feackf9cae29d513d8e3@mail.gmail.com \
--to=afleming@gmail.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.