* Re: [net-next-2.6 PATCH 2/2] net: replace ipfragok with skb->local_df
[not found] <4BC70EF1.6080400@cn.fujitsu.com>
@ 2010-04-15 22:33 ` David Miller
[not found] ` <20100415151926.GA4813@gondor.apana.org.au>
1 sibling, 0 replies; 10+ messages in thread
From: David Miller @ 2010-04-15 22:33 UTC (permalink / raw)
To: shanwei
Cc: herbert, yinghai.lu, kuznet, pekkas, jmorris, yoshfuji, kaber,
<netdev@vger.kernel.org>,
dccp@vger.kernel.org, linux-sctp@vger.kernel.org
Your netdev entry on the CC: list was literally:
" <netdev@vger.kernel.org>,
which caused your patch to not make it netdev and therefore
it also didn't make it into patchwork.
Please resubmit your patches (both of them) with the CC:
list fixed up.
Thank you.
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [net-next-2.6 PATCH 2/2] net: replace ipfragok with skb->local_df
[not found] ` <20100415151926.GA4813@gondor.apana.org.au>
2010-04-16 2:26 ` Shan Wei
@ 2010-04-16 2:26 ` Shan Wei
0 siblings, 0 replies; 10+ messages in thread
From: Shan Wei @ 2010-04-16 2:26 UTC (permalink / raw)
To: Herbert Xu
Cc: David Miller, yinghai.lu, kuznet, pekkas, jmorris,
yoshfuji@linux-ipv6.org >> YOSHIFUJI Hideaki,
Patrick McHardy, netdev, dccp, linux-sctp, kleptog, jchapman,
mostrows, acme
Herbert Xu wrote, at 04/15/2010 11:19 PM:
> On Thu, Apr 15, 2010 at 09:04:49PM +0800, Shan Wei wrote:
>> As Herbert Xu said: we should be able to simply replace ipfragok
>> with skb->local_df. commit f88037(sctp: Drop ipfargok in sctp_xmit function)
>> has droped ipfragok and set local_df value properly.
>>
>> The patch kills the ipfragok parameter of .queue_xmit().
>
> Both patches look good to me.
>
>> @@ -370,7 +370,7 @@ packet_routed:
>> skb_reset_network_header(skb);
>> iph = ip_hdr(skb);
>> *((__be16 *)iph) = htons((4 << 12) | (5 << 8) | (inet->tos & 0xff));
>> - if (ip_dont_fragment(sk, &rt->u.dst) && !ipfragok)
>> + if (ip_dont_fragment(sk, &rt->u.dst) && !skb->local_df)
>> iph->frag_off = htons(IP_DF);
>> else
>> iph->frag_off = 0;
>
> This hunk looked suspecious at first. However, it is OK because
> ever calls this with ipfragok == 1, or local_df == 1.
>
> The first is obvious from this patch itself, the second not quite
> so obvious.
>
> As nobody calls it with local_df == 1 anyway, and strictly speaking
> local_df shouldn't be set at all by the caller of ip_queue_xmit, we
> should simply remove the && ... bit and have
>
> if (ip_dont_fragment(sk, &rt->u.dst))
Now, PPPoX/PPPoL2TP driver still use ip_queue_xmit to send packets with ipfragok == 1.
So, now we can't remove the && ... bit.
--
Best Regards
-----
Shan Wei
>
> Cheers,
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [net-next-2.6 PATCH 2/2] net: replace ipfragok with skb->local_df
@ 2010-04-16 2:26 ` Shan Wei
0 siblings, 0 replies; 10+ messages in thread
From: Shan Wei @ 2010-04-16 2:26 UTC (permalink / raw)
To: Herbert Xu
Cc: David Miller, yinghai.lu, kuznet, pekkas, jmorris,
yoshfuji@linux-ipv6.org >> YOSHIFUJI Hideaki,
Patrick McHardy, netdev, dccp, linux-sctp, kleptog, jchapman,
mostrows, acme
Herbert Xu wrote, at 04/15/2010 11:19 PM:
> On Thu, Apr 15, 2010 at 09:04:49PM +0800, Shan Wei wrote:
>> As Herbert Xu said: we should be able to simply replace ipfragok
>> with skb->local_df. commit f88037(sctp: Drop ipfargok in sctp_xmit function)
>> has droped ipfragok and set local_df value properly.
>>
>> The patch kills the ipfragok parameter of .queue_xmit().
>
> Both patches look good to me.
>
>> @@ -370,7 +370,7 @@ packet_routed:
>> skb_reset_network_header(skb);
>> iph = ip_hdr(skb);
>> *((__be16 *)iph) = htons((4 << 12) | (5 << 8) | (inet->tos & 0xff));
>> - if (ip_dont_fragment(sk, &rt->u.dst) && !ipfragok)
>> + if (ip_dont_fragment(sk, &rt->u.dst) && !skb->local_df)
>> iph->frag_off = htons(IP_DF);
>> else
>> iph->frag_off = 0;
>
> This hunk looked suspecious at first. However, it is OK because
> ever calls this with ipfragok = 1, or local_df = 1.
>
> The first is obvious from this patch itself, the second not quite
> so obvious.
>
> As nobody calls it with local_df = 1 anyway, and strictly speaking
> local_df shouldn't be set at all by the caller of ip_queue_xmit, we
> should simply remove the && ... bit and have
>
> if (ip_dont_fragment(sk, &rt->u.dst))
Now, PPPoX/PPPoL2TP driver still use ip_queue_xmit to send packets with ipfragok = 1.
So, now we can't remove the && ... bit.
--
Best Regards
-----
Shan Wei
>
> Cheers,
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [net-next-2.6 PATCH 2/2] net: replace ipfragok with skb->local_df
@ 2010-04-16 2:26 ` Shan Wei
0 siblings, 0 replies; 10+ messages in thread
From: Shan Wei @ 2010-04-16 2:26 UTC (permalink / raw)
To: dccp
Herbert Xu wrote, at 04/15/2010 11:19 PM:
> On Thu, Apr 15, 2010 at 09:04:49PM +0800, Shan Wei wrote:
>> As Herbert Xu said: we should be able to simply replace ipfragok
>> with skb->local_df. commit f88037(sctp: Drop ipfargok in sctp_xmit function)
>> has droped ipfragok and set local_df value properly.
>>
>> The patch kills the ipfragok parameter of .queue_xmit().
>
> Both patches look good to me.
>
>> @@ -370,7 +370,7 @@ packet_routed:
>> skb_reset_network_header(skb);
>> iph = ip_hdr(skb);
>> *((__be16 *)iph) = htons((4 << 12) | (5 << 8) | (inet->tos & 0xff));
>> - if (ip_dont_fragment(sk, &rt->u.dst) && !ipfragok)
>> + if (ip_dont_fragment(sk, &rt->u.dst) && !skb->local_df)
>> iph->frag_off = htons(IP_DF);
>> else
>> iph->frag_off = 0;
>
> This hunk looked suspecious at first. However, it is OK because
> ever calls this with ipfragok = 1, or local_df = 1.
>
> The first is obvious from this patch itself, the second not quite
> so obvious.
>
> As nobody calls it with local_df = 1 anyway, and strictly speaking
> local_df shouldn't be set at all by the caller of ip_queue_xmit, we
> should simply remove the && ... bit and have
>
> if (ip_dont_fragment(sk, &rt->u.dst))
Now, PPPoX/PPPoL2TP driver still use ip_queue_xmit to send packets with ipfragok = 1.
So, now we can't remove the && ... bit.
--
Best Regards
-----
Shan Wei
>
> Cheers,
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [net-next-2.6 PATCH 2/2] net: replace ipfragok with skb->local_df
2010-04-16 2:26 ` Shan Wei
(?)
@ 2010-04-16 6:43 ` Herbert Xu
-1 siblings, 0 replies; 10+ messages in thread
From: Herbert Xu @ 2010-04-16 6:43 UTC (permalink / raw)
To: Shan Wei
Cc: David Miller, yinghai.lu, kuznet, pekkas, jmorris,
yoshfuji@linux-ipv6.org >> YOSHIFUJI Hideaki,
Patrick McHardy, netdev, dccp, linux-sctp, kleptog, jchapman,
mostrows, acme
On Fri, Apr 16, 2010 at 10:26:09AM +0800, Shan Wei wrote:
>
> Now, PPPoX/PPPoL2TP driver still use ip_queue_xmit to send packets with ipfragok == 1.
> So, now we can't remove the && ... bit.
Huh? If they still call ip_queue_xmit with ipfragok then surely
the build will fail after your patch as it removes the ipfragok
argument?
Cheers,
--
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [net-next-2.6 PATCH 2/2] net: replace ipfragok with
@ 2010-04-16 6:43 ` Herbert Xu
0 siblings, 0 replies; 10+ messages in thread
From: Herbert Xu @ 2010-04-16 6:43 UTC (permalink / raw)
To: Shan Wei
Cc: David Miller, yinghai.lu, kuznet, pekkas, jmorris,
yoshfuji@linux-ipv6.org >> YOSHIFUJI Hideaki,
Patrick McHardy, netdev, dccp, linux-sctp, kleptog, jchapman,
mostrows, acme
On Fri, Apr 16, 2010 at 10:26:09AM +0800, Shan Wei wrote:
>
> Now, PPPoX/PPPoL2TP driver still use ip_queue_xmit to send packets with ipfragok = 1.
> So, now we can't remove the && ... bit.
Huh? If they still call ip_queue_xmit with ipfragok then surely
the build will fail after your patch as it removes the ipfragok
argument?
Cheers,
--
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
--
To unsubscribe from this list: send the line "unsubscribe linux-sctp" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [net-next-2.6 PATCH 2/2] net: replace ipfragok with
@ 2010-04-16 6:43 ` Herbert Xu
0 siblings, 0 replies; 10+ messages in thread
From: Herbert Xu @ 2010-04-16 6:43 UTC (permalink / raw)
To: dccp
On Fri, Apr 16, 2010 at 10:26:09AM +0800, Shan Wei wrote:
>
> Now, PPPoX/PPPoL2TP driver still use ip_queue_xmit to send packets with ipfragok = 1.
> So, now we can't remove the && ... bit.
Huh? If they still call ip_queue_xmit with ipfragok then surely
the build will fail after your patch as it removes the ipfragok
argument?
Cheers,
--
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
--
To unsubscribe from this list: send the line "unsubscribe dccp" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [net-next-2.6 PATCH 2/2] net: replace ipfragok with skb->local_df
2010-04-16 6:43 ` Herbert Xu
(?)
@ 2010-04-16 6:49 ` Herbert Xu
-1 siblings, 0 replies; 10+ messages in thread
From: Herbert Xu @ 2010-04-16 6:49 UTC (permalink / raw)
To: Shan Wei
Cc: David Miller, yinghai.lu, kuznet, pekkas, jmorris,
yoshfuji@linux-ipv6.org >> YOSHIFUJI Hideaki,
Patrick McHardy, netdev, dccp, linux-sctp, kleptog, jchapman,
mostrows, acme
On Fri, Apr 16, 2010 at 02:43:44PM +0800, Herbert Xu wrote:
> On Fri, Apr 16, 2010 at 10:26:09AM +0800, Shan Wei wrote:
> >
> > Now, PPPoX/PPPoL2TP driver still use ip_queue_xmit to send packets with ipfragok == 1.
> > So, now we can't remove the && ... bit.
>
> Huh? If they still call ip_queue_xmit with ipfragok then surely
> the build will fail after your patch as it removes the ipfragok
> argument?
Nevermind, I was looking at the wrong tree.
Thanks,
--
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [net-next-2.6 PATCH 2/2] net: replace ipfragok with
@ 2010-04-16 6:49 ` Herbert Xu
0 siblings, 0 replies; 10+ messages in thread
From: Herbert Xu @ 2010-04-16 6:49 UTC (permalink / raw)
To: Shan Wei
Cc: David Miller, yinghai.lu, kuznet, pekkas, jmorris,
yoshfuji@linux-ipv6.org >> YOSHIFUJI Hideaki,
Patrick McHardy, netdev, dccp, linux-sctp, kleptog, jchapman,
mostrows, acme
On Fri, Apr 16, 2010 at 02:43:44PM +0800, Herbert Xu wrote:
> On Fri, Apr 16, 2010 at 10:26:09AM +0800, Shan Wei wrote:
> >
> > Now, PPPoX/PPPoL2TP driver still use ip_queue_xmit to send packets with ipfragok = 1.
> > So, now we can't remove the && ... bit.
>
> Huh? If they still call ip_queue_xmit with ipfragok then surely
> the build will fail after your patch as it removes the ipfragok
> argument?
Nevermind, I was looking at the wrong tree.
Thanks,
--
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
--
To unsubscribe from this list: send the line "unsubscribe linux-sctp" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [net-next-2.6 PATCH 2/2] net: replace ipfragok with
@ 2010-04-16 6:49 ` Herbert Xu
0 siblings, 0 replies; 10+ messages in thread
From: Herbert Xu @ 2010-04-16 6:49 UTC (permalink / raw)
To: dccp
On Fri, Apr 16, 2010 at 02:43:44PM +0800, Herbert Xu wrote:
> On Fri, Apr 16, 2010 at 10:26:09AM +0800, Shan Wei wrote:
> >
> > Now, PPPoX/PPPoL2TP driver still use ip_queue_xmit to send packets with ipfragok = 1.
> > So, now we can't remove the && ... bit.
>
> Huh? If they still call ip_queue_xmit with ipfragok then surely
> the build will fail after your patch as it removes the ipfragok
> argument?
Nevermind, I was looking at the wrong tree.
Thanks,
--
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
--
To unsubscribe from this list: send the line "unsubscribe dccp" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2010-04-16 6:49 UTC | newest]
Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <4BC70EF1.6080400@cn.fujitsu.com>
2010-04-15 22:33 ` [net-next-2.6 PATCH 2/2] net: replace ipfragok with skb->local_df David Miller
[not found] ` <20100415151926.GA4813@gondor.apana.org.au>
2010-04-16 2:26 ` Shan Wei
2010-04-16 2:26 ` Shan Wei
2010-04-16 2:26 ` Shan Wei
2010-04-16 6:43 ` Herbert Xu
2010-04-16 6:43 ` [net-next-2.6 PATCH 2/2] net: replace ipfragok with Herbert Xu
2010-04-16 6:43 ` Herbert Xu
2010-04-16 6:49 ` [net-next-2.6 PATCH 2/2] net: replace ipfragok with skb->local_df Herbert Xu
2010-04-16 6:49 ` [net-next-2.6 PATCH 2/2] net: replace ipfragok with Herbert Xu
2010-04-16 6:49 ` Herbert Xu
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.